Repository navigation
feat(libSceNetCtlApDialog): run the common-dialog state machine - #3941
Closed
semirkabir wants to merge 1 commit into
Closed
semirkabir wants to merge 1 commit into
semirkabir wants to merge 1 commit into
Conversation
The access-point dialog shows nothing and reports the user as having cancelled, following the libSceErrorDialog and libSceLoginDialog pattern. Adds the seventh export sceNetCtlApDialogGetStatus (NID eBWS-HorSWY), whose signature is assumed from the other common dialogs, a guest test, and a TechnicalDebt entry covering the assumed signatures and error codes.
Progress report (a11c8f7 → d2d997a)📈 System libraries: 85.99% (+0.18%, +7 implemented functions) ✅ 7 implemented
⚪ 1 behaviourally empty (constant return or throw)
|
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
|
9 tasks done
Collaborator
|
Closing: no title is shown reaching libSceNetCtlApDialog, and the no-argument signatures and the error codes are assumed. Reopen with the title ID and the log line where one stops on these exports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Runs the access-point dialog through the common-dialog state machine (none, initialized, running, finished), following libSceErrorDialog and libSceLoginDialog. The dialog shows nothing and reports the user as having cancelled. Adds the seventh export
sceNetCtlApDialogGetStatus(NIDeBWS-HorSWY), a guest test, and a TechnicalDebt entry for the assumed signatures and error codes.Tested
Linux x86-64, GCC. Built the patched and unpatched
libSceNetCtlApDialog.prx(7 exports each) and ranguest_netctl_ap_dialog(ctest passes). Not tested on hardware.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt.mdfiles or images added to the repository (attach them to this PR)