Skip to content

feat(libSceNetCtlApDialog): implement common dialog state machine - #4098

Closed
jagrat04 wants to merge 1 commit into
boykopovar:mainfrom
jagrat04:feat/libSceNetCtlApDialog
Closed

jagrat04 wants to merge 1 commit into
boykopovar:mainfrom
jagrat04:feat/libSceNetCtlApDialog

Conversation

@jagrat04

Copy link
Copy Markdown
Contributor

What

Implement the common dialog state machine for libSceNetCtlApDialog:

  • sceNetCtlApDialogInitialize: sets status to Initialized, rejecting re-initialization with COMMON_DIALOG_ERROR_ALREADY_INITIALIZED.
  • sceNetCtlApDialogOpen: checks param, sets status to Finished.
  • sceNetCtlApDialogUpdateStatus: returns dialog status.
  • sceNetCtlApDialogGetResult: returns COMMON_DIALOG_RESULT_USER_CANCELED (1) once finished.
  • sceNetCtlApDialogClose: succeeds if initialized.
  • sceNetCtlApDialogTerminate: resets status to None.
  • Added guest test in core/libs/tests/GuestNetCtlApDialog.cpp.
  • Documented in docs/dev/TechnicalDebt.md.

Tested

  • python tools/check_conventions.py passed with 0 violations.

Checklist

  • Based on current main; no other open PR implements the same functions
  • One topic per PR; follow-ups go in a new PR
  • No comments in code except technical debt
  • Unimplemented paths throw (NotImplemented_nid_no_patch); silent stubs are listed in TechnicalDebt
  • No notes, investigation .md files or images added to the repository (attach them to this PR)
  • New third-party code is a submodule built from source
  • Generic behaviour, not specific to one title
  • Depends on: none
  • AI-assisted: yes

@github-actions

Copy link
Copy Markdown

Progress report (bab7b32 → 268124a)

📈 System libraries: 86.65% (+0.18%, +6 implemented functions)

✅ 6 implemented
Library Name
libSceNetCtlApDialog sceNetCtlApDialogClose
libSceNetCtlApDialog sceNetCtlApDialogGetResult
libSceNetCtlApDialog sceNetCtlApDialogInitialize
libSceNetCtlApDialog sceNetCtlApDialogOpen
libSceNetCtlApDialog sceNetCtlApDialogTerminate
libSceNetCtlApDialog sceNetCtlApDialogUpdateStatus

@github-actions

github-actions Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.

Pull request Conflicting files (lines on main) Same exports Same new files
#4118 docs/dev/TechnicalDebt.md L20
#4218 docs/dev/TechnicalDebt.md L20

@oneandonlydean

Copy link
Copy Markdown
Collaborator

Closing, same as #4089: no title is shown to open the AP dialog, and a silent dialog goes in when a title is blocked by it. Please reopen with the title ID and the log line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants