Skip to content

feat(libSceNpAuth): return the signed-out error from sceNpAuthGetAuthorizedAppCode - #4218

Merged
adriadam10 merged 1 commit into
boykopovar:mainfrom
Mouad-Scriptz-0:feat/signin-dialog-npauth-signed-out
Oct 12, 2026
Merged

adriadam10 merged 1 commit into
boykopovar:mainfrom
Mouad-Scriptz-0:feat/signin-dialog-npauth-signed-out

Conversation

@Mouad-Scriptz-0

@Mouad-Scriptz-0 Mouad-Scriptz-0 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

What

After its sign-in dialog Minecraft (PPSA17221) calls sceNpAuthGetAuthorizedAppCode, which #4118 declares as a throwing stub because the title fails to load without the import. There is no PSN sign-in, so it now returns SCE_NP_ERROR_SIGNED_OUT without reading its unknown parameters, and the title treats that as offline play. The request, token and wait calls this PR implemented earlier are left to #3604, which models them per request and is further along in review.

Tested

Fedora 44 (kernel 7.2.8, GCC 16.2.1, Ninja, Release, BUILD_TESTING=ON), branch on #4118 rebased onto main c36fd0a: guest_np_auth_authorized_app_code passes; tools/check_conventions.py --base origin/main and git diff --check pass. Minecraft (PPSA17221) reaches its menu and plays with the earlier, wider version of this change (Linux). Not tested on Windows.

Checklist

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Progress report (2fabe44 → 09c9854)

📈 System libraries: 87.43% (+0.03%, +1 implemented functions)

✅ 1 implemented
Library Name
libSceNpAuth sceNpAuthGetAuthorizedAppCode
⚪ 1 behaviourally empty (constant return or throw)
Library Name
libSceNpAuth sceNpAuthGetAuthorizedAppCode

@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Oct 12, 2026
@Mouad-Scriptz-0
Mouad-Scriptz-0 force-pushed the feat/signin-dialog-npauth-signed-out branch from 3299e30 to 4bf4896 Compare October 12, 2026 08:58
@Mouad-Scriptz-0 Mouad-Scriptz-0 changed the title feat(libSceNpAuth): report a signed-out user instead of throwing feat(libSceNpAuth): return the signed-out error from sceNpAuthGetAuthorizedAppCode Oct 12, 2026
@github-actions github-actions Bot removed the needs rebase Conflicts with main, rebase needed label Oct 12, 2026
@Mouad-Scriptz-0
Mouad-Scriptz-0 force-pushed the feat/signin-dialog-npauth-signed-out branch from 4bf4896 to 5edd2be Compare October 12, 2026 12:25
@xXPBSXx

xXPBSXx commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Windows test of head 5edd2be1c merged onto current main (2a5eca11c, clean merge; built together with two other open PRs, so the run is for the combination): Windows 10 (19045), MinGW-w64 GCC 15.2.0 (WinLibs r7), Release, full build 0 errors, -j2.

guest_np_auth_authorized_app_code (the test this PR adds) passes. The 25 tests matching ^(guest_memory|guest_np_auth|windows_exceptions|guest_exception|guest_kernel) all pass.

Not checked: that the test fails without the change, Linux, a title run.

AI-assisted (Claude Code).

@github-actions github-actions Bot added the needs rebase Conflicts with main, rebase needed label Oct 12, 2026
…orizedAppCode

There is no PSN sign-in, so the code getter answers SCE_NP_ERROR_SIGNED_OUT
instead of throwing; its parameters are unknown and not read. Minecraft
(PPSA17221) calls it after its sign-in dialog and treats the result as
offline play. The request, token and wait calls are left to boykopovar#3604.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@adriadam10
adriadam10 force-pushed the feat/signin-dialog-npauth-signed-out branch from 5edd2be to 09c9854 Compare October 12, 2026 20:57
@adriadam10

Copy link
Copy Markdown
Collaborator

Checked: the new test fails without the change and passes with it; rebased onto current main (only conflict: the TechnicalDebt line moved to docs/dev/debt/libSceNpAuth.md, updated there); build and ctest green; the signed-out value matches the constant already used in libSceNpUtility; Windows test by @xXPBSXx and Minecraft Settings check by @Pacuka noted. Merging once CI is green.

@adriadam10
adriadam10 merged commit 4998307 into boykopovar:main Oct 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build docs needs rebase Conflicts with main, rebase needed prx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants