Repository navigation
Conversation
|
I checked the exact head: the source contains 150 unique export aliases, and every debt entry maps to one of those names with the NID recomputed by I’ve noticed that asking you to hold this PR based on #5239 was unnecessary. It’s fine to keep submitting PRs; maintainers will handle them in due course. Please disregard my earlier request to hold it. |
|
Thanks for the exact-head audit. The shared CMake/debt comparisons with #5021 and #6044, and the combined debt-file ordering with #9511, remain unresolved on this branch. I am leaving this draft and will not present the earlier overlap/build checks as current; a current-main rebase and fresh exact NID/overlap/conventions/target-build checks are still required before review can proceed. I also saw the later clarification withdrawing the queue hold, so I am not treating #5239 as a blocker. |
ccb5b0d to
38826a0
Compare
|
Fresh NID/overlap audit against |
|
I’ve noticed that asking you to hold this PR was unnecessary. It’s fine to keep submitting PRs; maintainers will handle them in due course. |
38826a0 to
fd10721
Compare
fd10721 to
a0ec465
Compare
MarcZX10
left a comment
There was a problem hiding this comment.
I reviewed the exact head's export/debt consistency: InventoryExports6.cpp has 150 unique NIDs and 150 unique aliases; all 150 bodies call NotImplemented_nid_no_patch, and each NID is represented in the debt file. The declarations make no ABI claims, consistent with the stated import-resolution scope. Exact-head git diff --check and tools/check_conventions.py --base upstream/main --head upstream/pr-9665 pass. Hosted eligibility, conventions, intake, labels and report pass; product builds are skipped by policy. No implementation tests are applicable to these throwing declarations, and I have not run a full library build.
One integration blocker remains: against current upstream main 16319642a4c84e861188b75583ce853dfbe0a101, tools/check_main_sync.py --base upstream/main --head upstream/pr-9665 reports 4 commits ahead / 10 behind (merge base 9d6adeb55), with a clean merge. Please merge current main and rerun the NID/inventory, overlap and conventions checks on the resulting head. Preserve the overlapping CMake/debt contributions from #9511, #5021, #6044, #9133 and #9669, and update the dependency/order checklist if the integration order changes. This is a current-main integration request, not a queue-volume objection.
9cd4078 to
a456288
Compare
|
On the current PR head, local conventions and diff checks pass, and check_main_sync.py reports 4 ahead / 0 behind current upstream/main (0db47b2) with a clean merge. The Windows and WSL libSceLibcInternal targets are up to date. The prior sync request referenced a different base SHA; the current base-sync check is clear. I am keeping this in draft until the shared CMake/debt ordering with #9511, #5021, #6044 and #9133 is reconciled; #9669 is later-opened and needs to preserve these declarations when its overlapping files are combined. |
b1a58f7 to
e65dc36
Compare
|
Other open pull requests touch the same code. Merging one will break the other, or both implement the same thing. If this one builds on them, list them in Depends on.
Some comparisons could not be completed because a pull request conflicts with the base branch. Review these shared files manually before concluding that there is no overlap.
|
e65dc36 to
d3c6cbd
Compare
|
I applied the same literal-NID correction to this batch and rebased it on current upstream main. All 150 source/debt pairs match |
|
Relevant warning: the bot could not compare the shared CMake/debt paths against conflicting PRs #9669 and #10749. Those PRs change process/signal implementations in other source files; this PR adds the libc internal inventory declarations in |
|
This is rebased on current upstream main at f26434a. I corrected the literal NID issue across all 150 exports and audited all source/debt pairs against tools/nid_names.py (150/150). Current hosted conventions pass; product/platform builds are skipped. The full built raw/patched-provider import-resolution audit requested by Dean remains outstanding, and the bot cannot compare shared CMake/debt paths with conflicted #9669/#10749, so I am not claiming complete integration validation. |
|
I’ve closed my PRs because, based on my personal experience, I’ve decided I will no longer contribute to or update them. This decision is about my experience with the public community and is not directed at the maintainers or active reviewers, whose time and work I appreciate. Thank you for reviewing and discussing my contributions. I wish the project and its maintainers well. |
1 similar comment
|
I’ve closed my PRs because, based on my personal experience, I’ve decided I will no longer contribute to or update them. This decision is about my experience with the public community and is not directed at the maintainers or active reviewers, whose time and work I appreciate. Thank you for reviewing and discussing my contributions. I wish the project and its maintainers well. |
What
Adds 150 confirmed PS5 3.20
libSceLibcInternalexport declarations. The symbol/NID pairs match the local import-stub inventory and public PS5 3.20 export inventory. Every declaration uses the repository's parameterless unknown-signature convention and callsNotImplemented_nid_no_patch; these are for import resolution only and make no ABI claims. The technical-debt file records every export and NID.Tested
mainatf26434afa36e58778a9ff4b948aea52dff19eb0c.tools/nid_names.pyexactly.python -I tools/check_conventions.py --base upstream/main --head HEAD— passed locally.git diff --check upstream/main...HEAD— passed locally.InventoryExports6.cpp; maintainers may still need to reconcile the shared CMake/debt sections.Checklist
main; no other open PR implements the same functionsNotImplemented_nid_no_patch); silent stubs are listed under Silent stubs in their library's technical debt file.mdfiles or images added to the repository (attach them to this PR)