Repository navigation
fix(browser): POLISH-APP-3 — drain design drift - #412
Merged
Merged
Conversation
Drift: 17 literal colors -> 0. All were dead light-theme hex fallbacks (var(--color-text-primary, #111) / secondary #555 / border #e3e3e3) on tokens the SDK app-theme sheet guarantees — styles.css only loads in the app page, never guest content, so the fallbacks could never fire where tokens are absent. Rubric walk: chrome already compliant (shared menus with anchors, EmptyState start page, tab family is deliberate neutral chrome). Evidence: harness session 312 (both app themes; dark pass is the one a live light-hex fallback would have broken). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POLISH-APP-3 — Browser (third rung of the per-app design-polish program)
Drift drain: 17 literal colors → 0 in
apps/browser/src/styles.css(fleet total 103 → 86). All 17 were dead light-theme hex fallbacks (var(--color-text-primary, #111),--color-text-secondary, #555,--color-border-subtle, #e3e3e3) on tokens the SDK app-theme sheet guarantees. Checked before dropping:styles.cssis imported only by the app page (main.tsx) — guest content renders in a separate BrowserView, so the fallbacks could never fire anywhere tokens are absent.Rubric walk: chrome verified compliant — every menu on the shared runtime with anchor elements (history Start-aligned under its button, overflow ⋯ End-aligned), start page on the shared
<EmptyState>, panel toggles fine. The active-tab neutral surface fill is deliberate tab-family chrome (OS-tab convention), not the list-row selection case.Evidence: harness session
312-polish-browser-both-themes— start page + tab strip + history menu in both app themes. The dark pass is the discriminating one: any chrome actually leaning on a light-hex fallback would render unthemed there. All clean.Verify:
bun run verifygreen (exit 0); browser suite 15 files / 158 tests green; per-apptscclean.🤖 Generated with Claude Code