Macros Performance - Remove redundant chain.define (?)#1207
Merged
castwide merged 1 commit intoJun 1, 2026
Conversation
This seem to be causing the performance issues reported castwide#1194 (comment)
lekemula
commented
Jun 1, 2026
| next | ||
| end | ||
| end | ||
| pin = chain.define(self, closure, []).first |
Contributor
Author
There was a problem hiding this comment.
@castwide do you remember the original reason this was added for?
Owner
There was a problem hiding this comment.
Good catch! That was the original routine I tested for resolving method calls to pins. The newer routine at line 142 does the same thing without the expense of a chain definition. I just neglected to delete the original.
lekemula
changed the title
lekemula
changed the title
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be causing the performance issues reported #1194 (comment)
After removing these lines, specs still were passing locally, and I could not see the performance degradation as reported in the comment above.