Skip to content

Macros Performance - Remove redundant chain.define (?) #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
castwide merged 1 commit into from
Jun 1, 2026
+0 −5
Merged

Macros Performance - Remove redundant chain.define (?) #1207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions lib/solargraph/api_map.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,6 @@ def process_macros
next
end
end
pin = chain.define(self, closure, []).first
Copy link
Copy Markdown
Contributor Author

@lekemula lekemula Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@castwide do you remember the original reason this was added for?

Copy link
Copy Markdown
Owner

@castwide castwide Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! That was the original routine I tested for resolving method calls to pins. The newer routine at line 142 does the same thing without the expense of a chain definition. I just neglected to delete the original.

next unless pin&.macros&.any?
pin.macros.each do |macro|
macro_pins.concat macro.generate_pins_from(chain, pin, source_map)
end
end
end
macro_pins
Expand Down
Loading