Skip to content

No longer map zh_TW language to zh language code in dev translations.#1442

Open
Mati365 wants to merge 11 commits into
masterfrom
ck/10480
Open

No longer map zh_TW language to zh language code in dev translations.#1442
Mati365 wants to merge 11 commits into
masterfrom
ck/10480

Conversation

@Mati365

@Mati365 Mati365 commented Jul 21, 2026

Copy link
Copy Markdown
Member

🚀 Summary

No longer map zh_TW language to zh language code in dev translations.


📌 Related issues

@Mati365
Mati365 marked this pull request as ready for review July 21, 2026 11:38
@Mati365
Mati365 requested a review from a team July 21, 2026 11:38
Comment thread packages/ckeditor5-dev-translations/tests/utils/getlanguages.js Outdated
Comment thread packages/ckeditor5-dev-translations/tests/utils/getlanguages.js Outdated
Comment thread packages/ckeditor5-dev-translations/tests/utils/getlanguages.js

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d04e332. Configure here.

'sr@latin': 'sr-latn',
'zh_TW': 'zh'
'zh@hans': 'zh-hans',
'zh@hant': 'zh-hant'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong Chinese languageCode derivation

High Severity

languageCode is still computed by taking only the first segment of the locale before @, so zh@hans and zh@hant both yield zh. That conflicts with the changelog and tests, which expect zh-Hans and zh-Hant. The filename mapping was updated, but languageCode derivation was not, so the intended breaking change does not take effect.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d04e332. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant