-
Notifications
You must be signed in to change notification settings - Fork 30
No longer map zh_TW language to zh language code in dev translations.
#1442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mati365
wants to merge
13
commits into
master
Choose a base branch
from
ck/10480
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−6
Open
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3bf39bb
no longer map `zh_TW` language to `zh` language code
Mati365 9af2e8a
fix test
Mati365 6d4f29c
fix typo
Mati365 1ec9c89
fix typo
Mati365 22f1f66
Merge branch 'master' into ck/10480
Mati365 c8cb8cc
Adjust config
Mati365 1f51cea
Adjust changelog
Mati365 6670d99
Adjust languages
Mati365 d04e332
Adjust testing.
Mati365 2c3b608
fix tests
Mati365 ad0ff0e
fix changelog
Mati365 d94ff45
fix languages getter
Mati365 ef72219
Merge branch 'master' into ck/10480
Mati365 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| --- | ||
| type: Major breaking change | ||
| scope: | ||
| - ckeditor5-dev-translations | ||
| see: | ||
| - https://github.com/ckeditor/ckeditor5-commercial/issues/10480 | ||
| --- | ||
|
|
||
| The `zh_CN` and `zh_TW` locale codes have been replaced with `zh_Hans` and `zh_Hant`, respectively, to correctly represent Simplified and Traditional Chinese as script variants instead of country/region variants. | ||
|
|
||
| As a result: | ||
|
|
||
| * The `zh_TW` language code is no longer mapped to the `zh.po` file. It now emits `zh-hant.po` instead. | ||
| * The `zh_CN` language code now emits `zh-hans.po` instead of `zh-cn.po`. | ||
| * The `languageCode` for these locales changed from `zh` (for both) to `zh-Hans` and `zh-Hant`, respectively. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.