Fix playback speed not applying (#4191) - #4213
Open
saivinaypotluri wants to merge 1 commit into
Open
Conversation
Set both player.setPlaybackRate and video.playbackRate in playbackSpeed so the UI and actual A/V stay in sync (especially Safari). Fixes code-charity#4191.
saivinaypotluri
changed the title
Collaborator
|
hi @saivinaypotluri, thank you! handmade or LLM? If LLM i guess it could be shorter / less to review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ImprovedTube.playbackSpeednow sets bothplayer.setPlaybackRateandvideo.playbackRate(same pattern as forced speed).showStatus.Fixes 🐞speed increases button #4191