Skip to content

Fix playback speed not applying (#4191) #4213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saivinaypotluri wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix playback speed not applying (#4191) #4213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 18 additions & 15 deletions js&css/web-accessible/www.youtube.com/player.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,18 @@ ImprovedTube.playbackSpeed = function (newSpeed) {
// called with no option or demanded speed already set, only provide readback
if (!newSpeed || speed == newSpeed) return speed;

if (video?.playbackRate) {
video.playbackRate = newSpeed;
newSpeed = Number(video.playbackRate.toFixed(2));
} else if (player?.setPlaybackRate && player.getPlaybackRate) {
if (player?.setPlaybackRate) {
player.setPlaybackRate(newSpeed);
newSpeed = Number(player.getPlaybackRate().toFixed(2));
} else newSpeed = false;
}
if (video) {
video.playbackRate = newSpeed;
}

const applied = video?.playbackRate
? Number(video.playbackRate.toFixed(2))
: (player?.getPlaybackRate ? Number(player.getPlaybackRate().toFixed(2)) : false);

return newSpeed;
return applied;
};
/*------------------------------------------------------------------------------
PERMANENT PLAYBACK SPEED
Expand Down Expand Up @@ -1115,8 +1118,8 @@ ImprovedTube.playerPlaybackSpeedButton = function () {
// Left click: set to custom speed from settings
if (e.button === 0) {
var customSpeed = ImprovedTube.storage.player_playback_speed || 1.25;
ImprovedTube.playbackSpeed(customSpeed);
ImprovedTube.showStatus(customSpeed + 'x');
var appliedSpeed = ImprovedTube.playbackSpeed(customSpeed);
if (appliedSpeed) ImprovedTube.showStatus(appliedSpeed + 'x');
}
},
title: 'Playback Speed (Scroll: adjust, Left: custom, Right: 1.0x)'
Expand All @@ -1126,8 +1129,8 @@ ImprovedTube.playerPlaybackSpeedButton = function () {
button.addEventListener('contextmenu', function (e) {
e.preventDefault();
e.stopPropagation();
ImprovedTube.playbackSpeed(1.0);
ImprovedTube.showStatus('1.0x');
var appliedSpeed = ImprovedTube.playbackSpeed(1.0);
if (appliedSpeed) ImprovedTube.showStatus(appliedSpeed + 'x');
});

// Add wheel handler
Expand All @@ -1146,8 +1149,8 @@ ImprovedTube.playerPlaybackSpeedButton = function () {
newSpeed = Math.max(currentSpeed - step, 0.0625);
}

ImprovedTube.playbackSpeed(newSpeed);
ImprovedTube.showStatus(newSpeed.toFixed(2) + 'x');
var appliedSpeed = ImprovedTube.playbackSpeed(newSpeed);
if (appliedSpeed) ImprovedTube.showStatus(appliedSpeed.toFixed(2) + 'x');
});
}
};
Expand Down Expand Up @@ -2097,8 +2100,8 @@ ImprovedTube.playerIncreaseDecreaseSpeedButtons = function () {
position: "right",
child: svg1x,
onclick: function () {
ImprovedTube.playbackSpeed(1);
ImprovedTube.showStatus('1x');
const appliedSpeed = ImprovedTube.playbackSpeed(1);
if (appliedSpeed) ImprovedTube.showStatus(appliedSpeed + 'x');
},
title: 'set speed to 1x',
}).classList.remove('it-player-button');
Expand Down
4 changes: 2 additions & 2 deletions js&css/web-accessible/www.youtube.com/shortcuts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ ImprovedTube.shortcutPlaybackSpeed = function (key) {

if (speed === undefined || isNaN(speed)) return;

ImprovedTube.playbackSpeed(speed);
ImprovedTube.showStatus(speed);
const appliedSpeed = ImprovedTube.playbackSpeed(speed);
if (appliedSpeed) ImprovedTube.showStatus(appliedSpeed);
};
/*------------------------------------------------------------------------------
4.7.2 PICTURE IN PICTURE (PIP)
Expand Down