Evaluate OpenTUI map rendering and vector tile output - #225
Evaluate OpenTUI map rendering and vector tile output#225trevorgerhardt wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🦋 Changeset detectedLatest commit: aa57ba5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d4f15b521d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const osm = this.get(id); | ||
| const renderIndex = this.getSemanticRenderIndex(id); | ||
| const nodeIndex = tile[2] >= 14 ? this.getSemanticNodeIndex(id) : undefined; | ||
| const packet = buildVectorTile( |
There was a problem hiding this comment.
On runtimes without SharedArrayBuffer, this supposedly cooperative path calls the fully synchronous buildVectorTile and does not yield until the entire tile is complete. Because cancelTilesBefore runs on the same worker event loop, pans and zooms cannot update tileGenerationGate during a complex tile build, so stale work blocks the sole fallback worker—and therefore newer tiles and label queries—until completion. Split vector construction into cooperative chunks or provide an async yielding implementation like drawStyledMapTileAsync.
Useful? React with 👍 / 👎.
1 participant
Summary
Testing