Repository navigation
Conversation
d-tietjen
commented
Oct 2, 2026
d-tietjen
left a comment
Owner
Author
There was a problem hiding this comment.
Independent review of exact head 5050a46fdc06e68d1173f62a5f6bfad35b6d6365 (tree 9d36b4bfc5371c78c5a4e365f6b28d2cfa07973c): CLEAN within the scope below.
- The three benchmark documentation/data changes match the accepted measurements. All 700 other tracked blobs, including Rust, Cargo, benchmark scripts and crate rustdoc inputs, are identical to measured source
78c83addff5f140236f9a659ff1e332bb9c35522. Existing source78/source98 receipts retain their original provenance; this documentation head has no fresh build or benchmark claim. A new Docker build would have a different source/context identity. - Source78 affected correctness, layout, feature-forwarding/minimal checks and fresh native evidence are accepted. Older default/off-feature evidence retains its older provenance. The original three-alias check's numeric outer-wrapper status remains unverified; independently audited full check08 closes alias correctness with a genuine zero wrapper exit.
- MD05's final 510-entry manifest (
8ebb5d8a23e4754c0a619ae1104fa157594ead355bce4e50b2e0b5874ecfd544), all 90 rows/900 PID1 sample gates, source/compiler/native bindings, actual limits, sampled bounds, genuine outer status 0 and exact owned cleanup were independently checked. The canonical terminal result is success true; the separate progress file remains its pre-terminal checkpoint. - Independent numerical recomputation agrees with the documented ratios of three-run medians. Small-value incremental PSS improves and all 20 performance screens pass. The strict larger-value memory screen is not fully met: compressible 1024 bytes increases 18 KiB, high-entropy 1024 increases 38 KiB, and high-entropy 4096 increases 94 KiB. Their causes and statistical significance are unknown.
These remain opt-in experimental, shared-host, unreserved, closed-loop diagnostics. They establish neither a capacity reservation nor formal performance qualification. Mixed-length fragmentation, shared-owner workloads, peaks and mutation-heavy online maintenance require separate evidence. Any subsequent product head requires its own exact-head review and affected validation.
Keep the fixed shared-read checkpoint protocol fields explicit at each phase boundary. This follows the existing benchmark convention for functions that bind several independent measurement fields. The current PR already contains the storage and RESP selector lint fixes. Refs EDEN-2266
Validate final row identities before routing high-water summaries. Preserve explicit rejection of incomplete and duplicate observations, and cover both malformed and complete duplicate identities. Refs EDEN-2266
Register each uncovered host span using its half-open byte count. Resolve the CUDA-only strict Clippy failures without changing the public transfer handle or GPU copy behavior. Refs EDEN-2424
Require the new internal package versions for compact-storage feature forwarding. Supply both local dependency patches during archive preparation so pre-publication checks do not resolve against the old registry feature surface. Refresh installation guidance, the dependency inventory and the unreleased changelog. Preserve all third-party lock inputs and historical benchmark versions. Refs EDEN-2425
Refs: EDEN-2426
Describe the OnceLock public API checks without claiming concurrent initializer or discarded-initializer counts. Refs EDEN-2266
d-tietjen
force-pushed
the
devon/eden-2266-reduce-small-value-shardcache-memory-overhead-without
branch
from
October 7, 2026 04:53
366fdc0 to
ad9b62e
Compare
Refs EDEN-2266. Integrates EDEN-2425 and EDEN-2426 into the feature candidate.
d-tietjen
marked this pull request as ready for review
October 7, 2026 07:36
d-tietjen
deleted the
devon/eden-2266-reduce-small-value-shardcache-memory-overhead-without
branch
October 7, 2026 11:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eligible plain string entries carry substantial per-entry allocation overhead. This change adds opt-in
experimental-compact-point-storage, packing eligible keys and values into reusable chunks while preserving general-storage fallback, TTL/metadata semantics, shared ownership and bounded reclamation.Issue: EDEN-2266.
The compact path borrows small RESP values and retains the reviewed
OnceLockowner implementation. General entries omit duplicated key-length metadata. Correctness coverage includes replacements, promotion, epochs, scans, snapshots and absolute-expiry KEEPTTL handling. The feature remains off by default.The candidate includes the optional CUDA correction, coherent unpublished 0.9.1 package versions (EDEN-2425 / PR32), and fixed chacha20 0.10.2 (EDEN-2426 / PR33). These release corrections are integrated into this feature branch.
Validation
Final PR head is
1c15b0af51708185a047fdf9d94a5bee31a2af7b, tree8bcc6e876ee49c5b7dbeedd0a55feaee0dfc553b. Independent review verifies that product source, configuration, lockfile, packaging and release scripts are identical to tested proposalfc27e450ae2abb6c66ec464733fbd41ce63fedb1. The only difference is the reviewed shared-read documentation correction.scripts/proof-gate.sh releasepassed with its completion marker and genuine zero child exit/reap. Feature/TLS/dependency/public documentation gates passed. Existing live S3 checks retain their documented environment-gated scope.The maintainer waived CPU reservation and peer exclusion for this focused validation. The independently admitted runner retains its own server/client affinity, CPU/memory/PID limits, genuine build/image/source binding, raw signed PSS/ANON samples, native wait receipts, bounded runtime and exact owned cleanup. Results have unreserved diagnostic scope; shared-host interference remains possible. All 22 offline runner fixtures passed before execution. Old compiler-cache cleanup reclaimed 51.9 GB while preserving source and evidence; the unchanged 100 GB disk floor passed.
Observed three-repeat results
Ratios use the medians of three fresh repeats. Memory is loaded-minus-idle incremental process PSS and cgroup ANON; throughput and p99 compare compact-on with the same-source feature-off arm. These are unreserved diagnostics, with possible shared-host interference.
All ten numeric screens passed. Small-value incremental PSS is about 14–21% below Redis; the 1 KiB/4 KiB advantage is retained. Worst observed throughput loss is below 0.74% and largest p99 increase is 1.63%, within the original 5% limits. All individual signed memory increments are positive, and ANON agrees with the PSS direction in every shape.
Independent final result review accepted all 90 observations, 900 raw memory samples, native wait/CSV receipts, original numeric thresholds and ANON corroboration. It verified empty owned-container queries, absent original controller/cgroup, unchanged admitted inputs, final product equivalence and successful final-head CI. The result supports feature-gated PR readiness under the maintainer’s CPU-reservation waiver; it grants no reserved performance claim or automatic production enablement. The compact feature remains off by default. Expanded capacity/HWM and shared-read campaigns remain separate follow-up coverage; historical diagnostics retain their original source/scope. No main merge or registry publication occurred.