[code_assets] Support custom target OS and Architecture#3413
Conversation
PR Health
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| hooks | Non-Breaking | 2.0.2 | 2.1.0-wip | 2.1.0-wip | ✔️ |
| code_assets | Non-Breaking | 1.2.1 | 2.0.0-wip | 2.0.0-wip | ✔️ |
| hooks_runner | Non-Breaking | 1.5.0 | 1.6.0-wip | 1.6.0-wip | ✔️ |
| native_toolchain_c | Non-Breaking | 0.19.2 | 0.19.3-wip | 0.19.3-wip | ✔️ |
| objective_c | Non-Breaking | 9.4.1 | 9.4.2 | 9.5.0 Got "9.4.2" expected >= "9.5.0" (non-breaking changes) |
This check can be disabled by tagging the PR with skip-breaking-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|
This check can be disabled by tagging the PR with skip-leaking-check.
c57aaef to
5faa75d
Compare
Package publishingIf you have publishing permissions, you can use the links below to publish the changes after merging this PR.
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
0dfe2f3 to
27eeaef
Compare
27eeaef to
4d6c36c
Compare
4d6c36c to
4b771f3
Compare
|
@goderbauer I'm not entirely sure what to do with link mode preference and link mode:
If we decide to lock it down, then the way to add something later from our side would be to make a new asset type And I can't think of a link mode we would add in the first place. WDYT about locking it down instead of making it extensible? |
Yeah, given that it is highly questionable that we'll ever add another mode (famous last words): Let's lock it down. |
128f9fb to
de8fd8a
Compare
de8fd8a to
23dc6db
Compare
23dc6db to
761c686
Compare
Made a separate PR for this: |
761c686 to
6ce683f
Compare
fa60898 to
0a837af
Compare
6ce683f to
009567e
Compare
009567e to
4f941ad
Compare
Closes: #3411
Closes: #1258
Enables
to work properly.
The other open enums in the JSON schema that were not open in the Dart API:
Link mode and link mode preference should be closed:
LinkModeandLinkModePreferenceclosed #3462If we were to add code assets already presigned and prepackaged in xcodeframeworks for example, it would be a new asset type, rather than new option for the existing asset type.
Because we don't have a pub workspace for FFIgen and JNIgen with the other packages, we now need many more pubspec overrides. Basically before it was kinda working without a complete set of overrides because the inconsistent set of deps (half from the repo, half from pub) managed to resolve. This is no longer true with pushing
code_assetstov2.0.0.