[code_assets] Make LinkMode and LinkModePreference closed#3462
Open
dcharkes wants to merge 1 commit into
Open
Conversation
PR Health
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| hooks_runner | Non-Breaking | 1.5.0 | 1.6.0-wip | 1.6.0-wip | ✔️ |
| code_assets | Non-Breaking | 1.2.1 | 1.2.1 | 1.3.0 Got "1.2.1" expected >= "1.3.0" (non-breaking changes) |
|
| data_assets | None | 0.20.0 | 0.20.0 | 0.20.0 | ✔️ |
| hooks | Non-Breaking | 2.0.2 | 2.1.0-wip | 2.1.0-wip | ✔️ |
| record_use | Non-Breaking | 0.6.0 | 1.0.0-wip | 1.0.0-wip | ✔️ |
This check can be disabled by tagging the PR with skip-breaking-check.
API leaks ✔️
The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
| Package | Leaked API symbol | Leaking sources |
|---|
This check can be disabled by tagging the PR with skip-leaking-check.
dcharkes
force-pushed
the
code-assets-close-link-mode
branch
from
July 9, 2026 09:20
1c27232 to
fa60898
Compare
dcharkes
marked this pull request as ready for review
July 9, 2026 09:43
dcharkes
force-pushed
the
code-assets-close-link-mode
branch
from
July 10, 2026 07:33
fa60898 to
0a837af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the link mode and link mode preference closed enums / a closed tagged union.
#3413 (comment)
Code assets changes:
LinkModeclass.JSON syntax generator changes:
_throwFormatException._throwFormatException.Set<String>? expectedValuesparameter tothrowFormatExceptionanderrorStringto format error messages asExpected one of 'a', 'b'.expectedTypean optional named parameter onthrowFormatExceptionanderrorStringinhelper_library.dart.Other package changes: