Repository navigation
debezium/dbz#1809 Standardize Examples — JPA Aggregations - #500
Conversation
Signed-off-by: samson30 <60385580+samson30@users.noreply.github.com>
…n jpa-test Signed-off-by: samson30 <60385580+samson30@users.noreply.github.com>
Thanks @Naros, done. Jackson now comes from the parent's BOMs (2.21.2, so all the Jackson modules are aligned), and SLF4J uses the parent's |
| @@ -11,12 +18,20 @@ | |||
| <version.com.h2database>1.3.176</version.com.h2database> | |||
| <version.junit>4.13.1</version.junit> | |||
| <version.org.hibernate>5.4.24.Final</version.org.hibernate> | |||
There was a problem hiding this comment.
We specifically test with JDK 21, and while Hibernate 5 appears to work with it, it isn't supported and requires at least Hibernate 6. Since Hibernate 8 is now in beta, could you raise a follow-up PR to bump this to the latest Hibernate 7.x?
There was a problem hiding this comment.
Thanks @Naros! I will open a follow-up PR to move jpa-test to Hibernate 7.x (jakarta.persistence, org.hibernate.orm). The parent's Quarkus BOM currently manages hibernate-core 7.2.14.Final. Would you prefer I use that managed version, or pin the latest 7.x release explicitly?
Fixes debezium/dbz#1809.
Description
Standardizes the jpa-aggregations example (
jpa-testandjson-smt-es).debezium-examples-parentas their parent, so Java 21 and the compiler plugin version come from the root POM instead of the local Java 8 and compiler 3.8.1 settings.connect-jsonis no longer pinned to Kafka 3.4.0; its version is now managed by the Debezium BOM (4.3.1).ExpandJsonSmtonly uses Connect APIs that are unchanged in Kafka 4.jpa-test: pinsslf4j-apito 1.7.36 independencyManagement. The parent's BOMs manageslf4j-api2.x, which ignores theslf4j-log4j121.x binding and switches SLF4J logging to NOP (same issue as in the Flink job, debezium/dbz#1809 Standardize Examples — OpenLineage Flink #496).actions/setup-javawith Temurin 21 and fixes the Maven cache key, which pointed atapache-pulsar/**/pom.xml.groupId,artifactIdandversionunchanged, sojson-smt-1.0.0.Final.jarstill matches the name the Dockerfile copies.Verification (local, compiled with
release 21)json-smt-es:mvn clean installsucceeds;connect-json,connect-apiandkafka-clientsresolve to 4.3.1.jpa-test:mvn clean testagainst the example's MySQL container: 4 tests, 0 failures, 0 errors. No SLF4J "no providers" warning, and Kafka'sJsonConverterConfiglog output is shown again.Note
jpa-teststill pins Jackson to 2.18.11, whileconnect-json4.3.1 brings Jackson 2.21 modules. The tests, including the ones usingJsonConverter, pass with this combination. I left the Jackson pin unchanged to keep this PR focused, but I can switch it to the BOM-managed version if you prefer.