Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/jpa-aggregations-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
- uses: actions/setup-java@v4
with:
distribution: 'temurin'
java-version: '21'
- name: Cache local Maven repository
uses: actions/cache@v4
with:
path: ~/.m2/repository
key: ${{ runner.os }}-maven-${{ hashFiles('apache-pulsar/**/pom.xml') }}
key: ${{ runner.os }}-maven-${{ hashFiles('jpa-aggregations/**/pom.xml', 'pom.xml') }}
restore-keys: |
${{ runner.os }}-maven-
- name: Check changes in [jpa-aggregations | jpa-test] example
Expand Down
36 changes: 21 additions & 15 deletions jpa-aggregations/jpa-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>io.debezium.examples</groupId>
<artifactId>debezium-examples-parent</artifactId>
<version>1.0-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<groupId>io.debezium.examples.aggregation</groupId>
<artifactId>aggregation-test</artifactId>
<version>1.0.0.Final</version>
Expand All @@ -11,12 +18,20 @@
<version.com.h2database>1.3.176</version.com.h2database>
<version.junit>4.13.1</version.junit>
<version.org.hibernate>5.4.24.Final</version.org.hibernate>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We specifically test with JDK 21, and while Hibernate 5 appears to work with it, it isn't supported and requires at least Hibernate 6. Since Hibernate 8 is now in beta, could you raise a follow-up PR to bump this to the latest Hibernate 7.x?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Naros! I will open a follow-up PR to move jpa-test to Hibernate 7.x (jakarta.persistence, org.hibernate.orm). The parent's Quarkus BOM currently manages hibernate-core 7.2.14.Final. Would you prefer I use that managed version, or pin the latest 7.x release explicitly?

<version.org.slf4j>1.7.36</version.org.slf4j>
<version.jackson>2.18.11</version.jackson>
<version.jackson.databind>2.18.11</version.jackson.databind>
<version.kafka>3.4.0</version.kafka>
</properties>

<dependencyManagement>
<dependencies>
<!-- slf4j-log4j12 is an SLF4J 1.x binding. The parent's BOMs manage slf4j-api 2.x,
which ignores 1.x bindings and disables logging, so keep slf4j-api at the binding's version. -->
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>${version.slf4j}</version>
</dependency>
</dependencies>
</dependencyManagement>

<dependencies>
<dependency>
<groupId>org.hibernate</groupId>
Expand All @@ -37,27 +52,22 @@
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-core</artifactId>
<version>${version.jackson}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.core</groupId>
<artifactId>jackson-databind</artifactId>
<version>${version.jackson.databind}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.module</groupId>
<artifactId>jackson-module-jsonSchema</artifactId>
<version>${version.jackson}</version>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.datatype</groupId>
<artifactId>jackson-datatype-jsr310</artifactId>
<version>${version.jackson}</version>
</dependency>
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>connect-json</artifactId>
<version>${version.kafka}</version>
</dependency>
<dependency>
<groupId>junit</groupId>
Expand All @@ -68,7 +78,7 @@
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
<version>${version.org.slf4j}</version>
<version>${version.slf4j}</version>
</dependency>

<!-- Not necessary for ORM 5.2 and above -->
Expand All @@ -89,11 +99,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
</configuration>
<version>${version.maven.compiler}</version>
</plugin>
</plugins>
</build>
Expand Down
18 changes: 8 additions & 10 deletions jpa-aggregations/json-smt-es/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,22 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<parent>
<groupId>io.debezium.examples</groupId>
<artifactId>debezium-examples-parent</artifactId>
<version>1.0-SNAPSHOT</version>
<relativePath>../../pom.xml</relativePath>
</parent>

<groupId>io.debezium.examples.aggregation</groupId>
<artifactId>json-smt</artifactId>
<version>1.0.0.Final</version>
<name>SMT for expanding an incoming JSON field into a typed SourceRecord</name>

<properties>
<version.kafka>3.4.0</version.kafka>
</properties>

<dependencies>
<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>connect-json</artifactId>
<version>${version.kafka}</version>
</dependency>
</dependencies>

Expand All @@ -24,11 +26,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<configuration>
<source>1.8</source>
<target>1.8</target>
</configuration>
<version>${version.maven.compiler}</version>
</plugin>
</plugins>
</build>
Expand Down
Loading