Rework of the JuliaPackage easyblock#4146
Conversation
…n_package` as all packages in the environment will be installed
6ac2dc8 to
c325f44
Compare
|
Moved the final setting of
|
…dir` and using builddependencies
…ve them from the final extension list
…ipped or ignored
86ff2cd to
82f8900
Compare
Co-authored-by: Alexander Grund <Flamefire@users.noreply.github.com>
f4fcc99 to
482c8fb
Compare
…cks: allow arbitrary bundle name
773b011 to
e100f57
Compare
|
Concerning the points of "re-usability" of deps I am unsure what is the best way. The reason being that if 2 packages define the same extension, the compile cache will could work or be broken depending on the load order of the packages from what i've seen (this is why i check for conflicts when rebuilding the manifest). The old attempted route of just using the dependencies just as a source of information for the packages to install (but build a completely new and isolated environment) also has downsides:
EDIT: added a PR for what i have concerning the aforementioned packages Pinging also @lexming since he was the original author of the easyblock to get feedback on these points and the new EB in general |
Why would we need a bundle then? Isn't this effectively saying: Use |
There are some packages that have optional features that are enabled by installing a subpackage. In that case i expected them to always be bundable without problems. Indeed i think the proper approach would be to only have Package, even in Python we sometime encounter trouble when extensions of one package shadow one of another which depending on version might or might not work |
I mentioned something like that in Slack recently as it seems like PythonBundle is/should be preferred but IMO it makes it too easy to add additional packages that might silently conflict with others. The suggestion was to enhance the CI checks to catch that. |
Summary of changes
is_test_dependencyEC paramjulia_debugEC paramJuliaPackagecan't really work with depedencies #4123)Pkg.instantiate()to install all extensions instead of installing them one by one withPkg.developmax_paralleloption)runtestto True for every extension that needs testing)--skip-test-step) and ignorable (--ignore-test-failure)test_onlineis set to trueMaybe TODO
JuliaPackagecan't really work with depedencies #4123) so if the dep order is switched w.r.t. the one at build time slow re-compilation might happenNotes
This PRs includes the changes from:
--sanity-check-onlyfor aJuliaBundle#4122JuliaPackage: Allow running tests in a dedicated test_step #4124Fixes:
JuliaPackagecan't really work with depedencies #4123AI usage