-
Notifications
You must be signed in to change notification settings - Fork 313
Rework of the JuliaPackage easyblock
#4146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Crivella
wants to merge
32
commits into
easybuilders:develop
Choose a base branch
from
Crivella:feature-julia_reusedeps
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+606
−149
Open
Changes from 18 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
95ee3ec
Allow running julia package tests in a dedicated test_step
Crivella 986870a
WIP
Crivella a9dfae3
WIP
Crivella 17f1341
WIP - Use `Pkg.instantiate()` which removes the need to define a `mai…
Crivella 82ae123
Implement test_dependencies
Crivella a980e1e
Add possibility to also have test-only dependencies
Crivella 8fb7dd3
Add tests from 4122
Crivella 53665af
Lint
Crivella 8056a50
Add check to avoid duplicate cache from deps packages
Crivella c325f44
Improve sanity checks
Crivella b7754a3
Fix default EB to `JuliaPackage` to disable autodetection
Crivella 3fadc3b
Handle DEPOT_PATH and LOAD_PATH in Julia's site startup script
Crivella 3665035
lint
Crivella 48d9bf3
Remove manual handling of TOML files
Crivella f9f1d89
Allow cache recompilation by other packages
Crivella 53c8eef
Remove `subpackage_dirs` and `is_test_dependency` in favor of `start_…
Crivella e94a2b9
Check for all conflicts before failing
Crivella a3cc48a
Re-add possibility to have test-only deps with proper checks and remo…
Crivella a401696
Check for compile_cache only for Julia >= 1.8
Crivella df08e0a
Move compilation+build to `build_step` and allow `test_step` to be sk…
Crivella 3c3b3cb
Automatically create and checks for safety wrappers
Crivella 8560b91
lint
Crivella bedbc76
lint
Crivella 82f8900
Clearer attribute name
Crivella cc6602f
Fix docstrings
Crivella db0bdc5
Update easybuild/easyblocks/generic/juliapackage.py
Crivella 8441e74
Improve typehints and docstrings
Crivella 6e5f0c4
Missing author
Crivella 482c8fb
Move check into JuliaPackage
Crivella beaa68f
Allow both online and offline tests
Crivella 764e925
Bundle itself should not be treated as an extension in the sanity che…
Crivella e100f57
lint
Crivella File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.