feat: bylines i18n support by MohamedH1998 · Pull Request #1146 · emdash-cms/emdash

MohamedH1998 · 2026-05-22T14:46:46Z

What does this PR do?

Adds first-class i18n support to bylines, mirroring the row-per-locale model already in place for content (migration 019), and menus + taxonomies (migration 036, PR #916). Each _emdash_bylines row carries locale and translation_group; siblings sharing a translation_group are the same byline identity in different languages. _emdash_content_bylines.byline_id is remapped to store the referenced byline's translation_group, so a single credit survives content translations and resolves against the active locale at runtime.

Highlights

Migration 040_byline_i18n — adds locale + translation_group to _emdash_bylines. Idempotent, backfills via configured defaultLocale, partial unique on (translation_group, locale), widens (slug) to (slug, locale).
Strict per-locale credit hydration — hydrateBylines joins the junction against the sibling matching the entry's locale. No chain-walk for credits. Explicit credit at any locale suppresses author-inferred fallback (gated by hasContentBylines).
Identity lookups chain-walk — getBylineBySlug walks resolveLocaleChain via requestCached. Author pages for un-translated bylines render the default-locale identity. Deliberately different from credit hydration.
BylineRepository — strict per-locale (findMany, findBySlug, findById take locale). New: listTranslations, findByTranslationGroup, copyContentBylines, hasContentBylines / hasContentBylinesMany. setContentBylines dedupes by translation_group. delete is sibling-aware.
REST API — two new endpoints, requireDb on all routes, new bylines:read / bylines:manage permissions (same role thresholds as before):
- GET /_emdash/api/admin/bylines/:id/translations
- POST /_emdash/api/admin/bylines/:id/translations
- GET /_emdash/api/admin/bylines?locale=xx filters strictly
- POST /_emdash/api/admin/bylines accepts locale + translationOf
Admin UI
- TranslationsPanel + LocaleSwitcher on the bylines manager — strict locale filtering, bookmarkable via ?locale=.
- Byline picker on the content editor is locale-pinned to the entry's locale.
- Empty state CTA links to /bylines?locale=… for inline creation in the right locale.
- ContentEditor only sends bylines when the user touched the editor (bylinesTouched, mirrors slugTouched). Prevents silent wipe of copied credits on translation entries.
- loadMoreMutation snapshots filters at click-time, discards stale in-flight results.
Locale validation — handlers validate locale against getI18nConfig()?.locales ("zz" → 400). Schemas reject empty-string locales (z.string().min(1).optional()).
Closes #

Type of change

Checklist

I have read CONTRIBUTING.md
[ ] pnpm typecheck passes
pnpm lint passes
pnpm test passes (or targeted tests for my change)
pnpm format has been run
I have added/updated tests for my changes (if applicable)
User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
I have added a changeset (if this PR changes a published package)
New features link to an approved Discussion: i18n: Translatable site title, tagline, collection names, etc. #403

AI-generated code disclosure

This PR includes AI-generated code — model/tool:

Screenshots / test output

changeset-bot · 2026-05-22T14:46:55Z

🦋 Changeset detected

Latest commit: 662cb36

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
emdash	Minor
@emdash-cms/admin	Minor
@emdash-cms/auth	Minor
@emdash-cms/cloudflare	Minor
@emdash-cms/fixture-perf-site	Patch
@emdash-cms/perf-demo-site	Patch
@emdash-cms/cache-demo-site	Patch
@emdash-cms/auth-atproto	Patch
@emdash-cms/blocks	Minor
@emdash-cms/gutenberg-to-portable-text	Minor
@emdash-cms/x402	Minor
create-emdash	Minor
@emdash-cms/plugin-embeds	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-05-22T14:47:00Z

Scope check

This PR changes 4,431 lines across 30 files. Large PRs are harder to review and more likely to be closed without review.

If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs.

See CONTRIBUTING.md for contribution guidelines.

pkg-pr-new · 2026-05-22T14:49:12Z

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@1146

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@1146

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@1146

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@1146

emdash

npm i https://pkg.pr.new/emdash@1146

create-emdash

npm i https://pkg.pr.new/create-emdash@1146

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@1146

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@1146

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@1146

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@1146

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@1146

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@1146

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@1146

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@1146

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@1146

commit: 662cb36

ascorbic

Thanks!!

ascorbic · 2026-05-22T14:58:57Z

/review

ask-bonk

Nice work — the strict-per-locale credit hydration + chain-walk identity lookup distinction is well-reasoned and the test coverage (migration up/down, D1-like FK semantics, dedupe-after-resolve, copy-on-translation, no-fallback-when-explicit-exists) is thorough. The migration backfill, idempotency, and rollback guards are exactly the kind of belt-and-braces I'd want for a row-per-locale schema change on tables that already hold production data.

A few minor things noted inline — none are blockers:

Extra per-entry query on every author-fallback path (hydrateBylines): the new hasContentBylines round-trip fires whenever the strict-locale getContentBylines returns empty. On monolingual installs (the majority case) this is a strict regression — one extra query per entry that has no bylines configured, for no functional benefit. Worth re-running pnpm query-counts and either short-circuiting for monolingual sites or folding the "any junction exists" signal into the first query.
Inconsistent error response shape in the new translations route (raw JSON.stringify instead of apiError). Also a redundant source-not-found check that duplicates the handler's own check.
BylineRepository.update() (unmodified in this PR but worth noting) doesn't validate slug or locale conflicts. An editor renaming the FR sibling of jane to a colliding (slug, locale) will fall through to the raw DB constraint and surface as a generic 500. The create path mirrors a careful CONFLICT response — would be nice to match in a follow-up.
Possible empty-state flash before the picker query loads (gated only on bylines.length === 0, not on a loading flag).

Nothing structural. Once the query-count diff is reviewed, this looks ready.

ask-bonk · 2026-05-22T15:08:41Z

+					},
+				};
+			}
+			sourceGroup = source.translationGroup ?? source.id;


sourceGroup = source.translationGroup ?? source.id is correct given the migration backfills translation_group = id for every existing row, but it relies on that invariant holding indefinitely. The type translationGroup: string | null in BylineSummary and the comment in types.ts ("Nullable in storage for backwards compatibility") leave the door open.

If a row ever has translation_group = NULL, the findByTranslationGroup(source.id) lookup at the next line would only return the source row itself (real siblings would have a non-null group), and the (translation_group, locale) conflict check would silently miss.

Not something to act on now — but worth considering either (a) making the column NOT NULL in a follow-up migration once all installs are post-040, or (b) treating a null translationGroup as a data-integrity bug rather than a fallback case in code.

Will skip this for now, should be addressed in a separate ticket/discussion

ask-bonk · 2026-05-22T15:08:48Z

Review submitted successfully. The review was created with state "COMMENTED" and includes the summary body plus 4 inline comments anchored on:

packages/core/src/api/handlers/content.ts:140 — extra query round-trip on monolingual sites
packages/core/src/astro/routes/api/admin/bylines/[id]/translations.ts:67-71 — inline JSON.stringify vs apiError, plus redundant source check (with suggestion)
packages/admin/src/components/ContentEditor.tsx:2000 — empty-state flash before picker query loads
packages/core/src/api/handlers/bylines.ts:114 — translationGroup ?? source.id fallback could hide future data-integrity bugs

Review URL: #1146 (review)

github run

Look at the bot reviews

ascorbic · 2026-05-22T16:12:46Z

@MohamedH1998 some valid review feedback there that's worth addressing

github-actions · 2026-05-22T18:47:04Z

Overlapping PRs

This PR modifies files that are also changed by other open PRs:

fix: Prevent draft autosave state loss and editor overwriting #283 (3 shared files)
feat(admin): add Taxonomy Types management page #213 (8 shared files)
Store CSS classes, make editor toolbar extensible #143 (3 shared files)
fix(admin): extend server-side content search to the content picker and MCP #752 (4 shared files)

This may cause merge conflicts or duplicated work. A maintainer will coordinate.

MohamedH1998 · 2026-05-22T19:29:22Z

@MohamedH1998 some valid review feedback there that's worth addressing

@ascorbic i've addressed all the comments

ascorbic

Thanks!

MohamedH1998 added 2 commits May 22, 2026 15:30

feat: bylines i18n support

ca222a0

chore: changeset

2a6504e

github-actions Bot added area/admin area/auth area/core size/XL labels May 22, 2026

github-actions Bot added the cla: signed label May 22, 2026

ascorbic previously approved these changes May 22, 2026

View reviewed changes

ask-bonk Bot reviewed May 22, 2026

View reviewed changes

github-actions Bot added the overlap label May 22, 2026

chore: PR comments

662cb36

ascorbic approved these changes May 23, 2026

View reviewed changes

ascorbic merged commit 11b3001 into emdash-cms:main May 23, 2026
36 checks passed

emdashbot Bot mentioned this pull request May 23, 2026

ci: release #1123

Merged

This was referenced May 24, 2026

i18n(id): translate 7 remaining untranslated strings ahliweb/emdash-awcms#18

Closed

i18n(id): complete Indonesian translation (7 strings) #1162

Merged

MohamedH1998 mentioned this pull request Jun 1, 2026

feat: extensible bylines #1258

Merged

18 tasks

emdashbot Bot mentioned this pull request Jun 3, 2026

ci: release #1283

Merged

Conversation

MohamedH1998 commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

Checklist

AI-generated code disclosure

Screenshots / test output

Uh oh!

changeset-bot Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented May 22, 2026

Scope check

Uh oh!

pkg-pr-new Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ascorbic left a comment

Choose a reason for hiding this comment

Uh oh!

ascorbic commented May 22, 2026

Uh oh!

ask-bonk Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ask-bonk Bot May 22, 2026

Choose a reason for hiding this comment

Uh oh!

MohamedH1998 May 22, 2026

Choose a reason for hiding this comment

Uh oh!

ask-bonk Bot commented May 22, 2026

Uh oh!

ascorbic commented May 22, 2026

Uh oh!

github-actions Bot commented May 22, 2026

Overlapping PRs

Uh oh!

MohamedH1998 commented May 22, 2026

Uh oh!

ascorbic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MohamedH1998 commented May 22, 2026 •

edited

Loading

changeset-bot Bot commented May 22, 2026 •

edited

Loading

pkg-pr-new Bot commented May 22, 2026 •

edited

Loading