Skip to content

[router] Warn on unknown retry_on policy tokens

672337e
Select commit
Loading
Failed to load commit list.
Open

[router] Warn on unknown retry_on policy tokens #45349

[router] Warn on unknown retry_on policy tokens
672337e
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Coverage skipped May 29, 2026 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/45349/main@672337e)

nezdolik @nezdolik 672337e #45349 merge main@c4e3e8e

[router] Warn on unknown retry_on policy tokens

When an xDS retry_on config contains unrecognized tokens (e.g., typos like "5x" instead of "5xx"), Envoy previously accepted the config silently and discarded the unknown tokens without any indication.
This PR adds a rate-limited warning log at config ingestion listing any unrecognized tokens.

Commit Message: [router] Warn on unknown retry_on policy tokens
Additional Description:
Risk Level: Low
Testing: Unit test
Docs Changes:
Release Notes:
Platform Specific Features:
Fixes #39470

Environment

Request variables

Key Value
ref 4444399
sha 672337e
pr 45349
base-sha c4e3e8e
actor nezdolik @nezdolik
message [router] Warn on unknown retry_on policy tokens...
started 1780057493.105185
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default docker.io/envoyproxy/envoy-build:v0.1.5
mobile docker.io/envoyproxy/envoy-build:mobile-v0.1.5
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 39
patch 0
dev true