rpc: resolve block tags in debug_getModifiedAccountsByNumber - #23129
Open
Sahil-4555 wants to merge 4 commits into
Open
rpc: resolve block tags in debug_getModifiedAccountsByNumber#23129Sahil-4555 wants to merge 4 commits into
Sahil-4555 wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Resolves named block tags before querying modified-account history.
Changes:
- Resolve start and end block tags via
rpchelper.GetBlockNumber. - Add tests for supported tags and invalid ranges.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
rpc/jsonrpc/debug_api.go |
Resolves tagged block parameters. |
rpc/jsonrpc/debug_api_test.go |
Adds block-tag coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug causing integer underflow errors when passing named block tags (
latest,safe,finalized,pending) todebug_getModifiedAccountsByNumber.The endpoint parameter signature accepts$2^{64}-1$ (
rpc.BlockNumber, which decodes named tags into negativeint64sentinels (latest=-1,pending=-2,safe=-3,finalized=-4). Those sentinels were cast directly intouint64(startNumber.Int64())by the handler and wrapped around to values near18446744073709551615), failing the range validation check.This PR updates
GetModifiedAccountsByNumberto resolvestartNumberandendNumberusingrpchelper.GetBlockNumberbefore evaluating range semantics. Additionally, resolved block numbers are validated against committed execution stage progress (stages.Execution) to ensure unexecuted blocks return an explicit error instead of querying unindexed state history.Unit test coverage in
TestGetModifiedAccountsByNumberhas been expanded to cover named block tags (latest,earliest,pending,safe,finalized), invalid tag ranges, and pending blocks populated inFilters.Closes #23125