Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions rpc/jsonrpc/debug_api.go
Original file line number Diff line number Diff line change
Expand Up @@ -314,17 +314,11 @@ func (api *DebugAPIImpl) GetModifiedAccountsByNumber(ctx context.Context, startN
}
defer tx.Rollback()

latestBlock, err := stages.GetStageProgress(tx, stages.Execution)
startNum, _, _, err := rpchelper.GetBlockNumber(ctx, rpc.BlockNumberOrHashWithNumber(startNumber), tx, api._blockReader, api.filters)
Comment thread
Sahil-4555 marked this conversation as resolved.
if err != nil {
return nil, err
}

// forces negative numbers to fail (too large) but allows zero
startNum := uint64(startNumber.Int64())
if startNum > latestBlock {
return nil, fmt.Errorf("start block (%d) is later than the latest block (%d)", startNum, latestBlock)
}

if endNumber == nil {
// Single param: cover exactly block startNum.
if err := api.BaseAPI.checkPruneHistory(ctx, tx, startNum); err != nil {
Expand All @@ -342,9 +336,9 @@ func (api *DebugAPIImpl) GetModifiedAccountsByNumber(ctx context.Context, startN
}

// Two params: Geth compares state at startNum vs endNum → blocks (startNum, endNum].
endNum := uint64(endNumber.Int64()) // forces negative numbers to fail (too large)
if endNum > latestBlock {
return nil, fmt.Errorf("end block (%d) is later than the latest block (%d)", endNum, latestBlock)
endNum, _, _, err := rpchelper.GetBlockNumber(ctx, rpc.BlockNumberOrHashWithNumber(*endNumber), tx, api._blockReader, api.filters)
if err != nil {
return nil, err
}
if startNum >= endNum {
return nil, fmt.Errorf("start block (%d) must be less than end block (%d)", startNum, endNum)
Expand Down
32 changes: 32 additions & 0 deletions rpc/jsonrpc/debug_api_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -938,6 +938,38 @@ func TestGetModifiedAccountsByNumber(t *testing.T) {
_, err = api.GetModifiedAccountsByNumber(m.Ctx, rpc.BlockNumber(11), &n2)
require.Error(t, err)
})
t.Run("block tags", func(t *testing.T) {
latest := rpc.LatestBlockNumber
earliest := rpc.EarliestBlockNumber

result, err := api.GetModifiedAccountsByNumber(m.Ctx, latest, nil)
require.NoError(t, err)
require.NotEmpty(t, result)

result, err = api.GetModifiedAccountsByNumber(m.Ctx, earliest, &latest)
require.NoError(t, err)
require.NotEmpty(t, result)

n := rpc.BlockNumber(11)
result, err = api.GetModifiedAccountsByNumber(m.Ctx, n, &latest)
require.NoError(t, err)
require.NotEmpty(t, result)

result, err = api.GetModifiedAccountsByNumber(m.Ctx, rpc.PendingBlockNumber, nil)
require.NoError(t, err)
require.NotEmpty(t, result)
Comment thread
Sahil-4555 marked this conversation as resolved.

_, err = api.GetModifiedAccountsByNumber(m.Ctx, latest, &earliest)
require.Error(t, err)

result, err = api.GetModifiedAccountsByNumber(m.Ctx, rpc.SafeBlockNumber, nil)
require.NoError(t, err)
require.NotEmpty(t, result)

result, err = api.GetModifiedAccountsByNumber(m.Ctx, rpc.FinalizedBlockNumber, nil)
require.NoError(t, err)
require.NotEmpty(t, result)
})
}

func TestMapTxNum2BlockNum(t *testing.T) {
Expand Down
Loading