Repository navigation
fix(dashboard): preserve payload JSON and make event search explicit - #2888
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The event payload viewer removes quotes from JSON keys and has no full-payload copy action. Preserve valid JSON formatting, add payload copying, and make the complete stored idempotency key available through a hover/focus copy control.
Replace the two event-search fields with one selector for metadata, JSON payload, idempotency key, and idempotency value. Payload mode accepts field shorthand and sends strict JSON containment filters; metadata mode explicitly stays text. Preserve legacy saved searches and keep the selected mode identifiable through its icon, placeholder, and help.
Add regression tests and a frozen, independent payload-viewer eval oracle. The oracle reproduces the original failures on the baseline and passes on the implementation; it does not report model benchmark scores.
Keep JSON-looking idempotency identifiers literal during URL serialization, including empty arrays. Repair an unmatched clause in a generated pagination query and add a regression check against its canonical SQL source.
Make the broker own and close its dedicated advisory-lock pool, preserving its existing connection settings. Close an already-created queue when lock-database initialization fails.
Validation: 34 focused Angular tests plus 15 HTTP serialization tests; targeted event-search/API, pagination and broker Go tests; real PostgreSQL broker lock/shutdown regression;
go vet; repository lint with zero issues; generated Swagger/OpenAPI validation; and the three-assertion independent eval oracle.Fixes #2886.