Skip to content

Fix FrozenLake shuffle_data parsing #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kiwigitops wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix FrozenLake shuffle_data parsing #1734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion examples/frozenlake/train_frozenlake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,22 @@
# %%
import argparse


def _str_to_bool(value):
if isinstance(value, bool):
return value

normalized_value = value.lower()
if normalized_value in ("true", "t", "1", "yes", "y"):
return True
if normalized_value in ("false", "f", "0", "no", "n"):
return False

raise argparse.ArgumentTypeError(
"expected one of: true, false, 1, 0, yes, no"
)


arg_parser = argparse.ArgumentParser(
description="Train FrozenLake on Gemma4-2B (single-host TPU)."
)
Expand Down Expand Up @@ -147,7 +163,7 @@
# every multi-turn agent step its env without waiting for a previous wave to
# drain. Drop only if KV cache saturates or generation throughput regresses.
arg_parser.add_argument("--max_concurrency", type=int, default=512)
arg_parser.add_argument("--shuffle_data", type=bool, default=True)
arg_parser.add_argument("--shuffle_data", type=_str_to_bool, default=True)
arg_parser.add_argument("--seed", type=int, default=42)
arg_parser.add_argument(
"--loss_agg_mode", type=str, default="sequence-mean-token-mean"
Expand Down
Loading