Conversation
This was referenced Oct 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native-runtime-client timeout test could fail under load after correctly killing its child: its 250 ms deadline begins at spawn, but its reaping assertions depended on marker files written later by the child.
Observe the real spawn result for the exact fixture binary and require one child, settled exit completion,
SIGKILL, andESRCHfor that parent-captured PID. The deadline case now deliberately waits before writing either marker. Pre-aborted requests still require zero spawns, and running cancellation still requires the exact marker and matching child PID. The pass-through spy is restored infinally; production code and timeout budgets are unchanged.Validation: focused runtime-client tests (12 passed); full CLI suite (1,835 passed, 67 skipped, zero failures); CLI/root typecheck; root check; changed-file lint; and staged privacy checks passed with pinned Bun 1.4.2. The CLI tasks ran fresh; unchanged DB tasks used the shared cache. These checks do not qualify native VM behavior.
Release signal: test-only verification correction. This does not fix or qualify the separate native HTTPS release failure.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.