Repository navigation
Conversation
This was referenced Oct 7, 2026
behdad
added this pull request to stack #518
October 8, 2026 06:10
7 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++ consumers using HarfBuzz's
hb::shared_ptrandhb::unique_ptrcurrently have no replacement forhb-cplusplus.hh. Addhr-hb-cplusplus.hh, retaining the upstream ownership helpers, traits, hash specializations, and license notice.Provide vtables for all eight supported core objects and for subset inputs/plans. Forwarding adapters preserve the HarfBuzz vtable function signatures while accommodating HarfRust's const user-data keys and mixed getter signatures. Omit unsupported Unicode callback, drawing, painting, and rendering objects. The generated subset header supplies its paired specialization block, allowing either include order and repeated includes. Subset objects use the existing
harfrust_clibrary built with the optionalsubsetfeature; core-only tests link the default build.Validation: 12 runtime builds pass with GCC and Clang, C++11 and C++17, using the core header alone and both subset include orders. Checks exercise real core/subset objects, shared copies, moves, unique release/swap, hashes, and exactly-once user-data destruction; subset plans execute successfully. C99 inclusion also passes. CI runs the six C++ standard/include-order variants on Linux and macOS.
Stacked on #513 because the subset vtables require its reference and user-data APIs. No further Skera functionality is needed for this header.