[REV] l10n_uy_ux: revert "strip internal reference prefix from NomItem" - #442
Open
jue-adhoc wants to merge 1 commit into
Open
[REV] l10n_uy_ux: revert "strip internal reference prefix from NomItem"#442jue-adhoc wants to merge 1 commit into
jue-adhoc wants to merge 1 commit into
Conversation
This reverts commit 2ddb650 (ingadhoc#440). The change only makes sense together with the <CodItem> logic: alone, it removes the internal reference from NomItem without reporting it anywhere, and it breaks the native l10n_uy_edi tests (their expected CFEs still carry the "[ref]" prefix) once odoo/enterprise#128600 is removed from the image. The strip is re-introduced, together with the CodItem logic and the adapted expected CFEs, in ingadhoc#441. Change note: Se revierte temporalmente el cambio que quitaba la referencia interna del nombre del ítem en el CFE uruguayo; vuelve en ingadhoc#441 junto con la emisión del código en su propio bloque <CodItem>. Task: https://www.adhoc.inc/odoo/project.task/72672
Contributor
|
|
Contributor
|
@roboadhoc r+ nobump |
Contributor
|
@jue-adhoc @hav-adhoc 'ci/runbot-oba' failed on this reviewed PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert de #440 (
2ddb650).Solo tiene sentido junto con la lógica de
<CodItem>: solo, quita la referencia interna deNomItemsin informarla en ningún lado, y rompe los tests nativos del10n_uy_edi(sus fixtures siguen trayendo el prefijo[ref]) en cuanto se saca odoo/enterprise#128600 de la imagen — que es el paso que queremos dar hoy.El strip vuelve en #441, junto con la emisión de
<CodItem>y los fixtures adaptados, como un único PR autocontenido. Secuencia: merge de este revert → quitar #128600 del aggregate (build nativo, verde) → rebase de #441 sobre 19.0 → merge de #441.Task: https://www.adhoc.inc/odoo/project.task/72672