Skip to content

[REV] l10n_uy_ux: revert "strip internal reference prefix from NomItem" #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jue-adhoc wants to merge 1 commit into
base: 19.0
Choose a base branch
from
Open

[REV] l10n_uy_ux: revert "strip internal reference prefix from NomItem" #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions l10n_uy_ux/models/account_move.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,13 +345,6 @@ def _l10n_uy_edi_get_line_nom_and_desc(self, aml):
# Limpiamos saltos de línea que pueden romper el PDF
clean_name = aml.name.replace("\n", " ").replace("\r", " ") if aml.name else ""

# La referencia interna no va embebida en NomItem: se informa en su propio nodo
# <CodItem> (TpoCod INT1). Si la descripción de la línea arranca con el prefijo
# estándar "[referencia]" del producto, lo quitamos.
default_code = aml.product_id.default_code
if default_code and clean_name.startswith("[%s]" % default_code):
clean_name = clean_name[len(default_code) + 2 :].lstrip()

max_len = 80
if len(clean_name) <= max_len:
nom_item = clean_name
Expand Down
20 changes: 0 additions & 20 deletions l10n_uy_ux/tests/test_l10n_uy_ux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,23 +268,3 @@ def test_120_nom_item_does_not_split_last_word(self):
)
# La concatenación de NomItem + DscItem debe reconstruir el nombre limpio original
self.assertEqual(nom_item + description, line_name.replace("\n", " "))

def test_130_nom_item_strips_internal_reference(self):
"""La referencia interna no va embebida en NomItem: se informa en su propio nodo <CodItem> (INT1).
Si la descripción de la línea arranca con el prefijo estándar "[referencia]", se quita."""
product = self.env["product.product"].create({"name": "Producto con Ref", "default_code": "REF123"})

invoice = self._create_move(
invoice_line_ids=[
Command.create({"product_id": product.id, "name": "[REF123] Producto con Ref", "price_unit": 100.0}),
# La referencia mencionada en otro lado de la descripción no se toca
Command.create({"product_id": product.id, "name": "Otro texto [REF123]", "price_unit": 100.0}),
],
)

nom_item, description = invoice._l10n_uy_edi_get_line_nom_and_desc(invoice.invoice_line_ids[0])
self.assertEqual(nom_item, "Producto con Ref", "NomItem no debe incluir la referencia interna")
self.assertEqual(description, "")

nom_item, _description = invoice._l10n_uy_edi_get_line_nom_and_desc(invoice.invoice_line_ids[1])
self.assertEqual(nom_item, "Otro texto [REF123]", "Solo se quita el prefijo estándar, no otras menciones")