Skip to content

Feature/inportonchange#284

Open
martinfalk wants to merge 3 commits into
masterfrom
feature/inportonchange
Open

Feature/inportonchange#284
martinfalk wants to merge 3 commits into
masterfrom
feature/inportonchange

Conversation

@martinfalk

Copy link
Copy Markdown
Contributor

No description provided.

@martinfalk martinfalk requested a review from petersteneteg June 30, 2026 09:33
@github-actions

Copy link
Copy Markdown

Cpp-Linter Report ✔️

No problems need attention.

Have any feedback or feature suggestions? Share it here.

github-actions[bot]
github-actions Bot previously approved these changes Jun 30, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.7

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

Comment thread .github/workflows/modules.yml Outdated
if [ -f ./core ]; then
echo "### core file in current dir"
gdb ./inviwo core --ex bt --ex quit
elif [ -f ./core ]; then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/var/crash/core here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@github-actions github-actions Bot dismissed their stale review July 1, 2026 10:32

outdated suggestion

github-actions[bot]
github-actions Bot previously approved these changes Jul 1, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.7

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

@martinfalk martinfalk force-pushed the feature/inportonchange branch from e437d27 to 644fa47 Compare July 1, 2026 12:44
@github-actions github-actions Bot dismissed their stale review July 1, 2026 14:51

outdated suggestion

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp-linter Review

Used clang-tidy v19.1.7

No concerns from clang-tidy.

Great job! 🎉

Have any feedback or feature suggestions? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants