Feature/inportonchange

.github/workflows/modules.yml

@@ -67,7 +67,16 @@ jobs:
             targets: 'all'
             installer: 'inviwo-installer-linux'
             artifact: 'build/inviwo-v*.AppImage'
-            run: QT_QPA_PLATFORM=offscreen ./inviwo --logconsole --quit
+            run: |
+              ulimit -c
+              ulimit -c unlimited
+              QT_QPA_PLATFORM=offscreen ./inviwo --logconsole --quit
+              if [ -f ./core ]; then
+                echo "### core file in current dir"
+                gdb ./inviwo core --ex bt --ex quit
+              elif [ -f /var/crash/core ]; then
+                gdb ./inviwo /var/crash/core --ex bt --ex quit
+              fi
 
           # set triplets
           - system: 'windows'

misc/dataframeclustering/src/processors/dataframeclustering.cpp

@@ -112,11 +112,13 @@ DataFrameClustering::DataFrameClustering()
         method_, [](const auto& p) { return p.getSelectedIdentifier() == "spectral"; });
 
     method_.set("agglo");
-
-    dataFrame_.onChange([&]() { onDataFrameChange(); });
 }
 
 void DataFrameClustering::process() {
+    if (dataFrame_.isChanged()) {
+        onDataFrameChange();
+    }
+
     pybind11::list cols;
     for (auto& p : columns_.getPropertiesByType<BoolProperty>()) {
         if (p->getVisible() && p->get()) {

misc/vtk/include/inviwo/vtk/processors/vtkgenericprocessor.h

@@ -152,11 +152,6 @@ inline void updateFieldSelection(vtkDataObject::FieldAssociations assoc, vtkData
 
 void setupFieldSelection(Inport* inport, auto& wrapper) {
     if (auto* vtkinport = dynamic_cast<vtk::VtkInport*>(inport)) {
-        vtkinport->onChange([port = vtkinport, w = &wrapper]() {
-            if (port->isReady()) {
-                updateFieldSelection(w->fieldAssociation.get(), port->getData(), w->name);
-            }
-        });
         wrapper.fieldAssociation.onChange([port = vtkinport, w = &wrapper]() {
             if (port->isReady()) {
                 updateFieldSelection(w->fieldAssociation.get(), port->getData(), w->name);
@@ -269,8 +264,19 @@ class VTKGenericProcessor : public Processor {
 
     virtual void process() override {
         bool ready = true;
-        util::for_each_in_tuple([&](auto& wrapper) { ready &= wrapper.set(*filter_); },
-                                traits_.properties);
+        util::for_each_in_tuple(
+            [&](auto& wrapper) {
+                if constexpr (std::is_base_of_v<FieldSelection, std::decay_t<decltype(wrapper)>>) {
+                    auto* inport = getInport(wrapper.inport);
+                    if (const auto* vtkinport = dynamic_cast<vtk::VtkInport*>(inport);
+                        vtkinport && vtkinport->isChanged() && vtkinport->isReady()) {
+                        updateFieldSelection(wrapper.fieldAssociation.get(), vtkinport->getData(),
+                                             wrapper.name);
+                    }
+                }
+                ready &= wrapper.set(*filter_);
+            },
+            traits_.properties);
 
         if (!ready) return;