Skip to content

Permissions for new WebSocket components - #2638

Merged
timja merged 1 commit into
jenkins-infra:masterfrom
basil:websocket
Jul 8, 2022
Merged

Permissions for new WebSocket components#2638
timja merged 1 commit into
jenkins-infra:masterfrom
basil:websocket

Conversation

@basil

@basil basil commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Description

Seen in https://ci.jenkins.io/job/Core/job/jenkins/job/PR-6801/1/console:

14:05:27  Invalid archive retrieved from Jenkins, perhaps the plugin is not properly incrementalized?
14:05:27  Error: ZIP error: Error: No permissions for org/jenkins-ci/main/websocket-jetty10/2.359-rc32567.c1c2c6d60a_78/websocket-jetty10-2.359-rc32567.c1c2c6d60a_78-sources.jar from https://ci.jenkins.io/job/Core/job/jenkins/job/PR-6801/1/artifact/**/*c1c2c6d60a*78*/*c1c2c6d60a*78*/*zip*/archive.zip
14:05:27  Success: Status code 400 is in the accepted range: 100:599

This is the result of the new WebSocket components introduced in jenkinsci/jenkins#6780 and jenkinsci/jenkins#6785.

The current PR adds permissions consistent with the existing permissions for Jenkins core components:

  • permissions/component-cli.yml
  • permissions/component-jenkins-bom.yml
  • permissions/component-jenkins-core.yml
  • permissions/component-jenkins-war.yml
  • permissions/pom-jenkins-parent.yml

(With the exception of omitting kohsuke from the permissions list, as he is no longer involved with the Jenkins project.)

I verified that the name field matches the artifact ID. I verified that the path field matches the path from mvn clean install.

CC @jglick @timja

Submitter checklist for adding or changing permissions

Always

  • Add link to plugin/component Git repository in description above

For a newly hosted plugin only

  • Add link to resolved HOSTING issue in description above

For a new permissions file only

When adding new uploaders (this includes newly created permissions files)

Reviewer checklist (not for requesters!)

  • Check this if newly added person also needs to be given merge permission to the GitHub repo (please @ the people/person with their GitHub username in this issue as well). If needed, it can be done using an IRC Bot command
  • Check that the $pluginId Developers team has Admin permissions while granting the access.
  • In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
  • If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.

There are IRC Bot commands for it

@basil
basil requested a review from a team as a code owner July 7, 2022 23:35
@timja
timja merged commit 6668d8d into jenkins-infra:master Jul 8, 2022
@basil
basil deleted the websocket branch July 8, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants