[JENKINS-59684] Support "alert-info" for admin monitor in popup - #4276
Merged
oleg-nenashev merged 2 commits intoOct 12, 2019
Conversation
13 tasks
res0nance
approved these changes
Oct 7, 2019
Member
|
Why does this edit |
Contributor
Author
|
The The |
oleg-nenashev
approved these changes
Oct 11, 2019
oleg-nenashev
left a comment
Member
There was a problem hiding this comment.
💯 , thanks!
I was thinking about delivering upgrade guide heads-up through update centers, and this is a great foundation improvement for it
I plan to merge it tomorrow if no negative feedback
daniel-beck
approved these changes
Oct 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alert-infoandalert-dangeralso in the popup for admin monitor.ptags in the message, discovered with the CSRF monitor message being only "half-styled".Screenshots
Full page mode (ok before and after)
Popup mode
Before
After
For CSRF monitor, the paragraphs are now also correctly styled
Before
After
For security warnings
Before
After
See JENKINS-59684.
Proposed changelog entries
Submitter checklist
* Use the
Internal:prefix if the change has no user-visible impact (API, test frameworks, etc.)Desired reviewers
@recena @daniel-beck