Skip to content

Update at-since up to and including 2.226 - #4587

Merged
MarkEWaite merged 2 commits into
jenkinsci:masterfrom
daniel-beck:at-since-2020-03
Mar 17, 2020
Merged

Update at-since up to and including 2.226#4587
MarkEWaite merged 2 commits into
jenkinsci:masterfrom
daniel-beck:at-since-2020-03

Conversation

@daniel-beck

@daniel-beck daniel-beck commented Mar 16, 2020

Copy link
Copy Markdown
Member

Also update the script to deal with untagged-* tags.

Proposed changelog entries

None, internal

Submitter checklist

  • JIRA issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a JIRA issue should exist and be labeled as lts-candidate

Comment thread update-since-todo.sh
Comment thread update-since-todo.sh
/**
* Add entire map but filter null values out.
* @since TODO
* @since 2.214

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4194 (still a pointless change without merit).

* Returns true if and only if the UI refresh is enabled.
*
* @since TODO
* @since 2.222

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* @param predicate
* Filter the descriptors based on this predicate
* @since TODO
* @since 2.222

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* Descriptors shown in the global configuration form to users with {@link Jenkins#SYSTEM_READ} permission.
*
* @since TODO
* @since 2.222

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* if the user doesn't have the permission.
*
* @since TODO
* @since 2.222

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* Administrators can set the system property {@code jenkins.security.ManagePermission} to enable it.</p>
*
* @since TODO
* @since 2.222

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

*
* @see #getAllItems(Class)
* @since TODO
* @since 2.221

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* @return true iff we're in the time period during which this is supposed to collect data
*
* @since TODO
* @since 2.202

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* One WebSocket connection.
* @see WebSockets
* @since TODO
* @since 2.216

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/**
* Support for serving WebSocket responses.
* @since TODO
* @since 2.216

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarkEWaite MarkEWaite added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 17, 2020
@MarkEWaite

Copy link
Copy Markdown
Contributor

If no objections, I will merge tomorrow.

@MarkEWaite
MarkEWaite merged commit cc3d24c into jenkinsci:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants