These at-since were improperly added - #4706
Merged
Merged
Conversation
This was referenced May 3, 2020
res0nance
approved these changes
May 4, 2020
MarkEWaite
approved these changes
May 4, 2020
res0nance
added
the
ready-for-merge
Contributor
|
Merging once CI passes since this is only documentation amends #4705 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our tooling assumes that nobody would backfill
@since TODOfor old code, since it's already known what the first release was.So #4549 improperly added
@since TODOto methods that have existed for a decade, and nobody noticed in #4587.Origin branch (not on dev machine right now), please delete on merge.