Repository navigation
docs: say that web commits are signed off now that the repository requires it - #1566
Conversation
…uires it The repository requires sign-off on web-based commits since 2026-10-28, after the DCO check merged in #1562, so CONTRIBUTING no longer asks for a trailer typed by hand on an applied suggestion, and the repository settings page records the setting as applied. Signed-off-by: José M. Requena Plens <mail@jmrp.io>
github-actions
Bot
added
the
documentation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Record the setting and update guidance docs/development/repository-settings.md, CONTRIBUTING.md |
The settings documentation records web_commit_signoff_required: true as applied on 2026-10-28. The contribution guidance says GitHub signs off web-interface commits, so no manually typed trailer is needed. |
Priority:
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Other
Possibly related issues
jmrplens/gitlab-mcp-server#1545— The issue adopts the Developer Certificate of Origin and requiresSigned-off-bytrailers. This change documents the web commit sign-off setting and covers part of that objective.
Merge Risk: 
681dd
-
This documentation-only change is ready to merge.
Pre-merge checks: 
-
Check name Status Explanation Title check The title is a short, specific docs change. It names the main change: web-based commits are now signed off because the repository requires it. The title matches the summary and the objectives. Its len… Description check The description states the change clearly: the web commit sign-off setting was turned on after #1562merged, and the two docs that said it was off are updated. It names the files changed and the verif…Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title is a short, specific docs change. It names the main change: web-based commits are now signed off because the repository requires it. The title matches the summary and the objectives. Its length and wording are acceptable, though a few words could be trimmed.
Full details: Description check
-
Explanation
The description states the change clearly: the web commit sign-off setting was turned on after
#1562merged, and the two docs that said it was off are updated. It names the files changed and the verification run (markdownlint and check-doc-links). It does not fill in the template's Related Issue, Type of Change, Changes Made, How to Test, or Checklist sections. The Breaking Changes section is also absent, though it would read N/A. The description is mostly complete for a documentation-only change, but the missing template sections should be added.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
I turned on Require contributors to sign off on web-based commits today, after the DCO check of #1562 merged, so GitHub now signs off a commit made in its web interface, such as an applied review suggestion, with its author's identity.
This updates the two places that still said the setting was off: the sentence in
CONTRIBUTING.mdthat asked for a trailer typed by hand, and the Current state of the web commit sign-off item indocs/development/repository-settings.md, which now reads applied, withweb_commit_signoff_required: true.Documentation only; markdownlint and
node scripts/check-doc-links.mjspass.