Skip to content

docs: say that web commits are signed off now that the repository requires it #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmrplens merged 1 commit into from
Oct 28, 2026
Merged

docs: say that web commits are signed off now that the repository requires it #1566

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ To sign off commits already on your branch where they stand, rebase it on its ow

`make check-dco` judges the commits of your branch against `origin/main` before you push, and the `✍️ DCO sign-off` job of CI judges every pull request the same way, from the base commit its event names to its head; for a stacked pull request that base is the head of the layer below, so each layer's pull request judges that layer's commits. It reads the trailer the way git does, and passes a commit when one of its `Signed-off-by` trailers names its author, the name and the email compared without regard to case. A merge commit that brings no change of its own, such as the one GitHub's Update branch button writes, is not judged; a merge that resolves a conflict or changes anything while merging is judged like any other commit, so conclude it with `git commit -s`. Dependabot's commits are exempt in the pull requests Dependabot opens, because an app cannot certify anything and what it commits is a dependency bump; the same commit in a pull request somebody else opened is judged like any other. The release workflow's version stamp reaches `main` without a pull request, so nothing judges it. The [command's reference](docs/development/cmd-utilities.md#audit_dco) says what else it refuses.

GitHub signs off a commit made in its web interface, such as an applied review suggestion, when the repository requires sign-off for web commits; that setting is not on yet ([Repository Settings](docs/development/repository-settings.md#web-commit-sign-off)), so until it is, such a commit needs the trailer typed into its message. The squash commit that lands on `main` needs nothing more: GitHub copies the sign-offs of the pull request's commits into it, below the description, so the description carries no trailer of its own.
GitHub signs off a commit made in its web interface, such as an applied review suggestion, because the repository requires sign-off for web commits ([Repository Settings](docs/development/repository-settings.md#web-commit-sign-off)), so such a commit needs no trailer typed into its message. The squash commit that lands on `main` needs nothing more: GitHub copies the sign-offs of the pull request's commits into it, below the description, so the description carries no trailer of its own.

## Pull Requests

Expand Down
4 changes: 2 additions & 2 deletions docs/development/repository-settings.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,8 +566,8 @@ documentation of the setting says, so it passes the job like one made with
message by hand. The setting reaches only commits made in the web interface:
a commit made with git still needs `--signoff`.

**Current state.** Not applied. Read on 2026-10-26, the repository answers
`web_commit_signoff_required: false`.
**Current state.** Applied on 2026-10-28, after the DCO check merged in #1562:
the repository answers `web_commit_signoff_required: true`.

**How to check.**

Expand Down
Loading