Repository navigation
Conversation
Collaborator
|
sounds great @Rezenders , with the 2.9 version it seems things are working better, so hopefully we can keep using typedb |
Collaborator
|
Actually @Rezenders now it seems to be failing in the same way, after trying to run it more extensively.. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes: Fixes; Robustness improvements to ros_typedb (resilient to DB being deleted on the fly, DB crash, ros_typedb lifecycle change etc) ; Improvements to how errors are logged, more stuff should be logged now; and a new package
ros_typedb_benchmarkwhich contains code to "stress" test ros_typedb.I will write a proper CHANGELOG tomorrow.
The "stress" test was really useful. For example, it showed that querying typedb in very high rates is not really a problem, and help me find some bugs.
@EGAlberts There are some fixes that are related to the problems you had in case you still wanna try using typedb for eval2:
force_databaseparameter for reusing the DB without removing the schema was incorrect. I added a newreload_schemaparameter. Just set it toFalsewhen you dont want the schema to reload. Check: cc4c15efetchqueries that fetched all attributes of a thing, i.e.,match $a isa entity; fetch $a: attribute;. Check: ccce260If you try to use this branch you will probably need to update the constructor of the typedb interface for tactical retreat