Skip to content

[WIP] Timeout improv - #56

Draft
Rezenders wants to merge 36 commits into
typedb2from
timeout_improv
Draft

Rezenders wants to merge 36 commits into
typedb2from
timeout_improv

Conversation

@Rezenders

@Rezenders Rezenders commented Jun 25, 2026 •

Copy link
Copy Markdown
Member

This PR includes: Fixes; Robustness improvements to ros_typedb (resilient to DB being deleted on the fly, DB crash, ros_typedb lifecycle change etc) ; Improvements to how errors are logged, more stuff should be logged now; and a new package ros_typedb_benchmark which contains code to "stress" test ros_typedb.
I will write a proper CHANGELOG tomorrow.
The "stress" test was really useful. For example, it showed that querying typedb in very high rates is not really a problem, and help me find some bugs.

@EGAlberts There are some fixes that are related to the problems you had in case you still wanna try using typedb for eval2:

  1. Using the force_database parameter for reusing the DB without removing the schema was incorrect. I added a new reload_schema parameter. Just set it to False when you dont want the schema to reload. Check: cc4c15e
  2. There was a bug with fetch queries that fetched all attributes of a thing, i.e., match $a isa entity; fetch $a: attribute;. Check: ccce260

If you try to use this branch you will probably need to update the constructor of the typedb interface for tactical retreat

@EGAlberts

Copy link
Copy Markdown
Collaborator

sounds great @Rezenders , with the 2.9 version it seems things are working better, so hopefully we can keep using typedb

@EGAlberts

Copy link
Copy Markdown
Collaborator

Actually @Rezenders now it seems to be failing in the same way, after trying to run it more extensively..

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants