Skip to content

refactor(FieldTheory/Galois/IsGaloisGroup): generalize mulEquivAlgEquiv to domains#40822

Open
tb65536 wants to merge 10 commits into
leanprover-community:masterfrom
tb65536:tb_2947
Open

refactor(FieldTheory/Galois/IsGaloisGroup): generalize mulEquivAlgEquiv to domains#40822
tb65536 wants to merge 10 commits into
leanprover-community:masterfrom
tb65536:tb_2947

Conversation

@tb65536

@tb65536 tb65536 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

This PR generalizes mulEquivAlgEquiv to domains. This allows us to remove mulEquivCongr' (a field version of mulEquivCongr).


Open in Gitpod

@tb65536 tb65536 added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 19, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

PR summary 3f827664e3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ Bijective.of_comp_left

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 3f82766).

  • +1 new declarations
  • −0 removed declarations
+Function.Bijective.of_comp_left

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 3f827664e3
Reference commit 843d7890de

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@tb65536 tb65536 added t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory labels Jun 19, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) and removed blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) labels Jun 19, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 20, 2026

@xroblot xroblot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The generalization of mulEquivAlgEquiv to domains lets mulEquivCongr be defined directly. Thanks!

@tb65536 tb65536 requested a review from riccardobrasca June 20, 2026 12:58

@riccardobrasca riccardobrasca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Comment thread Mathlib/Logic/Function/Basic.lean Outdated
Comment thread Mathlib/FieldTheory/Galois/IsGaloisGroup.lean Outdated
@mathlib-bors

mathlib-bors Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

✌️ tb65536 can now approve this pull request until 2026-07-04 14:30 UTC (in 2 weeks). To approve and merge, reply with bors r+. More detailed instructions are available here.

⚠️ This delegation only covers changes within Archive/**, Counterexamples/**, docs/**, DownstreamTest/**, Mathlib/**, MathlibTest/**, widget/**, Archive.lean, Counterexamples.lean, docs.lean, Mathlib.lean; an author commit touching anything else will revoke it. Bors also revokes it if a later push changes too many files for it to check the full list — even if it stays within scope.

@mathlib-triage mathlib-triage Bot added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Jun 20, 2026
@tb65536 tb65536 added the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 20, 2026
@github-actions github-actions Bot removed the awaiting-CI This PR does not pass CI yet. This label is automatically removed once it does. label Jun 20, 2026
@tb65536

tb65536 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Jun 20, 2026
…uiv` to domains (#40822)

This PR generalizes `mulEquivAlgEquiv` to domains. This allows us to remove `mulEquivCongr'` (a field version of `mulEquivCongr`).

Co-authored-by: tb65536 <thomas.l.browning@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants