Skip to content

Update trade compliance notifications with more accurate status #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukaszgryglicki merged 3 commits into from
Jul 22, 2026
+12 −14
Merged

Update trade compliance notifications with more accurate status #506

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5aad4df
Update trade compliance notifications with more accurate status
mkdolan Jul 16, 2026
8988b09
Fix compliance review messaging: use consistent title and remove serv…
Copilot Jul 21, 2026
1995767
Update trade-compliance review comment wording
Copilot Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...ules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,9 @@ export class CorporateDashboardComponent implements OnInit, OnDestroy {
// organization.isSanctioned is typed as a string in the model; normalize so both a
// boolean false and a literal "false" are correctly treated as not-flagged.
if (String(this.organization.isSanctioned).toLowerCase() === 'true') {
this.title = 'Sanctions Screening';
this.title = 'Compliance Review Required';
this.message =
'Heads up: this organization is currently marked as flagged by sanctions screening. We\'ll re-verify in the next step, and if it is still flagged you won\'t be able to acknowledge the ECLA. If you believe this is an error, please contact EasyCLA Support via the chat widget.';
'Heads up: this organization currently requires additional trade compliance screening review. We\'ll re-verify in the next step, and if it is still flagged you won\'t be able to acknowledge the CLA. If you believe this is an error, please contact EasyCLA Support via the chat widget.';
this.openWithDismiss(this.warningModal);
this.intercomService.show();
}
Expand Down Expand Up @@ -240,10 +240,10 @@ export class CorporateDashboardComponent implements OnInit, OnDestroy {
// Authoritative live SSS verdict from check-prepare/request-employee-signature:
// the company is currently sanctioned (the persisted flag may have been stale;
// this is the live result). Show the dedicated sanctioned message.
this.title = 'Sanctions Screening';
this.title = 'Compliance Review Required';
this.message =
response.errors.description ||
'We\'re sorry, but this organization is flagged by sanctions screening, so the Employee Contributor License Agreement (ECLA) cannot be completed at this time. If you believe this is an error, please contact EasyCLA Support via the chat widget.';
'We\'re sorry, but this organization requires additional trade compliance review, so the Contributor License Agreement (CLA) cannot be completed at this time. If you believe this is an error, please contact EasyCLA Support via the chat widget.';
Comment thread
lukaszgryglicki marked this conversation as resolved.
this.openWithDismiss(this.warningModal);
this.intercomService.show();
return;
Expand Down Expand Up @@ -305,18 +305,18 @@ export class CorporateDashboardComponent implements OnInit, OnDestroy {
if (
Object.prototype.hasOwnProperty.call(response.errors, 'sanctioned')
) {
this.title = 'Sanctions Screening';
this.title = 'Review Required';
Comment thread
Copilot marked this conversation as resolved.
Outdated
this.message =
response.errors.description ||
'We\'re sorry, but this organization is flagged by sanctions screening, so the Employee Contributor License Agreement (ECLA) cannot be completed at this time. If you believe this is an error, please contact EasyCLA Support via the chat widget.';
'We\'re sorry, but this organization requires additional trade compliance review, so the Contributor License Agreement (CLA) cannot be completed at this time. If you believe this is an error, please contact EasyCLA Support via the chat widget.';
Comment thread
lukaszgryglicki marked this conversation as resolved.
this.openWithDismiss(this.warningModal);
this.intercomService.show();
return;
}
this.alertService.error(
response.errors.project_id ||
response.errors.server ||
'Unable to complete the ECLA request.'
'Unable to complete the CLA request.'
);
return;
}
Expand Down
Loading