Update trade compliance notifications with more accurate status by mkdolan · Pull Request #506 · linuxfoundation/easycla-contributor-console

mkdolan · 2026-07-16T15:56:16Z

Summary

Update trade compliance notification messaging for more accurate status

Test plan

Verify trade compliance notifications display in corporate dashboard correctly

Signed-off-by: Mike Dolan <mikedolan@gmail.com>

Copilot

Pull request overview

Updates corporate dashboard trade-compliance notifications with broader, more accurate CLA terminology.

Changes:

Renames sanctions-screening status messages.
Replaces ECLA-specific wording with CLA terminology.
Updates request failure messaging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

coderabbitai · 2026-07-16T16:01:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ddc0bda5-097e-49ad-81e6-e15da9df66bd

📥 Commits

Reviewing files that changed from the base of the PR and between 8988b09 and 1995767.

📒 Files selected for processing (1)

src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts

🚧 Files skipped from review as they are similar to previous changes (1)

src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts

Walkthrough

The corporate dashboard updates trade-compliance warning messaging for sanctioned organizations and employee signature errors. Non-sanctioned signature request errors now check the server error before using the generic fallback.

Changes

Trade compliance messaging

Layer / File(s)	Summary
Dashboard compliance warnings and request errors `src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts`	Organization setup and employee signature compliance paths use updated “Compliance Review Required” messaging. Signature request errors also check `response.errors.server` after `response.errors.project_id` before the generic fallback.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

linuxfoundation/easycla-contributor-console#505: Both changes update sanctions/compliance error handling in the corporate dashboard CLA flow.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the main change: revised trade-compliance notification messaging for sanctioned cases.
Description check	✅ Passed	The description is clearly related to the PR and summarizes the updated trade-compliance notifications and test plan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/trade-compliance-notifications

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

_{Comment @coderabbitai help to get the list of available commands.}

lukaszgryglicki · 2026-07-21T05:40:28Z

cc @mlehotskylf @ahmedomosanya

lukaszgryglicki · 2026-07-21T07:22:04Z

I'm not a Frontend specialist, I've asked AI to address Copilot's feedback and this is what I've got cc @mlehotskylf @ahmedomosanya (Ahmed can you PTAL ?):

The wording in this PR is correct and reflects the intended distinction: a screening flag requires additional trade-compliance review; it is not itself a sanctions determination.

A few small frontend corrections are needed so the approved wording is always shown consistently:

@copilot please:

In both branches that handle response.errors.sanctioned, remove response.errors.description || and assign the new compliance-review message directly.
Use Compliance Review Required as the title in both branches. Please replace Review Required in the second branch.
Update the nearby comments that say the organization “is sanctioned” so they instead say it requires additional trade-compliance review. Keep the API field name sanctioned unchanged for compatibility.

Please make no other behavioral changes.

Acceptance check: when either endpoint returns errors.sanctioned, including when the response also contains errors.description, the modal must always display:

Title:
Compliance Review Required

Message:
We're sorry, but this organization requires additional trade compliance review, so the Contributor License Agreement (CLA) cannot be completed at this time. If you believe this is an error, please contact EasyCLA Support via the chat widget.

Backend follow-up: 5113. It aligns the API response wording. This frontend PR can merge independently.

…er description fallback - Remove `response.errors.description ||` from both sanctioned branches so the compliance-review message is always shown, even when the server response includes errors.description - Use 'Compliance Review Required' as title in both branches (was 'Review Required' in postEmployeeSignatureRequest path) - Update inline comments to say 'requires additional trade-compliance review' instead of 'is sanctioned'

Copilot · 2026-07-21T07:23:58Z

I'm not a Frontend specialist, I've asked AI to address Copilot's feedback and this is what I've got cc @mlehotskylf @ahmedomosanya (Ahmed can you PTAL ?):

The wording in this PR is correct and ref...

Done in the latest commit. Both sanctioned branches now:

Assign the compliance-review message directly (removed response.errors.description || from both paths)
Use Compliance Review Required as the title
Have updated comments referencing "trade-compliance review" instead of "sanctioned"

No other behavioral changes were made.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

coderabbitai

🧹 Nitpick comments (1)

src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts (1)
201-203: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add regression coverage for the compliance-message paths.

Please verify or add component tests covering the persisted sanctioned warning and both response.errors.sanctioned branches. Assert the exact title/message, ensure a server-provided description is ignored, and verify the non-sanctioned fallback order: project_id, then server, then the generic message.

Also applies to: 241-245, 301-317
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts`
around lines 201 - 203, Add regression tests for the corporate dashboard
component’s compliance-message handling, covering persisted sanctioned warnings
and both response.errors.sanctioned branches. Assert the exact title and
message, confirm server-provided description is ignored, and verify
non-sanctioned fallback precedence from project_id to server to the generic
message.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In
`@src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts`:
- Around line 201-203: Add regression tests for the corporate dashboard
component’s compliance-message handling, covering persisted sanctioned warnings
and both response.errors.sanctioned branches. Assert the exact title and
message, confirm server-provided description is ignored, and verify
non-sanctioned fallback precedence from project_id to server to the generic
message.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1f7f9577-0c99-4cfb-a775-0ef094bdf30a

📥 Commits

Reviewing files that changed from the base of the PR and between 5aad4df and 8988b09.

📒 Files selected for processing (1)

src/app/modules/corporate-contributor/container/corporate-dashboard/corporate-dashboard.component.ts

lukaszgryglicki · 2026-07-21T08:19:30Z

PTAL — the Copilot follow-up now addresses the frontend review points:

both blocked employee-signature paths always display the approved compliance-review message directly;
both paths use Compliance Review Required;
a backend-provided description can no longer override the approved wording;
the existing errors.sanctioned API property remains only as the machine-readable compatibility signal.

No further frontend changes are needed from my side.

Backend wording and the existing 403 classification are being aligned in linuxfoundation/easycla#5113. This frontend PR can merge independently.

Yarn dependency audit is not related to this PR. cc @ahmedomosanya @mlehotskylf @mkdolan

lukaszgryglicki · 2026-07-21T08:58:44Z

@copilot Please make one final comment-only wording correction in corporate-dashboard.component.ts.

In getOrganizationInformation(), replace:

// currently marked sanctioned, show a non-blocking WARNING but still proceed to the

with:

// currently marked for additional trade-compliance review, show a non-blocking WARNING but still proceed to the

Keep the existing identifiers and API keys, including isSanctioned and errors.sanctioned, unchanged for compatibility.

Please make no other code, behavior, title, message, or test changes.

Copilot · 2026-07-21T09:02:39Z

@copilot Please make one final comment-only wording correction in corporate-dashboard.component.ts.

In getOrganizationInformation(), replace:
...

Addressed in commit 1995767. Updated the inline comment in getOrganizationInformation() to say “currently marked for additional trade-compliance review…” while keeping isSanctioned and errors.sanctioned unchanged.

lukaszgryglicki · 2026-07-21T09:03:25Z

Both trade-compliance block paths now:

use Compliance Review Required;
display the approved compliance-review message directly;
prevent a backend-provided description from overriding that message; and
use trade-compliance-review terminology in the accompanying comments.

The existing errors.sanctioned field remains unchanged solely as the API compatibility signal.

Backend wording and the existing 403 handling are aligned in linuxfoundation/easycla#5113. linuxfoundation/easycla#5108 is superseded by that PR.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

lukaszgryglicki · 2026-07-21T09:18:29Z

/lgtm

@ahmedomosanya @mkdolan @mlehotskylf this is ready for merge IMHO.

Update trade compliance notifications with more accurate status

5aad4df

Signed-off-by: Mike Dolan <mikedolan@gmail.com>

Copilot AI review requested due to automatic review settings July 16, 2026 15:56

mkdolan temporarily deployed to dev July 16, 2026 15:56 — with GitHub Actions Inactive

Copilot started reviewing on behalf of mkdolan July 16, 2026 15:56 View session

Copilot AI reviewed Jul 16, 2026

View reviewed changes

mkdolan mentioned this pull request Jul 16, 2026

Updated log messages and user messages to reflect trade compliance linuxfoundation/easycla#5108

Closed

lukaszgryglicki requested review from ahmedomosanya, lukaszgryglicki and mlehotskylf July 21, 2026 05:11

lukaszgryglicki mentioned this pull request Jul 21, 2026

Update sanctioned message linuxfoundation/easycla#5113

Merged

Copilot started work on behalf of lukaszgryglicki July 21, 2026 07:22 View session

Copilot AI review requested due to automatic review settings July 21, 2026 07:23

Copilot started reviewing on behalf of mkdolan July 21, 2026 07:24 View session

Copilot finished work on behalf of lukaszgryglicki July 21, 2026 07:24

Copilot AI reviewed Jul 21, 2026

View reviewed changes

coderabbitai Bot reviewed Jul 21, 2026

View reviewed changes

Copilot AI had a problem deploying to dev July 21, 2026 07:47 Failure

Copilot AI temporarily deployed to dev July 21, 2026 07:47 Inactive

lukaszgryglicki previously approved these changes Jul 21, 2026

View reviewed changes

Copilot started work on behalf of lukaszgryglicki July 21, 2026 08:59 View session

Update trade-compliance review comment wording

1995767

Copilot AI dismissed lukaszgryglicki’s stale review via 1995767 July 21, 2026 09:02

Copilot AI review requested due to automatic review settings July 21, 2026 09:02

Copilot started reviewing on behalf of mkdolan July 21, 2026 09:02 View session

Copilot finished work on behalf of lukaszgryglicki July 21, 2026 09:03

Copilot AI requested a review from lukaszgryglicki July 21, 2026 09:03

Copilot AI reviewed Jul 21, 2026

View reviewed changes

Copilot AI temporarily deployed to dev July 21, 2026 09:13 Inactive

Copilot AI had a problem deploying to dev July 21, 2026 09:13 Failure

Copilot AI temporarily deployed to dev July 21, 2026 09:13 Inactive

lukaszgryglicki approved these changes Jul 21, 2026

View reviewed changes

lukaszgryglicki merged commit 0617bfe into main Jul 22, 2026
13 of 14 checks passed

lukaszgryglicki deleted the feature/trade-compliance-notifications branch July 22, 2026 05:32

Uh oh!

Conversation

mkdolan commented Jul 16, 2026

Summary

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

lukaszgryglicki commented Jul 21, 2026

Uh oh!

lukaszgryglicki commented Jul 21, 2026

Uh oh!

Copilot AI commented Jul 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

lukaszgryglicki commented Jul 21, 2026

Uh oh!

lukaszgryglicki commented Jul 21, 2026

Uh oh!

Copilot AI commented Jul 21, 2026

Uh oh!

lukaszgryglicki commented Jul 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

lukaszgryglicki commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coderabbitai Bot commented Jul 16, 2026 •

edited

Loading

lukaszgryglicki commented Jul 21, 2026 •

edited

Loading