[rtl] Switch to ratified bitmanip extensions#2459
Open
thommythomaso wants to merge 20 commits into
Open
Conversation
thommythomaso
force-pushed
the
tbenz/bitmanip
branch
2 times, most recently
from
July 14, 2026 15:23
d0b04a1 to
359815f
Compare
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
thommythomaso
force-pushed
the
tbenz/bitmanip
branch
from
July 14, 2026 15:56
359815f to
242bc59
Compare
Signed-off-by: Thomas Benz <tbenz@lowrisc.org>
thommythomaso
force-pushed
the
tbenz/bitmanip
branch
from
July 15, 2026 12:38
afac420 to
6062faa
Compare
marnovandermaas
left a comment
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
Initial comments from me. Do you think it is worth squashing the commits that just remove things? I think it may be excessive to have 9 separate commits for removing instructions.
Comment on lines
-468
to
-469
| {7'b000_0100, 3'b100}, // pack | ||
| {7'b000_0100, 3'b111}, // packh |
Collaborator
There was a problem hiding this comment.
The zexth commit also remove pack and packh
| 5'b0_0000: alu_operator_o = ALU_SRL; // Shift Right Logical by Immediate | ||
| 5'b0_1000: alu_operator_o = ALU_SRA; // Shift Right Arithmetically by Immediate | ||
| 5'b0_1001: alu_operator_o = ALU_BEXT; // Extract bit specified by immediate. | ||
| // rori (Zbb, also imported by Zbkb): rotate right by immediate |
Collaborator
There was a problem hiding this comment.
Why does changing this comment complete Zbkb?
Comment on lines
-11
to
+12
| * `RISC-V Bit-Manipulation Extension, version 1.0.0 <https://github.com/riscv/riscv-bitmanip/releases/download/1.0.0/bitmanip-1.0.0-38-g865e7a7.pdf>`_ and `version 0.93 (draft from January 10, 2021) <https://github.com/riscv/riscv-bitmanip/blob/master/bitmanip-0.93.pdf>`_ | ||
| * `RISC-V Bit-Manipulation Extension, version 1.0.0 <https://github.com/riscv/riscv-bitmanip/releases/download/1.0.0/bitmanip-1.0.0-38-g865e7a7.pdf>`_ | ||
| * `RISC-V Scalar Cryptography Extension, version 1.0.1 <https://github.com/riscv/riscv-crypto/releases/download/v1.0.1-scalar/riscv-crypto-spec-scalar-v1.0.1.pdf>`_ (Zbkb, Zbkx sub-extensions only) |
Collaborator
There was a problem hiding this comment.
The commit for this shouldn't be marked as RTL. Probably [doc,dv] would be better.
Contributor
Author
I have them as individual commits to help people review the changes. I would have squashed all into one after the review process. What do you think? |
thommythomaso
marked this pull request as ready for review
July 16, 2026 06:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.