`Development`: Add action buttons in popover for recommendation system by ge94zec · Pull Request #2520 · ls1intum/doc-apply

ge94zec · 2026-05-14T19:43:59Z

Checklist

General

I tested all changes and their related features with all corresponding user types.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Server

Important: I implemented the changes with a very good performance and prevented too many (unnecessary) and too complex database calls.
I strictly followed the principle of data economy for all database calls.
I strictly followed the server coding and design guidelines.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data (e.g. using paging).
I strictly followed the principle of data economy for all client-server REST calls.
I strictly followed the client coding and design guidelines.

Motivation and Context

Description

Steps for Testing

Prerequisites:

Log in to TUMApply as Prof
Nav to Create Position
Verify the action buttons behave correctly and text is saved across page switches

Review Progress

Code Review

Code Review 1

Manual Tests

Test 1

Screenshots

Test Coverage

Client

Class/File	Line Coverage	Lines	Expects	Ratio
job-creation-form.component.ts	76.27%	1388	110	7.9
editor.component.ts	46.25%	403	28	6.9
ai-compliance-popover.component.ts	47.61%	38	?	?
suggestion-system.component.ts	30.00%	17	?	?
compliance-suggestion.util.ts	66.66%	51	?	?

Server

Class/File	Line Coverage	Lines
ComplianceIssue.java	0.00%	27
MapComplianceIssuesRequestDTO.java	100.00%	15
AiService.java	35.29%	401
ComplianceScoreService.java	86.67%	93
AiResource.java	48.15%	99
JobService.java	72.88%	385

Last updated: 2026-08-17 12:20:10 UTC

…rget text - added endpoint POST that maps source issues to a target language - added prompt that returns one mapped text snippet per line in source complianceIssues order, other fields carry over - wired compliance mapping through client → server API - separated compliance analysis from score calculation - extracted save flow in JobService into Consumer - improved performance by eliminating redundant analysis steps in job creation

- updated openapi - added comment to AiService - simplified AiService mapping - updated prompt

- show suggestions in the compliance popover - add suggestion actions for replace, add, remove, and dismiss - extend compliance prompt and model with suggestion field - migration suggestions field on liquibase

- make job authorization check reusable in JobService - check job access before mapping compliance issues - Clear target-language issues in DB when source list is empty - skip target mapping when source analysis was skipped/failed

…or-compliance' into chore/2346-enhance-performance-for-compliance

- added MapComplianceIssuesRequestDTO for explicit request validation - keep TranslateComplianceDTO focused on translation only. - track AI success and failure for the new mapping LLM call - update openapi

…or-compliance' into chore/2346-enhance-performance-for-compliance

…rformance-for-compliance # Conflicts: # src/main/java/de/tum/cit/aet/job/repository/JobRepository.java # src/main/java/de/tum/cit/aet/job/service/JobService.java # src/main/webapp/app/job/job-creation-form/job-creation-form.component.ts

…buttons-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml

Removing supervisingProfessor and image from the @EntityGraph caused those associations to become lazy (the FETCH graph overrides entity-level EAGER). getJobById accesses both via the entity returned from assertCanManageJob, so they must be in the graph to avoid LazyInitializationException. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Refined the compliance suggestion prompt for more accurate/correct output - Added client logic to insert, replace, or remove snippets at the correct index in the editor and persist the change via the form

…buttons-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml

codacy-production · 2026-05-14T19:45:07Z

Not up to standards ⛔

🔴 Issues 19 high · 4 medium · 1 minor

Alerts:
⚠ 24 issues (≤ 0 issues of at least minor severity)

Results:
24 new issues

Category Results

ErrorProne 2 medium
1 high

Security 18 high

CodeStyle 1 minor

Complexity 2 medium

View in Codacy

🟢 Metrics 78 complexity

Metric Results

Complexity 78

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

…recommendation-system

github-actions · 2026-06-03T13:30:21Z

🤖 No OpenAPI or client changes needed.

…recommendation-system

github-actions · 2026-06-10T13:13:19Z

🤖 No OpenAPI or client changes needed.

- reduce the compliance popover z-index from 1001 to 50 - close the popover when the page or a nested container is scrolled - remove the unused popover hover signal and handler - replace the hover output with a dedicated close event

…buttons-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml # src/main/resources/prompts/AnalyzeComplianceText.st # src/main/webapp/app/job/job-creation-form/job-creation-form.component.ts

github-actions · 2026-08-01T19:39:36Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

pnpm run test:ci
open build/test-results/vitest/coverage/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-08-01T19:39:39Z

🤖 No OpenAPI or client changes needed.

# Conflicts: # src/main/java/de/tum/cit/aet/ai/service/AiService.java # src/main/webapp/app/job/job-creation-form/job-creation-form.component.ts

…nslated descriptions - remove the second compliance analysis for the translated description - reuse source-language compliance issues for snippet mapping - update target-language highlights from mapped issues

…or-compliance' into feat/2348-add-action-buttons-in-popover-for-recommendation-system

…lyses - map newly detected issues without retranslating synchronized descriptions - apply accepted suggestions to both language versions - queue actions until target-language mapping completes - insert ADD suggestions after sentence punctuation within list items - prevent duplicate in-flight compliance analyses - preserve mapped highlights and translated suggestions - keep compliance popovers above the sticky footer

github-actions · 2026-08-04T10:05:28Z

📊 Client Test Coverage Too Low

🔍 View coverage locally:

pnpm run test:ci
open build/test-results/vitest/coverage/index.html

🌐 View coverage from GitHub:
Download the "coverage-report-client" artifact from this workflow run.

github-actions · 2026-08-04T10:06:33Z

🤖 No OpenAPI or client changes needed.

codacy-production · 2026-08-04T10:16:02Z

Not up to standards ⛔

🔴 Issues 19 high · 4 medium · 1 minor

Alerts:
⚠ 24 issues (≤ 0 issues of at least minor severity)

Results:
24 new issues

Category Results

ErrorProne 2 medium
1 high

Security 18 high

CodeStyle 1 minor

Complexity 2 medium

View in Codacy

🟢 Metrics 78 complexity

Metric Results

Complexity 78

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer}
_{TIP This summary will be updated as you push new changes.}

github-actions · 2026-08-04T10:18:23Z

🤖 No OpenAPI or client changes needed.

github-actions · 2026-08-11T12:15:50Z

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

…recommendation-system

github-actions · 2026-08-17T12:16:16Z

🤖 No OpenAPI or client changes needed.

ge94zec and others added 26 commits May 5, 2026 09:56

updated openapi

9adc3e9

refactor: code

7946480

- updated openapi - added comment to AiService - simplified AiService mapping - updated prompt

feat: add interactive compliance suggestions

941bd88

- show suggestions in the compliance popover - add suggestion actions for replace, add, remove, and dismiss - extend compliance prompt and model with suggestion field - migration suggestions field on liquibase

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

7433eeb

updates:

5579180

- make job authorization check reusable in JobService - check job access before mapping compliance issues - Clear target-language issues in DB when source list is empty - skip target mapping when source analysis was skipped/failed

Merge remote-tracking branch 'origin/chore/2346-enhance-performance-f…

97f4653

…or-compliance' into chore/2346-enhance-performance-for-compliance

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

bd80f96

updates:

2d02039

- added MapComplianceIssuesRequestDTO for explicit request validation - keep TranslateComplianceDTO focused on translation only. - track AI success and failure for the new mapping LLM call - update openapi

Merge remote-tracking branch 'origin/chore/2346-enhance-performance-f…

23549fd

…or-compliance' into chore/2346-enhance-performance-for-compliance

chore: update OpenAPI spec and generated client

102ac7b

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

b0c19fb

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

8d001be

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

ee463f7

change requests

b7e0862

chore: update OpenAPI spec and generated client

11e553a

updated client

26f3cbd

added AiServiceTest for analyze and map

702dd6c

Merge remote-tracking branch 'origin/main' into feat/2348-add-action-…

b76eb11

…buttons-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

9f21677

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

630a36f

feat(compliance): apply AI suggestions to job description editor

fedcb06

- Refined the compliance suggestion prompt for more accurate/correct output - Added client logic to insert, replace, or remove snippets at the correct index in the editor and persist the change via the form

Merge remote-tracking branch 'origin/main' into feat/2348-add-action-…

f09b600

…buttons-in-popover-for-recommendation-system # Conflicts: # src/main/resources/config/liquibase/master.xml

fix tests

01a92c8

ge94zec linked an issue May 14, 2026 that may be closed by this pull request

Add action buttons in popover for recommendation system #2348

Open

ge94zec changed the title ~~Feat/2348 add action buttons in popover for recommendation system~~ Development: Add action buttons in popover for recommendation system May 14, 2026

ge94zec self-assigned this May 14, 2026

Merge branch 'main' into feat/2348-add-action-buttons-in-popover-for-…

0c89ea9

…recommendation-system

Merge branch 'main' into feat/2348-add-action-buttons-in-popover-for-…

e25c8d8

…recommendation-system

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

ba210c9

github-actions Bot closed this Jun 25, 2026

Fix compliance popover styling and scroll behavior

37077aa

- reduce the compliance popover z-index from 1001 to 50 - close the popover when the page or a nested container is scrolled - remove the unused popover hover signal and handler - replace the hover output with a dedicated close event

ge94zec reopened this Aug 1, 2026

ge94zec added 2 commits August 1, 2026 18:04

fix merge conflict

bfd1434

ge94zec added 4 commits August 1, 2026 21:49

Merge branch 'main' into chore/2346-enhance-performance-for-compliance

a035c0d

# Conflicts: # src/main/java/de/tum/cit/aet/ai/service/AiService.java # src/main/webapp/app/job/job-creation-form/job-creation-form.component.ts

feat: replace second compliance analysis with snippet mapping for tra…

71a0b76

…nslated descriptions - remove the second compliance analysis for the translated description - reuse source-language compliance issues for snippet mapping - update target-language highlights from mapped issues

ffix server test

8820354

Merge remote-tracking branch 'origin/chore/2346-enhance-performance-f…

e683867

…or-compliance' into feat/2348-add-action-buttons-in-popover-for-recommendation-system

github-actions Bot removed the stale label Aug 2, 2026

ge94zec added 2 commits August 2, 2026 21:02

lint fix

39d10d0

github-actions Bot added the job Code changes in job module. label Aug 4, 2026

prettier

3c44084

github-actions Bot added the stale label Aug 11, 2026

az108 mentioned this pull request Aug 11, 2026

Bugfix: Fix excessive api requests triggering genderdecoder #2465

Open

11 tasks

Merge branch 'main' into feat/2348-add-action-buttons-in-popover-for-…

00bb4ea

…recommendation-system

Navigation Menu

Uh oh!

`Development`: Add action buttons in popover for recommendation system - #2520

`Development`: Add action buttons in popover for recommendation system#2520
ge94zec wants to merge 44 commits into
mainfrom
feat/2348-add-action-buttons-in-popover-for-recommendation-system

ge94zec commented May 14, 2026 •

edited by github-actions Bot

Loading

Uh oh!

codacy-production Bot commented May 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

codacy-production Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 11, 2026

Uh oh!

github-actions Bot commented Aug 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ge94zec commented May 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

General

Server

Client

Motivation and Context

Description

Steps for Testing

Review Progress

Code Review

Manual Tests

Screenshots

Test Coverage

Client

Server

Uh oh!

codacy-production Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Not up to standards ⛔

Uh oh!

github-actions Bot commented Jun 3, 2026

Uh oh!

github-actions Bot commented Jun 10, 2026

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

github-actions Bot commented Aug 1, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

codacy-production Bot commented Aug 4, 2026

Not up to standards ⛔

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 11, 2026

Uh oh!

github-actions Bot commented Aug 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ge94zec commented May 14, 2026 •

edited by github-actions Bot

Loading

codacy-production Bot commented May 14, 2026 •

edited

Loading