Development: Add action buttons in popover for recommendation system

openapi/openapi.yaml

@@ -3019,6 +3019,7 @@ components:
         explanation: {type: string}
         id: {type: string}
         language: {type: string}
+        suggestion: {type: string}
         text: {type: string}
     ConflictDataDTO:
       type: object

src/main/java/de/tum/cit/aet/ai/domain/ComplianceIssue.java

@@ -29,5 +29,6 @@ public class ComplianceIssue {
     @Enumerated(EnumType.STRING)
     private ComplianceAction action;
 
+    private String suggestion;
     private String language;
 }

src/main/java/de/tum/cit/aet/ai/service/ComplianceScoreService.java

@@ -18,7 +18,7 @@ public class ComplianceScoreService {
     /**
      * Calculates a legal compliance score based on a hierarchical risk model.
      * * The calculation follows the Gatekeeper-Principle for severe risks and Exponential Decay
-     * for minor issues. If a CRITICAL_AGG violation is detected, the score is immediately 0
+     * for minor issues. If a CRITICAL or DSGVO violation is detected, the score is immediately 0
      * (Veto-Principle), as these represent non-negotiable legal liabilities.
      * * For transparency issues, the score is reduced multiplicatively using the formula
      * S(n) = 100 * 0.85^n. The decay factor of 0.85 is set to trigger a critical
@@ -39,16 +39,32 @@ protected int calculateLegalScore(List<ComplianceIssue> compliance) {
             .filter(i -> ComplianceCategory.CRITICAL_AGG == i.getCategory())
             .count();
 
+        long dsgvoCount = compliance
+            .stream()
+            .filter(i -> ComplianceCategory.DSGVO_MINIMIZATION == i.getCategory())
+            .count();
+
         if (criticalCount > 0) {
             return 0;
         }
 
+        if (dsgvoCount > 0) {
+            return 0;
+        }
+
         long transparencyCount = compliance
             .stream()
             .filter(i -> ComplianceCategory.TRANSPARENCY == i.getCategory())
             .count();
 
-        double score = 100.0 * Math.pow(PENALTY_FACTOR, transparencyCount);
+        long publicSectorCount = compliance
+            .stream()
+            .filter(i -> ComplianceCategory.PUBLIC_SECTOR == i.getCategory())
+            .count();
+
+        long totalCount = transparencyCount + publicSectorCount;
+
+        double score = 100.0 * Math.pow(PENALTY_FACTOR, totalCount);
         return (int) Math.max(0, Math.round(score));
     }
 

src/main/resources/config/liquibase/changelog/00000000000042_add_suggestion_field_to_complianceIssue.xml

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<databaseChangeLog
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
+  xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-latest.xsd">
+
+  <changeSet id="042_add_suggestion_field_to_complianceIssue" author="melissa">
+    <addColumn tableName="job_compliance_issues">
+      <column name="suggestion" type="text"/>
+    </addColumn>
+  </changeSet>
+
+</databaseChangeLog>

src/main/resources/config/liquibase/master.xml

@@ -51,6 +51,7 @@
   <include file="changelog/00000000000039_add_job_arrangement_and_extension_flags.xml" relativeToChangelogFile="true"/>
   <include file="changelog/00000000000040_add_reference_letters.xml" relativeToChangelogFile="true"/>
   <include file="changelog/00000000000041_add_reference_letter_document.xml" relativeToChangelogFile="true"/>
+  <include file="changelog/00000000000042_add_suggestion_field_to_complianceIssue.xml" relativeToChangelogFile="true"/>
 
   <!-- jhipster-needle-liquibase-add-changelog - JHipster will add liquibase changelogs here -->
   <!-- jhipster-needle-liquibase-add-constraints-changelog - JHipster will add liquibase constraints

src/main/resources/prompts/AnalyzeComplianceText.st

@@ -1,51 +1,66 @@
 You are the TUMApply ComplianceReader, an advanced AI legal and compliance expert for academic job postings at a prestigious university.
-Your core capability is "Contextual Compliance Detection" based on German and EU law.
-You analyze the semantic intent and the exclusionary effect of sentences, not just keywords.
+Your core capability is "Contextual Compliance Detection" based on German and EU law. You ignore typos and spelling errors.
+you ONLY act on legal compliance violations.
 
 TASK:
 Deeply analyze the job posting for legal risks (AGG, DSGVO, WissZeitVG) based on German and EU law.
 The input description language is: {descriptionLanguage}.
-The explanation must be written in: {userLang}.
+EXPLANATIONS must be written in: {userLang}.
+SUGGESTIONS must be written in: {descriptionLanguage}.
 
 STRICT ANALYSIS RULES:
-
 1. NO SUMMARIES: Every single violation must be a separate JSON object.
 2. ALWAYS deeply analyze for CONTEXTUAL and IMPLICIT Discrimination in context of a recruitment system.
-   If a text implies SUBTEXT and EXCLUSIONARY EFFECT, it is a violation
+   If a text implies SUBTEXT and EXCLUSIONARY EFFECT, even if they sound positive it is a violation.
+   If a phrase implies that a certain protected group (age, origin, disability or gender) would not "fit" the subtext of the description, it is a CRITICAL_AGG violation.
+3. MINIMAL SNIPPETS (NO OVERLAPS): Extract the ABSOLUTE MINIMUM amount of words needed to identify the violation. Never extract whole sentences if a phrase suffices. Two issues MUST NEVER have overlapping text snippets.
+4. SEAMLESS GRAMMAR: Suggestions must perfectly match the capitalization, punctuation, and grammatical case of the original text. Inserting the suggestion must not break the surrounding sentence.
 ----------------------
-3. CATEGORY CRITICAL_AGG:
+CATEGORIES & ACTIONS:
+1. CRITICAL_AGG (action: REPLACE):
   - Detect discrimination by protected characteristics under section 1 AGG.
   - Detect exclusion based on disability, age, origin, or gender.
   - JOB TITLE CHECK: If title "{title}" is not gender-neutral with "(m/f/d)" or "(m/w/d)", flag it.
-  - action: REPLACE
-----------------------
-4. CATEGORY DSGVO_MINIMIZATION:
+2. DSGVO_MINIMIZATION (action: REMOVE):
   - Scan for violations of Data Minimization (Art. 5 DSGVO).
-  - Detect for keyword that specifically ask for personal DATA (e.g., photos, ID copies, criminal records, marital status, religion)
+  - Detect for keyword that specifically ask for DATA (e.g., photos, ID copies, criminal records, marital status, religion)
   - EXTERNAL LINK CHECK: Detect for external application forms or websites and flag them
-  - action: REMOVE
-----------------------
-5. CATEGORY TRANSPARENCY:
+3. TRANSPARENCY (action: ADD):
   - Detect mentions of THIRD PARTIES/TOOLS (Workday, Headhunter, Partner Uni, consortia) without stating that data is shared with them.
+  - If entire jobDescription does NOT contain a sentence clarifying that applicant data is shared with external recipients, flag detected mention
   - NOT triggered by: When explicit DATA is requested from the applicant.
-  - action: Suggest to ADD a message that clarifies whether applicant data is shared with external recipients (Art. 13 DSGVO)
-----------------------
-6. CATEGORY PUBLIC_SECTOR: (WissZeitVG)
-  - PhD Specific QUALIFICATION PURPOSE: For PhD/Academic positions, the text MUST semantically imply that the position serves scientific qualification (Wissenschaftliche Qualifizierung/Promotion).
-  - If the intent of individual research/promotion is missing, it is a violation.
-  - action: ADD
-----------------------
+  - TRANSPARENCY SUGGESTION: suggestion must be a consent-based sentence like: By applying, you consent to your data being shared with "third party" for the purpose of the application process (Art. 13 DSGVO)
+4. PUBLIC_SECTOR (action: ADD):
+  - PhD Specific QUALIFICATION PURPOSE (WissZeitVG): For PhD/Academic positions, the text MUST semantically imply that the position serves scientific qualification (Wissenschaftliche Qualifizierung/Promotion).
+  - If the intent of individual research/promotion is missing, you must use an anchor text to attach your suggestion. Use the heading "Description" or "Beschreibung" as anchor.
+-----------
+-----------
 INPUT TEXT:
 {title}
 {jobDescription}
 ----------------------
+
+COMPLETENESS REQUIREMENT:
+Before returning the JSON array, complete all five checks internally:
+1. Explicit discrimination
+2. Implicit AGG patterns
+3. DSGVO minimization violations
+4. Third-party transparency issues
+5. PhD/scientific qualification context
+The final JSON array must reflect the result of all five checks.
+Do not output the checklist, reasoning, summaries, or any field named completeness_requirement.
+
 OUTPUT:
-  - Return ONLY a valid JSON array. No markdown. No prose.
-  - One object per issue
-  - Object fields must be exactly:
-    id, text, category, article, explanation, action
+  Return ONLY a valid JSON array. No markdown. No prose.
+  Object fields must be exactly:
+    id, text, category, article, explanation, action, suggestion
   - category must be exactly CRITICAL_AGG, TRANSPARENCY, DSGVO_MINIMIZATION or PUBLIC_SECTOR
+  - article: the relevant legal article
+  - text: The exact, shortest possible substring from the input triggering the violation (plain text).
+  - explanation: A single, formal SHORT sentence stating the legal violation directly. Do not include subordinate clauses. Write for a very small UI popover.
   - action must be exactly REPLACE or ADD or REMOVE.
-  - text: MAXIMUM 2-4 WORDS. Extract exact snippet from input text that uniquely identifies the violation (plain text, no HTML tags).
-  - explanation must be a single SHORT sentence stating the legal violation directly. Sound like a formal legal notice.
-  - If no issues exist, return exactly [].
+  - suggestion: The exact string to fix the issue
+    - For action is ADD: Return one concise sentence to append the text snippet as an grammatical continuation that starts exactly where the "text" snippet ends.
+    - For action is REPLACE: The exact safe alternative. Preserve the original meaning as far as legally possible. Match original capitalization exactly.
+    - For action is REMOVE: return an empty string ""
+  If no issues exist, return exactly [].

src/main/webapp/app/generated/model/compliance-issue.ts

@@ -16,6 +16,7 @@ export interface ComplianceIssue {
     readonly explanation?: string;
     readonly id?: string;
     readonly language?: string;
+    readonly suggestion?: string;
     readonly text?: string;
 }
 

src/main/webapp/app/job/job-creation-form/job-creation-form.component.html

@@ -189,7 +189,14 @@ <h1 jhiTranslate="{{ pageTitle() }}"></h1>
                   height="20rem"
                   (highlightHovered)="onHighlightHovered($event)"
                 />
-                <jhi-compliance-popover [issue]="activePopoverIssue()" [x]="popoverX()" [y]="popoverY()" />
+                <jhi-compliance-popover
+                  [issue]="activePopoverIssue()"
+                  [x]="popoverX()"
+                  [y]="popoverY()"
+                  (hovered)="onPopoverHovered($event)"
+                  (accept)="onComplianceSuggestionAccepted($event)"
+                  (dismiss)="onComplianceIssueDismissed($event)"
+                />
               </div>
             </div>
           </div>

src/main/webapp/app/job/job-creation-form/job-creation-form.component.ts

@@ -311,6 +311,11 @@ export class JobCreationFormComponent {
   /** When set, only issues of this category are highlighted in the editor. (undefined = all categories shown) */
   readonly activeComplianceFilter = signal<string | undefined>(undefined);
 
+  /** Dismiss hides the marker, but keeps the issue in score/count. */
+  readonly dismissedComplianceHighlights = signal<ComplianceIssue[]>([]);
+
+  readonly isCompliancePopoverHovered = signal(false);
+
   /** Returns the explanation of a compliance issue whose text appears in the job title, if any. */
   readonly titleComplianceError = computed(() => {
     this.basicInfoFormValueSignal();
@@ -863,8 +868,11 @@ export class JobCreationFormComponent {
    * @param lang The current language of the editor content
    */
   private applyHighlights(compliance: ComplianceIssue[] | undefined, lang: string): void {
+    const dismissedIssues = this.dismissedComplianceHighlights();
     const highlights = (compliance ?? []).flatMap(issue =>
-      issue.text && issue.category && (!issue.language || issue.language === lang) ? [{ text: issue.text, category: issue.category }] : [],
+      issue.text && issue.category && (!issue.language || issue.language === lang) && !dismissedIssues.includes(issue)
+        ? [{ text: issue.text, category: issue.category }]
+        : [],
     );
     this.jobDescriptionEditor()?.highlightTexts(highlights);
   }
@@ -875,7 +883,6 @@ export class JobCreationFormComponent {
    */
   onHighlightHovered(event: { text: string; x: number; y: number } | undefined): void {
     if (!event) {
-      this.activePopoverIssue.set(undefined);
       return;
     }
     const lang = this.currentDescriptionLanguage();
@@ -885,6 +892,68 @@ export class JobCreationFormComponent {
     this.popoverY.set(event.y);
   }
 
+  onPopoverHovered(isHovered: boolean): void {
+    this.isCompliancePopoverHovered.set(isHovered);
+    if (!isHovered) {
+      this.closeCompliancePopover();
+    }
+  }
+
+  /**
+   * Applies the action of an accepted AI compliance suggestion to the editor.
+   * Cancels any in-flight translation, syncs the new HTML into the form,
+   * and removes the issue from the pills so it stops showing in the sidebar.
+   */
+  onComplianceSuggestionAccepted(issue: ComplianceIssue): void {
+    const updatedHtml = this.jobDescriptionEditor()?.applyComplianceSuggestion(issue);
+    if (updatedHtml === undefined) return;
+
+    this.cancelTranslation();
+
+    const lang = this.currentDescriptionLanguage();
+    this.basicInfoForm.get('jobDescription')?.setValue(updatedHtml);
+    if (lang === 'en') {
+      this.jobDescriptionEN.set(updatedHtml);
+    } else {
+      this.jobDescriptionDE.set(updatedHtml);
+    }
+
+    this.complianceIssues.update(issues => issues.filter(i => i !== issue));
+    this.closeCompliancePopover();
+    this.refreshComplianceHighlights();
+  }
+
+  /**
+   * Dismisses a compliance issue without applying it.
+   * The highlight disappears from the editor, but the issue still counts
+   * toward the score and the sidebar total.
+   */
+  onComplianceIssueDismissed(issue: ComplianceIssue): void {
+    this.dismissedComplianceHighlights.update(issues => issues.concat(issue));
+    this.closeCompliancePopover();
+    this.refreshComplianceHighlights();
+  }
+
+  /**
+   * Renders compliance highlights in the editor based on the current
+   * language and active category filter. Called after issues change
+   * when action state or filter changes.
+   */
+  private refreshComplianceHighlights(): void {
+    const lang = this.currentDescriptionLanguage();
+    const category = this.activeComplianceFilter();
+    const visibleIssues = category
+      ? this.complianceIssues().filter(currentIssue => currentIssue.category === category)
+      : this.complianceIssues();
+    this.applyHighlights(visibleIssues, lang);
+  }
+
+  /** Hides the active compliance popover and clears its hover state. */
+  private closeCompliancePopover(): void {
+    this.activePopoverIssue.set(undefined);
+    this.isCompliancePopoverHovered.set(false);
+  }
+
   /**
    * Handles category filter changes from the AI assistant sidebar.
    * Updates filter signal to show only the selected category
@@ -1573,6 +1642,10 @@ export class JobCreationFormComponent {
         saved = await firstValueFrom(this.jobApi.createJob(currentData));
         this.jobId.set(saved.jobId ?? '');
       }
+      // Ignore stale auto-save responses if the description changed while the request was in flight.
+      if ((this.basicInfoForm.get('jobDescription')?.value ?? '').trim() !== description.trim()) {
+        return true;
+      }
 
       // 3) Sync local state with server response
       this.lastSavedData.set(saved);

src/main/webapp/app/shared/components/atoms/editor/editor.component.ts

@@ -17,7 +17,12 @@ import { InfoIconComponent } from 'app/shared/components/atoms/info-icon/info-ic
 import { ChangeDetectorRef } from '@angular/core';
 import { viewChild } from '@angular/core';
 import { TranslateDirective } from 'app/shared/language';
-import { ComplianceIssueCategoryEnum, ComplianceIssueCategoryEnumValues } from 'app/generated/model/compliance-issue';
+import {
+  ComplianceIssue,
+  ComplianceIssueActionEnum,
+  ComplianceIssueCategoryEnum,
+  ComplianceIssueCategoryEnumValues,
+} from 'app/generated/model/compliance-issue';
 
 import { BaseInputDirective } from '../base-input/base-input.component';
 
@@ -415,6 +420,47 @@ export class EditorComponent extends BaseInputDirective<string> {
     }
   }
 
+  /**
+   * Applies an AI compliance suggestion to the current editor content based on compliance action.
+   * - `Replace`: swaps the target snippet with the suggestion
+   * - `Remove`: deletes the target snippet
+   * - `Add`: inserts the suggestion after the target snippet
+   *
+   * @param issue The compliance issue containing the action, snippet text, and suggestion.
+   * @returns The updated editor HTML for issued text snippet
+   */
+  public applyComplianceSuggestion(issue: ComplianceIssue): string | undefined {
+    const editor = this.quillEditorComponent()?.quillEditor;
+    if (!editor) return undefined;
+
+    const targetSnippet = issue.text?.trim() ?? '';
+    const replacement = issue.suggestion?.trim() ?? '';
+    const originalText = editor.getText();
+    const targetIndex = targetSnippet ? originalText.toLowerCase().indexOf(targetSnippet.toLowerCase()) : -1;
+
+    switch (issue.action) {
+      case ComplianceIssueActionEnum.Replace: {
+        if (targetIndex === -1) return undefined;
+        editor.deleteText(targetIndex, targetSnippet.length);
+        editor.insertText(targetIndex, replacement);
+        return editor.root.innerHTML;
+      }
+      case ComplianceIssueActionEnum.Remove: {
+        if (targetIndex === -1) return undefined;
+        editor.deleteText(targetIndex, targetSnippet.length);
+        return editor.root.innerHTML;
+      }
+      case ComplianceIssueActionEnum.Add: {
+        const insertAt = targetIndex === -1 ? editor.getLength() : targetIndex + targetSnippet.length;
+        const separator = targetIndex === -1 ? '\n' : ' ';
+        editor.insertText(insertAt, separator + replacement);
+        return editor.root.innerHTML;
+      }
+      default:
+        return undefined;
+    }
+  }
+
   /**
    * Sends the text and position of a highlighted item
    * when the mouse hovers over it, so a popover can be shown.

src/main/webapp/app/shared/components/molecules/ai-compliance-popover/ai-compliance-popover.component.html

@@ -1,10 +1,18 @@
 @if (issue()) {
   <div
-    class="fixed z-50 w-72 rounded-md bg-background-default shadow-lg p-3 text-sm pointer-events-none text-xs"
+    class="fixed z-[1001] w-72"
     [style.left.px]="x()"
     [style.top.px]="y()"
+    (mouseenter)="hovered.emit(true)"
+    (mouseleave)="hovered.emit(false)"
   >
-    <p class="m-0 font-semibold mb-1 text-text-tertiary">{{ issue()?.article }}</p>
-    <p class="m-0 text-text-secondary leading-relaxed">{{ issue()?.explanation }}</p>
+    <jhi-suggestion-system
+      [article]="issue()?.article"
+      [suggestion]="issue()?.suggestion"
+      [explanation]="issue()?.explanation"
+      [actionLabel]="actionButtonLabel()"
+      (accepted)="onAccept()"
+      (dismissed)="onDismiss()"
+    />
   </div>
 }