Skip to content

ci: add Visual C++ and MinGW jobs#315

Closed
kou wants to merge 1 commit into
lunarmodules:masterfrom
kou:github-actions-windows
Closed

ci: add Visual C++ and MinGW jobs#315
kou wants to merge 1 commit into
lunarmodules:masterfrom
kou:github-actions-windows

Conversation

@kou

@kou kou commented Aug 6, 2020

Copy link
Copy Markdown

https://github.com/kou/luasocket/actions/runs/196950032 is a result of this.

MinGW job is failed because #312 isn't included. If we have #312, the job is passed: https://github.com/kou/luasocket/actions/runs/196944672

This uses Lua 5.4 for Visual C++ and Lua 5.1 for MinGW.

This has CMakeLists.txt to build Lua 5.4 with Visual C++. It's written me from scratch because there isn't the official Lua build system for Visual C++. There are some projects that writes CMakeLists.txt such as https://github.com/LuaDist/lua . I searches them when I'm writing this. It seems that the official Lua will not support CMake because there is no consensus to use CMake. I searched lua-users mailing list: http://lua-users.org/cgi-bin/namazu.cgi?query=cmake+visual&idxname=lua-l&max=20&result=normal&sort=date%3Alate

Should we use other CMakeLists.txt implementation rather than the CMakeLIsts.txt in this pull request? I think that the CMakeLists.txt in this pull request is simple enough to maintain.

test/hello.lua is only used for testing. We can add more tests as follow-up tasks.

@kou

kou commented Aug 12, 2020

Copy link
Copy Markdown
Author

@avently Generally, please don't hijack an existing non/less-related issue/pull request.
Could you open a new issue for your subject?

@avently

avently commented Aug 12, 2020

Copy link
Copy Markdown

Sorry, I just wanted you to see the problem because I think you really know what you're doing based on projects you contributed to. Other issues can be unanswered for months...
I created an issue: #316 Please, take a look if you have a time.

@kou

kou commented Aug 25, 2020

Copy link
Copy Markdown
Author

@diegonehab @ewestbrook Could you review this?

@kou

kou commented Sep 28, 2020

Copy link
Copy Markdown
Author

@diegonehab @ewestbrook ping

1 similar comment
@kou

kou commented Feb 21, 2021

Copy link
Copy Markdown
Author

@diegonehab @ewestbrook ping

@alerque

alerque commented Nov 8, 2023

Copy link
Copy Markdown
Member

First of all, sorry this went so long undressed. It was unmaintained for a long time and I took over about a year ago, but we still aren't anywhere near working through the backlog of issues and even PRs. Mostly new issue activity gets things moving...

Second, it looks like there is some but not necessarily 100% overlap between this and the more recent #415. @leso-kn would you be able to comment on whether there is anything here we should rescue?

@alerque alerque mentioned this pull request Nov 8, 2023
@kou

kou commented Nov 9, 2023

Copy link
Copy Markdown
Author

No problem! It seems that this is needless by #415. I close this.

@kou kou closed this Nov 9, 2023
@kou kou deleted the github-actions-windows branch November 9, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants