Skip to content

Make the OpenGL (Classic) renderer work on OpenGL 3.1#2642

Open
FireNX70 wants to merge 2 commits into
melonDS-emu:masterfrom
FireNX70:lower_OGL_requirements
Open

Make the OpenGL (Classic) renderer work on OpenGL 3.1#2642
FireNX70 wants to merge 2 commits into
melonDS-emu:masterfrom
FireNX70:lower_OGL_requirements

Conversation

@FireNX70

Copy link
Copy Markdown
Contributor

All shaders were already using version 140, which corresponds to OGL 3.1. None of them seem to be using any extensions introduced into the core spec in 3.2, as far as I can tell.

My first go at checking whether the CPU side was calling any functions introduced into the core standard in 3.2 turned up none. Testing showed glFramebufferTexture (which neither Mesamatrix nor this mention) was a problem. Using glFramebufferTexture2D with a GL_TEXTURE_2D textarget seems to work just as well, difference being glFramebufferTexture2D does exist in OGL 3.1. Note that glFramebufferTextureLayer DOES exist in 3.1 (in fact, it's existed since 3.0), so those calls were fine as they were.

With this, MelonDS can use OpenGL 3.1 instead of 3.2; so Panfrost will now work.
This only affects the conventional OpenGL renderer; the compute renderer is, of course, a whole 'nother story.

Testing on radeonsi turned up no regressions (the conventional OpenGL renderer does show some artifacting in some games, but it's already there in master, I'll open an issue for that later).

@Arisotura

Copy link
Copy Markdown
Member

sure, why not!

we'll see what the CI says, what the team says, etc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants