Repository navigation
fix(theme): text fields and checkbox and radio boxes get an edge at 3:1 #11658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cixzhang
wants to merge
11
commits into
main
Choose a base branch
from
fix/color-border-control
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+257
−94
Draft
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
aecbafc
docs(architecture): form controls get a border role held at 3:1
cixzhang 2e03183
fix(theme): text fields and checkbox and radio boxes get an edge at 3:1
cixzhang 53c63bf
Merge main into fix/color-border-control (takes #11631 as merged)
cixzhang 18d5d7f
fix(theme): Butter's fields and Y2K's light edge use the control role
cixzhang 0eb946b
Merge main into fix/color-border-control
cixzhang e9af9f1
chore(native, cli): regenerate the Swift theme tokens and the docs-to…
cixzhang c85a6fd
Merge main into fix/color-border-control (Indicator record, palette)
cixzhang 98e7cea
test(theme): the form-control edge meets 3:1 on a card too
cixzhang e836f0e
Merge main into fix/color-border-control (regenerated palette refs)
cixzhang d44c0c7
Merge remote-tracking branch 'origin/main' into fix/color-border-control
cixzhang 62175cd
docs(Indicator): FR5 keeps main's radio-dot sizing; only the unchecke…
cixzhang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| --- | ||
| '@astryxdesign/build': patch | ||
| '@astryxdesign/cli': patch | ||
| '@astryxdesign/core': patch | ||
| '@astryxdesign/richtext': patch | ||
| '@astryxdesign/theme-butter': patch | ||
| '@astryxdesign/theme-chocolate': patch | ||
| '@astryxdesign/theme-gothic': patch | ||
| '@astryxdesign/theme-matcha': patch | ||
| '@astryxdesign/theme-neutral': patch | ||
| '@astryxdesign/theme-stone': patch | ||
| '@astryxdesign/theme-y2k': patch | ||
| --- | ||
|
|
||
| [feat] Text fields and checkbox and radio boxes now have an edge people can find. A new theme role, `--color-border-control`, is the edge of a field shell and of a checkbox or radio box, at 3:1 or more against the surface and the page body (WCAG 2.2 non-text contrast). Before, these edges used `--color-border-emphasized`, which reached only 1.4–2.2:1 in Core's default theme, and the field surface differs from the page by only about 1.1:1, so the edge was the only cue. | ||
|
|
||
| What changes on screen: | ||
|
|
||
| - Core's default control edge is `#878D95` (light) and `#666A70` (dark), instead of `#CCD3DB` and `#494D53`. | ||
| - Every field built on the shared field shell uses it: TextInput, TextArea, NumberInput, DateInput, DateRangeInput, DateTimeInput, TimeInput, FileInput, Selector, MultiSelector, ComplexSelector, Typeahead, Tokenizer, PanelSearchInput, PowerSearch, and InputGroupText inside an InputGroup. A field's hover ring is mixed from the same edge. | ||
| - Unchecked CheckboxInput, CheckboxList, RadioList, and DropdownMenu checkbox and radio boxes use it. Checked and disabled boxes are unchanged. | ||
| - Every first-party theme sets its own value at 3:1 or more against its own surface and page body, and generated themes (`defineTheme({color})`) derive one. | ||
| - Cards, dividers, and every other use of `--color-border-emphasized` keep their lighter edge. | ||
|
|
||
| Custom themes: a theme that doesn't set `--color-border-control` gets Core's default. A custom theme that set only `--color-border-emphasized` for its field edges now gets Core's default control edge; set `--color-border-control` to a value that suits your palette and reaches 3:1 against your surface and page body. | ||
|
|
||
| @cixzhang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.