Repository navigation
spec(AST-128): React Native platform: Menus and presentation - #12558
imdreamrunner wants to merge 20 commits into
Conversation
…em menu, action sheet, presentation, modal and overlay window hosts
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
…h alert and popover gaps, and Android hosts as an open question
…ding; menu models and detent counting as open questions
…ckage, outside this record
… model; Header replaces a removed form
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record: its requirements FR1–FR16 and decisions DEC-1–DEC-4 are new, and no current record states them. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner. After that, these still need fixing:
- FR2 maps a menu row's icon name only to a system symbol and shows no image otherwise, so an icon the theme defines as an image shows on
Iconbut never on a menu row, againstspec:AST-082FR17 ("An icon the app or theme defines replaces the platform default"); resolve row icons the wayIcondoes. - The "Why this exists" table surveys seven ecosystem libraries, which the spec-writing rubric's R2 moves to an artifact linked from the pull request, so the description's R2 result ("no survey") is not accurate.
- The description says the only open React Native platform record is AST-131 and that nothing overlaps, but #12552 (AST-129, which this record cites), #12554 (AST-125) and #12555 (AST-127) were already open and each names this group's hosts, so name them and the boundary with each.
Also worth a look, not blocking: spec:AST-129 is not on main yet, so merge it first or state the order, and FR16's modal-host mechanism reads better as implementation detail, with its guarantee kept in FR11.
Claims and files checked
Review mode: full; reason: no-earlier-review
- Claim, the record details the parent foundation record's FR1 hosts, FR6 to FR9 and FR12: verified (record Intent and Current-state impact; the parent's FR1 names the presentation, menu and action-sheet hosts in the core).
- Claim, the native-first records apply (native-first surfaces FR11, native component guidelines FR2 and FR3): partly; the record applies FR11 and FR2 only.
- Claim, the touch-presentation and component records own each component's own contract: verified (Non-goals; those component records are current on main).
- Claim, the Layout, text and keyboard record owns the window status bar and the keyboard dock: verified as cited; that record is an open draft and not on main.
- Claim, the open-pull-request search found only the Web group's record and no overlap: false; the Layout, Navigation hosts and Icons records were open first and each names this group's hosts.
- Claim, no current record states this group's native contract: verified (no record on main names these pieces).
- Claim, FR1 to FR16 with contract tables, platform support, four decisions and six open questions: verified.
- Claim, FR16 allows public API only with one named exception: verified (FR16).
- Claim, Android menus, sheets and dialogs are drawn and the system-host choice is open: verified (Platform support, OQ6).
- Claim, detents are values, ascending by height, and the selected detent and detent changes use values: verified (FR6).
- Claim, menus use one model: verified (FR2's one menu description; DEC-3).
- Claim, component APIs appear only in the Who-uses-it table: verified (elsewhere only component names, in the gap lines and the platform table).
- Claim, the presentation host specifies five kinds, with alert and popover as FR5 gaps: verified (FR5 table and gap lines).
- Claim, the Who-uses-it table in the description matches the record: verified (identical rows).
- Claim, two rejected alternatives, each one line inside DEC-1 and DEC-2: verified.
- Claim, rubric R1 and R3 to R7 results: verified; R2 (no survey): false, the Why-this-exists table surveys seven ecosystem libraries.
- Claim, the knowledge check, Prettier and the whitespace check pass: verified; the knowledge check prints no finding for this record.
- Claim, leak scan clean: verified, no private residue in the added lines, commits, title, body or branch.
- Claim, scope checklist (records only; observable behaviour; overlapping open work named; named mechanisms public): records only verified; overlapping work false (above); FR16's mechanism has no caller that depends on it (non-blocking).
- File docs/specs/AST-128-react-native-menus-presentation/spec.md: three blocking findings above, four non-blocking notes.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record: its requirements FR1–FR16, decisions DEC-1–DEC-4 and its native-contract and platform-support tables are new, and no current record states them. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner. After that, these still need fixing:
- FR2 maps a menu row's icon name only to a system symbol and shows no image otherwise, so an icon the theme defines as an image shows on
Iconbut never on a menu row, againstspec:AST-082FR17 ("An icon the app or theme defines replaces the platform default"); resolve row icons the wayIcondoes. - The "Why this exists" table surveys seven ecosystem libraries, which the spec-writing rubric's R2 moves to an artifact linked from the pull request, so the description's R2 result ("no survey") is not accurate.
- The description says the only open React Native platform record is AST-131 with no overlap, but #12552 (AST-129, which this record cites), #12554 (AST-125) and #12555 (AST-127) were already open and each names this group's hosts, and the record now also hands the overlay window host to AST-139 (#12579), so name them and the boundary with each.
Also worth a look, not blocking: spec:AST-129 and spec:AST-139 are not on main yet, so merge them first or state the order; FR16's modal-host mechanism reads better as implementation detail, with its guarantee kept in FR11; and the Android column keeps drawn menus and sheets without a gap line naming spec:AST-082 FR11.
Claims and files checked
Review mode: full; reason: spec-record
- Claim, the record covers the system menu, action sheet, presentation host and modal host, and keeps the overlay window host as one Who-uses-it row owned by the Preview host record: verified (Who uses it and Non-goals).
- Claim, the record details the parent foundation record's FR1 hosts, FR6 to FR9 and FR12: verified (Intent and Current-state impact; the parent's FR1 names the presentation, menu and action-sheet hosts in the core).
- Claim, the native-first records apply (native-first surfaces FR11, native component guidelines FR2 and FR3): partly; the record applies FR11 and FR2 only.
- Claim, the touch-presentation and component records own each component's own contract: verified (Non-goals).
- Claim, the Layout, text and keyboard record owns the window status bar and the keyboard dock: verified as cited; that record is an open draft and not on main.
- Claim, the open-pull-request search found only the Web group's record and no overlap: false; the Layout, Navigation hosts and Icons records were open first and each names this group's hosts.
- Claim, no current record states this group's native contract: verified (no record on main names these pieces).
- Claim, FR1 to FR16 with contract tables, platform support, four decisions and six open questions: verified.
- Claim, the four decisions as titled: verified (DEC-1 to DEC-4).
- Claim, FR16 allows public API only with one named exception: verified (FR16).
- Claim, Android menus, sheets and dialogs are drawn and the system-host choice is open: verified (Platform support, OQ6).
- Claim, detents are values, ascending by height, and the selected detent and detent changes use values: verified (FR6).
- Claim, menus use one model: verified (FR2's one menu description; DEC-3).
- Claim, component APIs appear only in the Who-uses-it table: verified (elsewhere only component names, in the gap lines and the platform table).
- Claim, the presentation host specifies five kinds, with alert and popover as FR5 gaps: verified (FR5 table and gap lines).
- Claim, the Who-uses-it table in the description matches the record: verified (identical rows).
- Claim, two rejected alternatives, each one line inside DEC-1 and DEC-2: verified.
- Claim, the record governs only the four native pieces and leaves component rows, router options, the status bar and keyboard dock, and the per-app surface choice elsewhere: verified (Non-goals, OQ4).
- Claim, the implementation lives in the React Native package's platform layer: not checkable here; that package is not in this repository.
- Claim, rubric R1 and R3 to R7 results: verified; R2 (no survey): false, the Why-this-exists table surveys seven ecosystem libraries.
- Claim, the knowledge check, Prettier and the whitespace check pass: verified; the knowledge check prints no finding for this record.
- Claim, leak scan clean: verified, nothing private in the added lines, commits, title, body or branch.
- Claim, scope checklist (records only; observable behaviour; named mechanisms public; overlapping open work named): records only verified; overlapping work false (above); FR16's mechanism names no caller that depends on it (non-blocking).
- File docs/specs/AST-128-react-native-menus-presentation/spec.md: three blocking findings above, six non-blocking notes.
…endment cited by id, behaviour over mechanism
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record: its requirements FR1–FR16, decisions DEC-1–DEC-4 and its native-contract and platform-support tables are new, and no current record states them. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner. The earlier menu-icon and research-table findings are fixed at this head; after the decision, this still needs fixing:
- Miss: the description's list of open records that touch this group still leaves out #12562 (
spec:AST-124), #12580 (spec:AST-138) and #12553 (spec:AST-130), each of which names these hosts, and #12580 lists different users for them than "Who uses it", so name all three with the boundary for each and reconcile the two user lists.
Also worth a look, not blocking: FR11's new no-orphan-window guarantee reads as unconditional while FR16 falls back to React Native's own behaviour when that state changes, FR15 and Current-state impact rest on the open spec:AST-112 amendment and their "(amended)" marks will read as history once it lands, a row's "neither shows no image" differs from Icon if spec:AST-127 draws a glyph for such a name, and the earlier notes on FR5 and FR6 prop levels, fit ordering, the Android gap line and the native-component-guidelines FR3 citation still apply.
Claims and files checked
Review mode: full; reason: spec-record
- Claim, it depends on the foundation amendment and two sibling records and merges after them, not stacked: verified, all three are open and unmerged; nothing but the description enforces the order.
- Claim, the record covers the system menu, action sheet, presentation host and modal host, and keeps the overlay window host as one Who-uses-it row owned by the Preview host record: verified (Who uses it, Non-goals).
- Claim, the record details the parent foundation record's FR1 hosts, FR6 to FR9 and FR12 and links them: verified (Intent, Current-state impact).
- Claim, the native-first records apply (native-first surfaces FR11, native component guidelines FR2 and FR3): partly; the record applies FR11 and FR2 only.
- Claim, the touch-presentation and component records own each component's own contract: verified (Non-goals).
- Claim, the Layout, text and keyboard record owns the window status bar and the keyboard dock: verified as cited; that record is an open draft.
- Claim, the open React Native platform records that touch this group are the five listed: false; the Gestures, Component set and System modules records are open and name these hosts.
- Claim, the boundary stated with each listed record: verified against each record's open diff.
- Claim, no current record states this group's native contract: verified.
- Claim, FR1 to FR16 with contract tables, platform support, four decisions and six open questions: verified.
- Claim, the four decisions as titled: verified (DEC-1 to DEC-4).
- Claim, native code uses public API only, with one named exception for the modal host: verified (FR16).
- Claim, Android menus, sheets and dialogs are drawn and the system-host choice is open: verified (Platform support, OQ6).
- Claim, detents are values, listed ascending by height, and the selected detent and detent changes use values: verified (FR6).
- Claim, menus use one model: verified (FR2, DEC-3).
- Claim, component APIs appear only in the Who-uses-it table: verified.
- Claim, the presentation host specifies five kinds, with the system alert and popover as FR5 gaps: verified.
- Claim, the description's Who-uses-it table matches the record: verified (identical rows).
- Claim, two rejected alternatives, each one line inside DEC-1 and DEC-2: verified.
- Claim, the record governs only the four native pieces and leaves component rows, router options, the status bar and keyboard dock, and the per-app surface choice elsewhere: verified (Non-goals, OQ4).
- Claim, the implementation lives in the React Native package's platform layer: not checkable here; that package is not in this repository.
- Claim, the ecosystem comparison moved to the description and the record keeps one conclusion per piece: verified (Why this exists).
- Claim, rubric results R1 to R7: verified; R1's two restated sentences are gone, and three "(amended)" marks remain (non-blocking).
- Claim, the knowledge check, Prettier and the whitespace check pass: verified; the knowledge check prints no line for this record.
- Claim, leak scan clean: verified, nothing private in the added lines, commits, title, body or branch.
- Claim, scope checklist (records only, observable behaviour, named mechanism public, overlapping open work named): records only verified; overlapping open work false (above); the named mechanism names FR11's guarantee as its dependent.
- File docs/specs/AST-128-react-native-menus-presentation/spec.md: one blocking finding (the description's overlap list), seven non-blocking notes.
… Android FR11 gap, plain foundation citations
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record: its requirements FR1–FR16, decisions DEC-1–DEC-4 and its native-contract and platform-support tables are new, and no current record states them. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner. The earlier findings are fixed at this head, the list of overlapping open records included, and nothing else blocks.
Also worth a look, not blocking:
- Miss:
presentresolves{index, reason, message}with nostatus, while FR15 says every contract follows the foundation record's FR8, which gives a method that takes one request object astatusfield. - The Intent now applies the native component guidelines' FR3, which asks each spec to name the Human Interface Guidelines pages it follows, and the record names none.
- FR2's verification row still fails "an unmapped icon draws an image", while the open icons and drawing record draws a glyph for such a name, so that row and FR2's same-image promise cannot both hold once it lands.
Claims and files checked
Review mode: full; reason: spec-record
- Claim, it depends on the foundation amendment and two sibling records and merges only after them, not stacked: verified; all three are open and unmerged, and only the description holds the order.
- Claim, the merge order is the foundation promotion, then its amendment, then the group records: consistent with the open pull requests; nothing enforces it.
- Claim, the record covers the system menu, action sheet, presentation host and modal host, and keeps the overlay window host as one Who-uses-it row owned by the Preview host record: verified (Who uses it, Non-goals).
- Claim, the record details the foundation record's FR1 hosts, FR6 to FR9 and FR12 and links them: verified (Intent, Current-state impact).
- Claim, the native-first surfaces FR11 and native component guidelines FR2 and FR3 apply: verified; the Intent now cites all three, and FR3's guideline pages are not named (non-blocking above).
- Claim, the touch-presentation and component records own each component's own contract: verified (Non-goals).
- Claim, the layout, text and keyboard record owns the window status bar and the keyboard dock: verified (FR9, FR10); that record is an open draft.
- Claim, the open React Native platform records that touch this group and the boundary with each, eight listed: verified against each open record, including the gestures, system modules and component-set records added at this head.
- Claim, the component-set record lists fewer users, and this record's table now includes MultiSelector, ComplexSelector and Typeahead: verified; the component-set record still lists fewer.
- Claim, the Who-uses-it table is verified from the components' imports: not checkable here; that package is not in this repository.
- Claim, no current record states this group's native contract: verified.
- Claim, FR1 to FR16 with contract tables, platform support, four decisions and six open questions: verified.
- Claim, the four decisions as titled: verified (DEC-1 to DEC-4).
- Claim, native code uses public API only, with one named exception for the modal host: verified (FR16; FR11 now states the fallback case).
- Claim, Android menus, sheets and dialogs are drawn and the system-host choice is open: verified (the native-first gap line, OQ6).
- Claim, detents are values, listed ascending by height, and the selected detent and detent changes use values: verified (FR6).
- Claim, menus use one model: verified (FR2, DEC-3).
- Claim, component APIs appear only in the Who-uses-it table: verified.
- Claim, the presentation host specifies five kinds, with the system alert and popover as FR5 gaps: verified.
- Claim, the description's Who-uses-it table matches the record: verified (identical rows).
- Claim, two rejected alternatives, each one line inside DEC-1 and DEC-2: verified.
- Claim, the record governs only the four native pieces and leaves component rows, router options, the status bar and keyboard dock, and the per-app surface choice elsewhere: verified (Non-goals, OQ4).
- Claim, the implementation lives in the React Native package's platform layer: not checkable here; that package is not in this repository.
- Claim, the ecosystem comparison lives in the description and the record keeps one conclusion per piece: verified (Why this exists).
- Claim, rubric results R1 to R7, with the amendment marks removed and four gap lines in R7 form: verified.
- Claim, the knowledge check, Prettier and the whitespace check pass: verified; the knowledge check prints no line for this record.
- Claim, leak scan clean: verified; nothing private in the added lines, commits, title, body or branch.
- Claim, scope checklist (records only, observable behaviour, named mechanism public, overlapping open work named): verified; the named mechanism names FR11's guarantee as its dependent.
- File docs/specs/AST-128-react-native-menus-presentation/spec.md: no blocking finding, three non-blocking notes.
…39; neutral third-party wording
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record: its requirements FR1–FR16, decisions DEC-1–DEC-4 and its native-contract and platform-support tables are new, and no current record states them. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner. Two description fixes are needed whatever the decision:
- The description says the overlay window host belongs to
spec:AST-139and that the record detailsspec:AST-112FR12, but the record now puts the host inspec:AST-141and no longer cites FR12, and the merge-after list leaves out #12598, which holdsspec:AST-141. - Regression: the stated merge order starts with #12576, which was closed without merging, and describes #12563 as carrying the Astryx Stage version floor, which now lives in
spec:AST-139(#12579).
Also worth a look, not blocking (details in the inline comments):
presentstill resolves{index, reason, message}with nostatus, while the result vocabulary the record now takes fromspec:AST-140FR3 gives a request-object method astatus.- Miss: FR1's
version(), FR3's touch shield and FR4's "older module withshowonly" row rest on foundation text that the amendment removes or thatspec:AST-140FR5 rules out.
Claims and files checked
Review mode: full; reason: spec-record
- Claim, it depends on the foundation amendment for default linking, the revision-1 baseline, named features and the Stage version floor: false in part; the amendment no longer states a Stage version floor, which moved to the Astryx Stage record.
- Claim, it also relies on the layout, Stage, Preview and shared platform code records: verified; all four are open drafts, and the Preview record is named without its pull request.
- Claim, not stacked, merges only after the amendment and three sibling records, in the order promotion, amendment, group records: false; the promotion pull request is closed, and the Preview record is missing from the gate.
- Claim, the record covers the four hosts and keeps the overlay window host as one Who-uses-it row owned by the Preview host: verified in the record; the Exact decision section names the Stage record instead.
- Claim, the record details the foundation record's FR1 hosts, FR6 to FR9 and FR12: false for FR12, which the record no longer cites.
- Claim, native-first surfaces FR11 and the native component guidelines FR2 and FR3 apply: verified; the guideline pages are now named.
- Claim, touch-presentation and component records own each component's own contract: verified (Non-goals).
- Claim, the layout, text and keyboard record owns the window status bar and the keyboard dock: verified (FR9, FR10).
- Claim, the open platform records that touch this group and the boundary with each: verified against each open record at its current head, including the shared rules for registration, missing pieces, results, additive evolution, threading and coexistence.
- Claim, the component-set record lists fewer users than this record's table: verified.
- Claim, the Who-uses-it table is verified from the components' imports: not checkable here; that package is not in this repository.
- Claim, no current record states this group's native contract: verified.
- Claim, FR1 to FR16 with contract tables, platform support, four decisions and six open questions: verified.
- Claim, the four decisions as titled: verified (DEC-1 to DEC-4).
- Claim, native code uses public API only, with one named exception for the modal host: verified (FR16, FR11).
- Claim, Android menus, sheets and dialogs are drawn and the system-host choice is open: verified (the native-first gap line, OQ6).
- Claim, detents are values listed ascending, and the selected detent and detent changes use values: verified (FR6).
- Claim, menus use one model, and component APIs appear only in the Who-uses-it table: verified.
- Claim, the presentation host specifies five kinds, with the system alert and popover as gaps: verified.
- Claim, the description's Who-uses-it table matches the record: verified (identical rows).
- Claim, two rejected alternatives, each one line inside DEC-1 and DEC-2: verified.
- Claim, the record governs only the four native pieces and leaves component rows, router options, the status bar, the keyboard dock and the per-app surface choice elsewhere: verified (Non-goals, OQ4).
- Claim, the implementation lives in the React Native package's platform layer: not checkable here; that package is not in this repository.
- Claim, the ecosystem comparison lives in the description, and the record keeps one conclusion per piece: verified.
- Claim, rubric results R1 to R7, with three gap lines in R7 form: verified.
- Claim, the knowledge check, Prettier and the whitespace check pass: verified.
- Claim, leak scan clean: verified.
- Claim, scope checklist (records only, observable behaviour, the named mechanism is public, overlapping open work named): verified.
- File docs/specs/AST-128-react-native-menus-presentation/spec.md: no blocking finding in the record; four non-blocking notes.
| request order with other surfaces (DEC-2), and Astryx takes no third-party | ||
| native dependency (`spec:AST-112/DEC-9`). An app may use react-native-screens |
There was a problem hiding this comment.
Not blocking: spec:AST-112/DEC-9 says "The packages take no third-party navigation dependency outside one transitional entry", on main and in the open amendment, so it does not back "no third-party native dependency". Suggest citing spec:AST-112/FR2 as the amendment words it, or spec:AST-140/FR9.
| when the host's native piece is registered; on Android, in Jest, and in a | ||
| binary that lacks the piece, it answers false. The view hosts answer | ||
| `version()` with `null`. The probes are `isSystemMenuAvailable()`, |
There was a problem hiding this comment.
Not blocking (Miss): the open spec:AST-112 amendment drops version() from FR7's capability shape, which the Intent cites, and spec:AST-140/FR5 says "A contract carries no revision counter". Suggest dropping the version() sentence.
| component that owns it unmounts, the modal host relies on non-public state | ||
| of React Native's modal host. Where React Native changes that state, the | ||
| modal host logs a fault and keeps React Native's own behaviour. |
There was a problem hiding this comment.
Not blocking: the Intent follows spec:AST-140/FR9, which says that where a group record names an exception, "the binary reports a self-check for it through the platform info module, and the piece falls back to its public path when the check fails". This exception only logs a fault. Suggest stating the self-check here.
… are render system; drawn menus and sheets are drawn
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record: its requirements FR1–FR16, decisions DEC-1–DEC-4 and its native-contract and platform-support tables are new, and no current record states them. FR1's new render axis also lets a theme's render.default override auto, but the current spec:AST-082 FR10 does not list that theme member, so that part needs FR10 to change first or FR1 to drop it. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner. Three description fixes are needed whatever the decision:
- The list of sibling records this record cites leaves out
spec:AST-123(#12557), which FR1 now cites forsurfaceand which states the samerenderaxis; the list of open records leaves it out too. - The R7 rubric result counts three requirement gap lines, but the record now has four, including the new FR1 gap (lines 128–130).
- Miss: the description still lists #12580 (
spec:AST-138) as an open record that can take the Who-uses-it rows, but #12580 was closed in favour of one record per component.
Also worth a look, not blocking (details inline):
- Regression: FR15 and Current-state impact still say every contract is at revision 1, but
spec:AST-140FR5 and the amendedspec:AST-112FR8 now say a contract has no revision number; FR1'sversion()has the same conflict. - FR1 restates the
renderaxis from the amendedspec:AST-112FR21 and fromspec:AST-123instead of citing it, which leaves three copies to keep in step. - The earlier inline notes still apply:
present's missingstatus, FR2's unmapped icon, FR4's older-module row, the DEC-9 citation and FR16's self-check. FR3's touch shield can now citespec:AST-141FR10.
Claims and files checked
Review mode: full; reason: spec-record
- Depends on the foundation amendment for the package shape and default linking: verified; the amendment states both.
- Lists the sibling records this record cites (layout, Stage, Preview, shared platform code): false; the record now also cites the surfaces-and-glass record, which the list leaves out.
- Not stacked; merges after the amendment and the shared-platform record: verified; no stack line, and both are open.
- The exact decision covers the four hosts, and the overlay window host keeps one usage row owned by the Preview host: verified (usage table, Non-goals).
- The record states the JavaScript surface, native contract, lifecycle, stacking, appearance, keyboard, accessibility, fallbacks and Android behaviour: verified.
- The foundation record is the parent, and this record details its hosts and FR6 to FR9 and links rather than restates them: verified for the citations; FR1's render bullets restate the amended FR21 (non-blocking).
- Native-first surfaces FR11 and native component guidelines FR2 and FR3 apply: verified.
- Touch-presentation and component records own each component's own contract: verified (Non-goals).
- The layout record owns the window status bar view and the keyboard dock: verified (FR9, FR10).
- The open platform records that touch this group, with their boundaries: verified for navigation hosts, icons, Stage, Preview, the amendment, shared platform code, gestures and system modules at their current heads; false for the component-set record, which is closed, and incomplete without the surfaces-and-glass record.
- The component-set record lists fewer users and can take these rows: false; that pull request is closed in favour of one record per component.
- The usage table is verified from the components' imports: not checkable here; that package is not in this repository.
- No current record states this group's native contract: verified.
- FR1 to FR16 with the contract tables, platform support, four decisions and five open questions: verified.
- The four decisions as titled: verified (DEC-1 to DEC-4).
- Native code uses public API only, with one named modal-host exception: verified (FR16, FR11).
- Android draws menus, sheets and dialogs, and the system-host choice is open: verified (gap line, OQ5).
- FR1 names the shared render axis, its values and the theme override, with a gap line for the two spellings in code: verified; the theme override is not a member the current native-first surfaces FR10 allows.
- Detents are values listed ascending, and the selected detent and detent changes use values: verified (FR6).
- Menus use one model, and component APIs appear only in the usage table: verified, with FR1's shared render axis as the stated exception.
- The presentation host specifies five kinds, with the system alert and popover as gap lines: verified.
- The description's usage table matches the record: verified (identical rows).
- Two rejected alternatives, one line each inside DEC-1 and DEC-2: verified.
- Claim scope and non-goals: verified.
- The implementation lives in the package's platform layer: not checkable here; that package is not in this repository.
- The ecosystem comparison lives in the description, and the record keeps one conclusion per piece: verified.
- Rubric results R1 to R6: verified; R7 is false: the record has four gap lines, not three.
- Scope checklist (records only, observable behaviour, the named mechanism is public): verified; the overlapping open work is incomplete as above.
- The knowledge check, Prettier and the whitespace check pass: verified.
- Leak scan clean: verified.
- File docs/specs/AST-128-react-native-menus-presentation/spec.md: no blocking finding in the record's own text beyond the owner decision; non-blocking notes in the review and inline.
| | FR1 | Unit tests of each host's probes through the `./testing` doubles | absent, older, and current view and module shapes; `nativeHosts` with a host off; `render` set to `system` and `drawn` and left `auto`; a theme `render.default` | A probe answers true without the native piece, a turned-off host still presents, or `system` shows a drawn surface while the host is available | | ||
| | FR2 | Unit tests of the description and its native form | every row type; an unmapped icon; a glyph; a theme's symbol icon and image icon | A row loses a field, an unmapped icon draws an image, or a row and an `Icon` with one name show different images | | ||
| | FR3 | Simulator checks of both triggers; unit tests of the unavailable reasons | touch-down and drag-release; a long press; `present()` before iOS 17.4; an update while open; a preview card | The trigger also opens the drawn menu, or `present()` fails without `onUnavailable` | | ||
| | FR4 | Unit tests through the `./testing` module double; Simulator check over a sheet | a choice; Cancel; a second sheet; no window; absent module; an older module with `show` only | A result rejects, Cancel reads as an error, or a second sheet does not answer `busy` | |
There was a problem hiding this comment.
Not blocking (carried, re-anchored): "an older module with show only" means present arrived after the module's first shape. FR15 says that no contract in this group lists a named feature, and under spec:AST-140 FR5 behaviour that an older binary lacks is a named feature. Suggest naming present as a feature, or dropping this state.
There was a problem hiding this comment.
Resolved in ae0f6fa: FR15 now says later behaviour is a named feature that JavaScript checks; the sentence that no contract lists a named feature is gone.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record: its requirements FR1–FR16, decisions DEC-1–DEC-4 and its native-contract and platform-support tables are new, no current record states them, and it now relies on current spec:AST-082 FR10 gaining a theme render.default, which FR10 does not allow today and only the open spec:AST-112 amendment (#12563) names.
An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, or says which parts must change and whether spec:AST-082 FR10 must be amended first; the author may do so as an engineering owner.
No blocking defect remains; the non-blocking notes (the "revision 1" and version() wording against spec:AST-140 FR5, FR11's internal ./host entry, and the carried citation notes) are in the review threads.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record depends on the
spec:AST-112amendment and cites five sibling records, each an open draft pull request — verified (all six are open). - Claim: not stacked, merging after the amendment and
spec:AST-140— verified (no stack line; the record cites both). - Claim: the record states FR1–FR16, four decisions and five open questions — verified in the record.
- Claim: FR1 maps this group onto
renderas the parent's FR21 defines it — verified in the record; that FR21 exists only in the open amendment. - Claim: detents are values, ascending by height, and events report values — verified (FR6).
- Claim: FR16 allows one named non-public exception — verified (FR16, FR11).
- Claim: the host presents five kinds, with the system alert and popover as gap lines — verified (FR5 and the two gap lines).
- Claim: the Who-uses-it table matches the record — verified (identical rows).
- Claim: existing authority searched (
spec:AST-082FR11,spec:AST-093FR2 and FR3,spec:AST-094, the component records) — verified (all exist and are current). - Claim: the boundaries with the open sibling records (status bar and keyboard dock, surfaces and glass, navigation hosts, icons, gestures and drag, system modules, Stage, Preview, platform code) — verified against each pull request's record.
- Claim: rubric results R1–R7 (no narration marks, the survey moved out, no evidence naming a change, two rejected lines, no pull request references, three gap lines) — verified in the record.
- Claim: the knowledge check passes and the record is Prettier-clean — verified (both rerun at this head).
- File:
docs/specs/AST-128-react-native-menus-presentation/spec.md— held for the owner decision above; non-blocking notes only.
| view controller above its screen, so two of its windows can be open side by | ||
| side. When a window under others closes, the windows over it close too and | ||
| come back at once, without animation. The library reaches it through the | ||
| internal `./host` entry. Where it is not registered, the library uses React |
There was a problem hiding this comment.
Not blocking (Miss): the open spec:AST-112 amendment exports no internal entry and makes ./host the public interface that host packages (such as the Expo wrapper) implement, so once it lands this sentence names the wrong entry. Suggest dropping it, since the library and the modal host sit in one package, or naming the entry the amendment keeps.
State the baseline as named features, resolve an unmapped row icon to Icon's fallback, give the action sheet's present result its status, clear Non-goals, and state each decision's direction and reason.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record, and one record fix is needed beside it.
Decision needed: spec:AST-128 FR1–FR16, DEC-1–DEC-4 and its native-contract and platform-support tables are new requirements that no current record states, and the record relies on current spec:AST-082 FR10 gaining a theme render.default, which that record does not allow today. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request; the author may do so as an engineering owner.
Blocking:
- Non-goals now reads "None." (
spec.md:81-83), which drops the record's boundaries (each component's rows, heights, dismissal rules andautodefault stay in its own record; the router's route options stay with navigation) and the template's "Equivalent internal implementations remain valid" lines, whilearchitecture:knowledge-contractsasks a record to name adjacent behavior as a non-goal and never to drop non-goals in a rewrite; please restore them, in positive wording if you prefer.
Non-blocking notes are inline: three predicates the rewrite weakened in FR3 and FR12, citations of spec:AST-112/FR1 that the amendment's FR1 no longer supports, and the earlier open threads.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record depends on the
spec:AST-112amendment and cites the openspec:AST-129,spec:AST-123,spec:AST-127andspec:AST-140drafts: verified, the record cites exactly those and all four pull requests are open. - Claim: no current record states this group's native contract: verified,
spec:AST-112is draft onmainand no other record covers it. - Claim: the record states FR1–FR16, four decisions and five open questions: verified.
- Claim: FR1 maps the group onto
renderasspec:AST-112/FR21defines it: verified (spec.md:96-100). - Claim: detents are named by value and
sheetHeightsruns ascending: verified (FR6,spec.md:183-193). - Claim: component APIs appear only in the Who-uses-it table: verified,
BottomSheetappears only atspec.md:78-79. - Claim: the record is rewritten in positive terms, Non-goals reads "None." and each decision states its direction and reason: verified as stated; the rewrite drops the Non-goals boundaries (blocking) and weakens three predicates (inline).
- Claim: each contract's baseline is its first release's shape, growing by named features: verified (FR15,
spec.md:286-288). - Claim: an unmapped row icon resolves to the fallback
Icondraws, so a row and anIconalways match: verified in FR2 (spec.md:112-117); it does not hold under the openspec:AST-127themeicon source (inline). - Claim:
presentresolves{status, index, reason, message}: verified (spec.md:308-312). - Claim: the description's Who-uses-it table is the same as the record's: verified, identical rows.
- Claim: component rows, heights, router options and
autodefaults stay in their own records: stated in the description only; the record no longer says so (blocking). - Claim: the record preserves equivalent internal implementations: no longer stated in the record since Non-goals became "None." (blocking).
- Claim: writing rubric results R1–R7: verified, no pull request references, no
Rejected:lines, three gap lines in the required form, OQ1–OQ5 keep their options. - Claim: the knowledge check, Prettier and the whitespace check pass: verified, rerun at this head.
- Claim: the implementation lives in the React Native package's platform layer: not verifiable here, since that package is not in this repository.
- File
docs/specs/AST-128-react-native-menus-presentation/spec.md: one blocking finding (Non-goals) and non-blocking notes.
| - **FR3 — The system menu behaves as the system's menu.** | ||
| - With `trigger: 'tap'`, the trigger acts as a pull-down button: a touch | ||
| down opens the menu, and the finger can slide to a row and lift to choose | ||
| it. That touch belongs to the menu. With |
There was a problem hiding this comment.
Not blocking: the rewrite weakens three predicates. "That touch belongs to the menu" no longer says JavaScript never sees the touch as a press of the trigger; "A menu opens when it has rows" (line 130) no longer says an empty menu stays closed; and FR12 (lines 255-256) drops "take no accessibility props". Suggest "The trigger's press handlers get no event for that touch" and "A menu with no rows stays closed", and keeping FR12's sentence.
| (native-first sheets and menus), and `spec:AST-093/FR3` (the Apple Human | ||
| Interface Guidelines pages Menus, Pull-down buttons, Context menus, Action | ||
| sheets, Sheets, and Modality) to React Native on iOS. | ||
| The menu, action sheet, presentation, and modal hosts belong to the platform's |
There was a problem hiding this comment.
Not blocking (Regression): this line, Current-state impact (lines 339-340) and FR3's touch shield (line 141) cite spec:AST-112/FR1 for the hosts in the core and for the shield. The amendment's FR1 now names neither: it describes the core as "the native half of the library's own components", its FR7 group table gives spec:AST-128 as core-linked, and spec:AST-141/FR10 owns the touch shield. Suggest citing spec:AST-112/FR7 and spec:AST-141/FR10.
| under `spec:AST-082/FR17`: the icon the app or theme defines for the name | ||
| (a system symbol or an image the app ships), else the platform's default | ||
| symbol, else the fallback `Icon` draws for a name it cannot map | ||
| (`spec:AST-127`). A row and an `Icon` with the same name therefore show the |
There was a problem hiding this comment.
Not blocking (carried, re-anchored): the unmapped-name fallback now matches Icon, but the open spec:AST-127 FR4 also says "Under theme, built-in names skip system symbols", while this order takes the platform default symbol first. Under that icon source a row shows the SF Symbol and an Icon the drawn glyph, so "show the same image" fails. Suggest resolving the row "as Icon resolves it (spec:AST-127/FR4)" instead of restating the order.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record, and one record fix is still needed beside it.
Decision needed: spec:AST-128 FR1–FR16, DEC-1–DEC-4 and its native-contract and platform-support tables are new requirements that no current record states, and the record relies on current spec:AST-082 FR10 gaining a theme render.default, which that record does not allow today. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request; the author may do so as an engineering owner.
Blocking:
- Non-goals (
spec.md:81-90) now has the template's two implementation-freedom lines back but still names none of the adjacent behavior the record leaves to others (each component's rows, sheet heights, dismissal rules andautodefault forrender, and the router's route options), whilearchitecture:knowledge-contractssays "Name adjacent behavior as a non-goal or uncontracted gap"; please add that one bullet.
Non-blocking notes are inline: two new ones on show's positional form and supports(kind) against the shared platform rules, and the earlier open threads (FR3/FR12 predicates, spec:AST-112/FR1 citations, DEC-9, version(), ./host, the FR16 self-check, the theme icon source, and the show-only verification state).
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record depends on the
spec:AST-112amendment and cites the openspec:AST-129,spec:AST-123,spec:AST-127andspec:AST-140drafts: verified, the record cites exactly those and all five pull requests are open drafts. - Claim: not stacked, merging after the amendment and
spec:AST-140: verified, no Stack line; the order is stated in the description only. - Claim: the record covers the four pieces' JavaScript surface, native contract, lifecycle, stacking, appearance and status bar, keyboard and safe area, accessibility, fallbacks and Android behaviour: verified (FR1–FR16).
- Claim: the record details
spec:AST-112FR1 and FR6–FR9: verified as cited; the amendment's FR1 no longer names the hosts (inline). - Claim: the record applies
spec:AST-082FR11 andspec:AST-093FR2 and FR3 to React Native on iOS: verified (spec.md:44-47). - Claim:
spec:AST-094and the component records own each component's contract, and this record owns only the native pieces: true of current authority (spec:AST-082FR3), but the record does not say so (blocking). - Claim:
spec:AST-129owns the window status bar view and keyboard dock,spec:AST-123the surface,spec:AST-127icon drawing: verified (FR9, FR10, FR1, FR2). - Claim: no current record states this group's native contract: verified,
spec:AST-112is draft onmainand no other record covers it. - Claim: FR1–FR16, the native contract and platform support tables, four decisions and five open questions: verified.
- Claim: FR16 allows public API only, with the modal host's one exception: verified (
spec.md:296-301). - Claim: Android draws its menus, sheets and dialogs, and moving to system hosts is open (OQ5): verified (
spec.md:334-335,:441-445). - Claim: FR1 maps the group onto
renderasspec:AST-112/FR21defines it: verified (spec.md:103-107). - Claim: detents are named by value,
sheetHeightsruns ascending, andsheetSelectedDetentandonDetentChangetake and report the value: verified (FR6,spec.md:190-207). - Claim: menus use one model: verified (FR2's one menu description).
- Claim: component APIs appear only in the Who-uses-it table: verified,
BottomSheetappears only atspec.md:78-79. - Claim: the presentation host specifies five kinds, and
AlertDialogandPopoverare FR5 gap lines (OQ2): verified (spec.md:164-188,:330-333). - Claim: the record is in positive terms, Non-goals keeps only the template's two standing lines, and each decision states its direction and reason: verified as stated; Non-goals without an adjacent-behavior bullet is the blocking finding.
- Claim: each contract's baseline is its first release's shape, growing by named features: verified (FR15,
spec.md:293-295). - Claim: an unmapped row icon resolves to the fallback
Icondraws, so a row and anIconalways match: verified for the unmapped name; not underspec:AST-127'sthemeicon source (inline). - Claim:
presentresolves{status, index, reason, message}: verified (spec.md:316-319). - Claim: the description's Who-uses-it table is the same as the record's: verified, identical rows.
- Claim: component rows, heights, router options and
autodefaults stay in their own records: stated in the description only (blocking). - Claim: the implementation lives in the React Native package's platform layer: not verifiable here, since that package is not in this repository.
- Claim: writing rubric results R1–R7: verified, no pull request references, no
Rejected:lines, three gap lines in the required form, OQ1–OQ5 keep their options. - Claim: the knowledge check, Prettier and the whitespace check pass: verified, rerun at this head.
- File
docs/specs/AST-128-react-native-menus-presentation/spec.md: one blocking finding (Non-goals) and non-blocking notes.
| binary that lacks the piece, it answers false. The view hosts answer | ||
| `version()` with `null`. The probes are `isSystemMenuAvailable()`, | ||
| `isSystemMenuPreviewAvailable()`, `isPresentationHostAvailable()`, and | ||
| `nativePresentationHost.supports(kind)`. |
There was a problem hiding this comment.
Not blocking (Miss): supports is the capability shape's check for named features: the open spec:AST-112 amendment's FR7 has "supports(feature) where the capability has named features", and spec:AST-140 FR5 says each capability's supports(feature) reads the contract's feature list. Here it takes a kind (and the FR5 verification row tests supports(kind)). Suggest a kind probe with a name of its own, or making each later kind a named feature.
| `ok`, `cancelled`, or `error` (`spec:AST-140/FR3`); `show` is its positional | ||
| form. |
There was a problem hiding this comment.
Not blocking (Miss): spec:AST-140 FR3, cited on this line, says "At the binding, a native method takes one request object … and resolves one result object with status (ok, cancelled, or error), reason, and message". A positional show in the native contract does not follow it. Suggest dropping show from the native module and keeping it as a JavaScript wrapper over present, or giving it the request-object shape.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on this draft record; no blocking defect remains at this head.
Decision needed: spec:AST-128 FR1–FR16, DEC-1–DEC-4 and its native-contract and platform-support tables are new requirements that no current record states, and the record relies on current spec:AST-082 FR10 gaining a theme render.default, which that record does not allow today. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, including whether spec:AST-082 FR10 may gain that member through the spec:AST-112 amendment or must change first; the author may do so as an engineering owner.
The earlier Non-goals finding is fixed now that the Intent names what each component's record and the navigation record own; one new non-blocking note asks to cite that navigation record by id, and the earlier non-blocking notes stay in their open inline threads (FR3/FR12 predicates, spec:AST-112/FR1 citations, DEC-9, version(), ./host, the FR16 self-check, the theme icon source, supports(kind), the positional show, and the show-only verification state).
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record depends on the
spec:AST-112amendment and cites the openspec:AST-129,spec:AST-123,spec:AST-127andspec:AST-140drafts: verified, the record cites exactly those and all five pull requests are open drafts. - Claim: not stacked, merging after the amendment and
spec:AST-140: verified, no Stack line; the order is stated in the description only. - Claim: the record covers the four pieces' JavaScript surface, native contract, lifecycle, stacking, appearance and status bar, keyboard and safe area, accessibility, fallbacks and Android behaviour: verified (FR1–FR16).
- Claim: the record details
spec:AST-112FR1 and FR6–FR9: verified as cited; the amendment's FR1 no longer names the hosts (inline). - Claim: the record applies
spec:AST-082FR11 andspec:AST-093FR2 and FR3 to React Native on iOS: verified (spec.md:44-47). - Claim: the component records own each component's contract, and this record owns only the native pieces: verified, the Intent says so (
spec.md:49-52). - Claim:
spec:AST-129owns the window status bar view and keyboard dock,spec:AST-123the surface,spec:AST-127icon drawing: verified (FR9, FR10, FR1, FR2). - Claim: no current record states this group's native contract: verified,
spec:AST-112is draft onmainand no other record covers it. - Claim: FR1–FR16, the native contract and platform support tables, four decisions and five open questions: verified.
- Claim: FR16 allows public API only, with the modal host's one exception: verified (
spec.md:298-303). - Claim: Android draws its menus, sheets and dialogs, and moving to system hosts is open (OQ5): verified (
spec.md:336-337,:442-446). - Claim: FR1 maps the group onto
renderasspec:AST-112/FR21defines it: verified (spec.md:106-110). - Claim: detents are named by value,
sheetHeightsruns ascending, andsheetSelectedDetentandonDetentChangetake and report the value: verified (FR6,spec.md:193-210). - Claim: menus use one model: verified (FR2's one menu description).
- Claim: component APIs appear only in the Who-uses-it table: verified,
BottomSheetappears only atspec.md:81-82. - Claim: the presentation host specifies five kinds, and
AlertDialogandPopoverare FR5 gap lines (OQ2): verified (spec.md:167-191,:332-335). - Claim: the record is in positive terms, Non-goals keeps only the template's two standing lines, and each decision states its direction and reason: verified (
spec.md:84-93, DEC-1–DEC-4). - Claim: each contract keeps the baseline
spec:AST-140/FR5sets and grows by named features: verified (FR15,spec.md:296-297). - Claim: an unmapped row icon resolves to the fallback
Icondraws, so a row and anIconalways match: verified for the unmapped name; not underspec:AST-127'sthemeicon source (inline). - Claim:
presentresolves{status, index, reason, message}: verified (spec.md:317-321). - Claim: the description's Who-uses-it table is the same as the record's: verified, identical rows,
Headerwritten as TopNav's React Native form in both. - Claim: component rows, heights, router options and
autodefaults stay in their own records: verified (spec.md:49-52). - Claim: the implementation lives in the React Native package's platform layer: not verifiable here, since that package is not in this repository.
- Claim: writing rubric results R1–R7: verified, no pull request references, no
Rejected:lines, three gap lines in the required form, OQ1–OQ5 keep their options. - Claim: the knowledge check, Prettier and the whitespace check pass: verified, rerun at this head.
- File
docs/specs/AST-128-react-native-menus-presentation/spec.md: no blocking finding; non-blocking notes in the open inline threads.
| The menu, action sheet, presentation, and modal hosts belong to the platform's | ||
| core (`spec:AST-112/FR1`) and link in every app. Each component's own record | ||
| states its rows, sheet heights, dismissal rules, and `auto` default for | ||
| `render`, and the navigation record states the router's route options; this |
There was a problem hiding this comment.
Not blocking: "the navigation record" names no record, while every other owner here is cited by id. Neither open draft that describes the router, spec:AST-125 or the spec:AST-112 amendment, names the modal, formSheet, fullScreenModal or transparentModal route options the Who-uses-it table lists. Suggest citing the record that owns them, so a reader who has only this record can find the boundary's other side.
Depends on #12563 (the
spec:AST-112amendment: the package shape and default linking), plus the sibling records this record cites: #12552 (spec:AST-129), #12557 (spec:AST-123), #12555 (spec:AST-127), and #12594 (spec:AST-140, the shared platform rules).Not stacked. Merges after #12563 (AST-112) and #12594 (AST-140). It also cites #12552 (AST-129), #12557 (AST-123) and #12555 (AST-127).
Exact decision needed
Record the native contract of the React Native platform's menus and presentation group: the system menu (
AstryxSystemMenu), the action sheet module (AstryxActionSheet), the presentation host (AstryxPresentationHost), and the modal host (AstryxModalHost). The record states their JavaScript surface, native contract, lifecycle, stacking, appearance and status bar in presented windows, keyboard and safe area inside sheets, accessibility, fallbacks, and Android behaviour, as a child ofspec:AST-112.Existing authority searched
spec:AST-112(React Native foundation): parent; this record details its FR1 (the presentation, menu, and action-sheet hosts in the core) and FR6 to FR9, and links them instead of restating. The shared platform rules come fromspec:AST-140.spec:AST-082(native-first surfaces), FR11, andspec:AST-093(native component guidelines), FR2 and FR3: native-first sheets and menus; applied here to React Native on iOS.spec:AST-094(touch presentations) and the component records for BottomSheet, ContextMenu, DropdownMenu, MoreMenu, Dialog, AlertDialog, Drawer, Popover, Selector: they own each component's own contract; this record owns only the native pieces under them.spec:AST-129(Layout, text and keyboard) owns the window status bar view and the keyboard dock that presented surfaces use; linked, not restated.menu,sheet,presentation,React Native platform,ActionSheet): the open menu, sheet, and presentation pull requests change core web components. The open React Native platform records that touch this group, and the boundary with each:spec:AST-129, Layout, text and keyboard): owns the window status bar view of Android modal windows and the keyboard dock; this record links them (FR9, FR10).spec:AST-125, Navigation hosts): owns the native stack and tab hosts and their bar-item and title menus; this record owns the system menu view the library's menu components use and the presentation of modal routes.spec:AST-123, Surfaces and glass): ownssurfaceand the glass and material views under the library's drawn menus and sheets; FR1 cites it.spec:AST-127, Icons and drawing): owns icon and symbol drawing; a menu row resolves its icon asIcondoes (FR2).spec:AST-112amendment): the package shape and default linking this record relies on.spec:AST-140, React Native platform code): owns the shared platform rules (registration, missing pieces, results, additive evolution, threading, coexistence) that this record cites; this record keeps only its group's own rules.spec:AST-124, Gestures and drag): owns the drag-snap view the drawn sheets use and the gesture root's handling of a touch while a system menu is open; this record owns the menu and the sheet presentation.spec:AST-130, System modules): owns the platform info module whose feature probes the hosts here answer through; this record owns the hosts.No current record states this group's native contract.
Decision
The record (
docs/specs/AST-128-react-native-menus-presentation/spec.md) states FR1 to FR16 with the native contract tables and platform support, four decisions, and five open questions:FR16 states that the group's native code uses public API only, with one named exception (the modal host's hook into React Native's modal host, so a modal window leaves the screen with its owning component). Android's menus, sheets, and dialogs are drawn; whether they move to system hosts is open (OQ5). FR1 maps this group onto
renderasspec:AST-112/FR21defines it: the system menu, the action sheet and presented sheet chrome aresystem; the library's drawn menus and sheets aredrawn, with their look fromsurface(spec:AST-123). A sheet detent is identified by its value (a height or a named stop);sheetHeightsruns ascending by height, andsheetSelectedDetentandonDetentChangetake and report the value (FR6). Menus use one model. Component APIs (BottomSheet and the router's options among them) appear only in the Who-uses-it table. The presentation host specifies the five kinds it presents;AlertDialogandPopoverdraw their surfaces, written asFR5 gap:lines (OQ2).This revision also:
spec:AST-140/FR5sets and grows by named features (FR15,spec:AST-140/FR5).Icondraws for a name it cannot map (spec:AST-127), so a row and anIconalways match (FR2).presentresult as{status, index, reason, message}withstatusok,cancelled, orerror(spec:AST-140/FR3).Who uses it (same as the record):
AstryxSystemMenu(nativeSystemMenu)DropdownMenu,MoreMenu,ContextMenu,Selector(an iOS menu style over a short plain list),FileInput's source menu, and the components built on DropdownMenu's menu button (PlaybackRateMenu, the menus ofHeader(TopNav's React Native form)) or onDropdownMenu(Header's composed parts,Table,BarButton). Custom triggers reach it through theuseSystemMenuHost()hook on..AstryxActionSheet(nativeActionSheet)ActionSheet; through itFileInput's source menu where the system menu is absent, andItem's swipe actions that carry a menu.AstryxPresentationHost(nativePresentationHost)BottomSheet(the system sheet), and every surface that opens one:ActionSheet's drawn form,Popover's,DropdownMenu's andContextMenu's sheet forms,Selector's picker,MultiSelector,ComplexSelector,Typeahead,DateInput,DateRangeInput,Tokenizer,PowerSearch, the mega menu ofHeader(TopNav's React Native form).Dialog,AlertDialog,CommandPalette, and the modalDraweropen in its over-full-screen window. The router's stack navigator presents itsmodal,formSheet,fullScreenModal, andtransparentModalroutes through it.AstryxModalHostBottomSheet's drawn form on iOS and the router's drawn sheet routes: each drawn sheet opens in its own window.Rejected alternatives
Each decision in the record states its chosen direction and its reason.
Claim scope and non-goals
The record governs the four native pieces and their platform wrappers; its Non-goals section keeps only the template's two standing lines. Each component's rows, heights, purpose, and drawn surface stay in that component's record; the router's options stay with navigation; the window status bar and keyboard dock stay in
spec:AST-129; each component'sautodefault stays in that component's record.Evidence and implementation relationship
The implementation lives in the React Native package's platform layer (iOS views and module, their JavaScript wrappers, and the
./testingdoubles). No public evidence links; the record stays valid without them.Ecosystem comparison (the record keeps one conclusion per piece):
ActionSheetIOSshows UIAlertController's action sheet from the top-most controller, with destructive and disabled rows, an iPad anchor, and an interface style, at no dependency cost.ActionSheetIOSanswers through a callback with an index only: it reports no refused presentation, no second sheet while one is up, and no calling surface. These are small gaps; OQ1 asks whether the platform builds on it instead.Modalpresents page and form sheets and full-screen windows. react-native-screens'formSheetgives a navigation route UIKit's detent sheet with a grabber and corner radius. @gorhom/bottom-sheet draws a fully customisable sheet with gesture-handler and Reanimated on both platforms.Modalhas no detents, and it presents from the view controller of its own screen; when that controller already shows a sheet, UIKit refuses the next one. A react-native-screens sheet is a route of its navigator, not a component a screen opens anywhere in its tree, and the package takes no third-party navigation dependency (spec:AST-112/DEC-9). A drawn sheet is not the system container: no iOS 26 Liquid Glass at partial heights, no card effect, no system keyboard avoidance. The host gives every Astryx surface the system container through one queue (DEC-2).Modalhost is the platform's window for drawn content, with orientations, swipe dismissal,onRequestClose, and VoiceOver focus save and restore.Writing rubric results
./testing, Simulator, devices, UI-thread frame checks).renderaxis (spec:AST-112/FR21); it moved into FR1 and the question is gone. OQ1 to OQ5 are unanswered and keep their options. The Android host choice, which had been drafted as a decision, is OQ5.spec:AST-082/FR11 gap:(Android draws menus, sheets and dialogs) and twoFR5 gap:lines (AlertDialogandPopoverdraw their surfaces).Scope
Components: AstryxSystemMenu, AstryxActionSheet, AstryxPresentationHost, AstryxModalHost (React Native platform)
Validation
pnpm check:knowledge(run asnode scripts/check-knowledge.mjsagainst a main-based tree): exit 0, "Knowledge templates and records are aligned.", no warning for this record.--checkon the record: ok.git diff --check origin/main: clean.pnpm specs:fornot run: the worktree has no install.