Skip to content

spec(AST-124): React Native platform: Gestures and drag - #12562

Draft
imdreamrunner wants to merge 21 commits into
mainfrom
spec/ast-124-react-native-gestures-drag
Draft

imdreamrunner wants to merge 21 commits into
mainfrom
spec/ast-124-react-native-gestures-drag

Conversation

@imdreamrunner

@imdreamrunner imdreamrunner commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Not stacked. Merges after #12563 (AST-112) and #12594 (AST-140).

Exact decision needed

The system contract of the gesture and drag pieces of the React Native platform layer (@astryxdesign/react-native): the nine native components AstryxDragItem, AstryxDropZone, AstryxGestureOwnerView, AstryxGestureRootView, AstryxDragSnap, AstryxSwipeRow, AstryxPanZoomView, AstryxPinchScaleView, and AstryxZoomPager, the gesture handle module AstryxGestureHandles, their JavaScript wrappers, and the rules they share: motion runs on the UI thread and JavaScript receives settled events; frame events feed Animated's native driver; components declare the drag directions they own and the platform's own gestures yield; other recognizers relate to Astryx's through gesture handles; drag and drop is a system session. The record specifies the native contracts, the gesture handle API on the refs of the components that render these views (getGestureHandle), and relateGesture; the library components that use the views are named under "Who uses it".

Existing authority searched

  • spec:AST-112 (React Native foundation): the parent. This record details its FR1 core hosts and FR7 for this group, relies on the amended FR5 (the gesture views internal behind the library's components on ./controls) and FR3 (default linking), and states the gesture handle API that the amended FR18 points to (FR16 here).
  • spec:AST-140 (React Native platform code): the shared platform rules. This record cites its FR2 (missing piece), FR3 (result vocabulary), FR5 (named features), FR6 (threading), and FR9 (coexistence) instead of restating them.
  • spec:AST-082 (native-first surfaces) and spec:AST-093 (native component guidelines): read; no claim about gesture ownership, UI-thread motion, or system drag and drop.
  • spec:AST-107 (public gesture hooks): owns Core's web gesture hooks. The pinch piece and the handle relationships use the vocabulary of Core's web recognizers (PinchGestureRecognizer: scale, velocity in scale per second, focal point; recognizeSimultaneouslyWith, requireToFail).
  • spec:AST-103 (reorderable) and the List, Lightbox component records: checked for overlap with drag and drop and zoom; they own web component behaviour, not the React Native platform views.
  • Open pull requests searched with gesture, drag, react native spec, and AST-12: the open gesture and drag work is web Core (touch runtime loading, Lightbox, Toast, List reordering); none touches the React Native platform layer.
  • spec(Item): React Native platform record #12823 (component:react-native/Item, open draft): its FR16 and its "native swipe row absent" state follow DEC-7: where the native swipe row is absent, Item takes no swipe drag and keeps its entries as accessibility actions.
  • spec(List): React Native platform record #12819 (component:react-native/List, open draft): relies on FR17 and DEC-6 (the pinch) and leaves reordering to this record; it states no absent-view rule, so DEC-7 does not collide with it.
  • No existing record owns these pieces; AST-112 names the gesture hosts only as members of the core. The Android back module belongs to spec:AST-130; this record does not specify it.

Decision

The record states, as requirements: UI-thread motion with milestone events (FR1); frame events that drive Animated values through the native driver with no JavaScript per frame (FR2); gesture ownership through the gesture owner on iOS and Android, and the iOS root that lets a menu's dismiss tap close the menu alone (FR3, FR4); the native contracts of drag and snap (stops identified by value, listed ascending by extent), swipe row, pan and zoom, zoomable pager (an internal native contract whose public face is Lightbox), and system drag and drop (FR5 to FR9); the native contract tables (FR10); absent-view behaviour (FR11); accessibility pass-through (FR12); Reduce Motion and right-to-left (FR13); growth by named features, with the pinch view as the group's named feature AstryxPinchScaleView.pinch, read through contractFeatures (FR14); public platform API only, with one named exception for the iOS gesture root's menu check (FR15); gesture handles (FR16): what a handle is ({viewTag, recognizer}, one per named recognizer: pan, pinch, doubleTap, twoFingerTap), how an app gets one (getGestureHandle on the component's ref), and how a recognizer from outside Astryx relates to it (simultaneous, requireToFail, from JavaScript or native code); Astryx-to-Astryx relations stay declarative through the gesture owner view; and the pinch around a scroller (FR17): a native pinch that wraps a List, ScrollView or FlatList with no scroll view of its own, draws the scale on the scroller's content, holds the scroller while two fingers are down, drives values {scale, focalX, focalY} through the native driver only, and sends one onPinchEnd {scale, focalX, focalY, velocity, isCancelled}, with isEnabled and isContentScaled (default true). A binary without the pinch feature renders a plain View with one warning; the List and ScrollView component records decide the pinch's public face. The record is written in positive terms: Non-goals keeps only the template's two standing bullets (equivalent implementations stay valid; internal mechanisms belong in architecture unless a caller depends on them), and each decision states its direction and reason.

Who uses it

See the record's "Who uses it" table: the nine native pieces, the Astryx components that use each, and what a person sees.

Ecosystem comparison (context for "Why this exists"; not part of the record)

Pieces What the ecosystem does well Why Astryx owns the piece
Gesture ownership (GestureOwnerView, GestureRootView) react-native-gesture-handler runs native recognizers off the JS thread and composes them declaratively (simultaneous, exclusive, wait-for relations) under its root view. Astryx components win against the platform's own recognizers inside Astryx's native hosts (back swipes, sheet drag, scroll views, Android's system back gesture) from live state, with React and React Native as the only peers; gesture handles let other libraries' recognizers relate to Astryx's.
Drag and snap, swipe row (DragSnap, SwipeRow) react-native-reanimated runs animation and gesture logic as worklets on the UI thread with react-native-gesture-handler for input; sheet and swipeable libraries built on them are mature and flexible. Astryx keeps one JavaScript runtime per app and matches release projection, one stop per fling, UIScrollView's rubber band, detents and scroll hand-off to UIKit and Android, arbitrated with its own hosts.
Pan and zoom, zoomable pager, pinch (PanZoomView, ZoomPager, PinchScaleView) React Native's ScrollView zooms on iOS; react-native-pager-view pages natively; zoom and image-viewer libraries cover pinch, pan, and dismiss. Astryx needs a programmatic camera whose animation resolves once, native-driver frames, iOS 26 back-swipe arbitration, and a pinch that wraps a list so its large title keeps tracking it.
System drag and drop (DragItem, DropZone) Reordering libraries move a view inside the app and suit list reordering. The system session gives the system lift and preview, arbitration with a context menu, iPad pointer drags, screen-reader drag actions, and data to other apps.

Rejected alternatives

None recorded. DEC-1 and DEC-3 state their rules with their reasons: gesture motion runs on the UI thread, and Astryx takes no third-party native dependency for gestures while working beside react-native-gesture-handler and react-native-reanimated in the same app.

Claim scope and non-goals

Governs the nine native components, the gesture handle module, their wrappers, and the shared rules. Non-goals: the template's two standing bullets only. Where a view is absent, Item and the drag-and-drop components take no drag and keep their accessibility actions (DEC-7). Open: backGesture on Android (OQ2, leaning to Android ignoring it with ownsEdge as the only exclusion, settled by an Android device test with gesture and three-button navigation). The pan-zoom view's public face is a designed Astryx component in the React Native lab, and the view itself is not exported (DEC-8); this answers spec:AST-112 OQ7 for that component, as Current-state impact says.

Evidence and implementation relationship

The implementation lives in the React Native package's platform layer (codegen specs, iOS and Android views, JavaScript wrappers) and in the library components that use it; the record was written against that code and its contract list. No public evidence links. The record stays valid without this PR description.

Writing rubric results

  • R1 narration: requirements in the record's own words over the native contracts; scanned for proposes, decided, previously, a port of, now; none. Every contract is described by its baseline and named features (FR14).
  • R2 research in the record: the ecosystem survey lives in this description; the record keeps one conclusion per piece.
  • R3 evidence naming a change: none; Verification cells name evidence layers (unit tests through the ./testing doubles, Simulator and emulator checks, UI-thread frame checks).
  • R4 rejected alternatives over one line or outside a decision: none; the record carries no Rejected: lines.
  • R5 pull request or issue references remaining: none (searched for # with digits, /pull/, /issues/).
  • R6 ruled open questions still listing options: none; OQ1 and OQ3 are answered and removed (DEC-7, DEC-8); OQ2 is unanswered and keeps its options, its lean and the test that settles it.
  • R7 project status: three gap lines in the required form (FR5 gap, FR7 gap, FR8 gap).

Scope

Components: React Native platform layer: GestureOwnerView, GestureRootView, NativeDragItemView, NativeDropZoneView, DragSnapView, SwipeRowView, PanZoomView, PinchScaleView, ZoomPagerView, gesture handles

  • This PR contains specification records only.
  • It records observable behavior and preserves equivalent internal implementations.
  • Any named internal mechanism is intentionally public, names its dependent caller/system, and explains why an equivalent implementation would not satisfy the contract.
  • Verification states the evidence layer and failure signal without prescribing CI job/workflow topology.
  • It records one intentional durable decision, not a rescue for a separable tagalong.
  • The canonical knowledge owner, affected current claims, and overlapping open work are named; any ownership collision is resolved or called out for human decision.
  • Adjacent API, visual, accessibility, composition, and implementation facts remain outside scope unless this exact decision depends on them.
  • Public text contains no internal context.

Validation

  • pnpm check:knowledge (node scripts/check-knowledge.mjs): "Knowledge templates and records are aligned."; no error or warning for this record.
  • Prettier --check on the record: all matched files use Prettier code style.
  • git diff --check origin/main: clean.
  • pnpm specs:for --diff origin/main: not run (no dependency install in this checkout).

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Building Building Preview Nov 19, 2026 9:49pm UTC

Request Review

@astracat-bot

astracat-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🔄 In progress (for maintainers only) Nov 19, 2026, 9:49 PM UTC

… and its one exception, and why the swipe row draws its actions
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 18, 2026

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval waits on an engineering owner deciding the new requirements in draft spec:AST-124 (FR1–FR16 and DEC-1–DEC-5, including FR15's default linking in place of the opt-in controls capability of draft spec:AST-112), which no current record states. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as one.

These record defects need fixing whatever the decision:

  • FR5 identifies drag-and-snap stops by value and never by index, yet FR10's revision-1 table still lists restIndex and FR14 says FR3–FR10 describe revision 1 with no named features, so the record needs one stop contract and a stated route from the shipped index-based API.
  • FR1 says no view sends JavaScript an event per frame, but FR9's onDropZoneMove fires up to once a frame during a drag and FR7's onCameraChange has no interval floor, so FR1 needs those exceptions named or the two streams need a floor.
  • The "Why this exists" table is an ecosystem survey that architecture:knowledge-contracts INV10 keeps out of records, so move it to an artifact linked from the pull request, keep its conclusions inside DEC-3 to DEC-5, and correct the R2 rubric result.
  • Current-state impact says no other record changes, but the record also moves the touch shield out of spec:AST-112 FR1's platform core with no record left to own it, and it places the pan-zoom view on ./controls, where spec:AST-112 FR1 does not list it, so list both changes or keep the touch shield in the core.

The review also covers four smaller points: the wording for a command sent to an absent view against spec:AST-112/FR7, the undefined stop value and horizontal ordering in FR5, the non-goals' unnamed sibling records, and the onEnd event name in the FR9 verification row.

Claims and files checked

Review mode: full; reason: no-earlier-review

  • Claim: the record specifies native contracts only and leaves the library components' API out of scope — verified (Non-goals).
  • Claim: the record details the foundation record's core hosts and shared rules and changes its FR1 and FR3 for default linking — partly false: it also moves the touch shield out of the foundation's platform core and places pan-zoom on ./controls, neither of which its impact section lists.
  • Claim: the native-first-surfaces and native-component-guidelines records say nothing about gesture ownership, UI-thread motion or system drag and drop — verified.
  • Claim: the public gesture hooks record owns Core's web gestures, and the reorderable, List and Lightbox records own web behaviour only — verified.
  • Claim: no existing record owns these pieces, and no open spec pull request overlaps this group — verified; the sibling platform records it defers to are open drafts and are not cited by id.
  • Claim: the knowledge check passes — verified (run on this head).
  • Claim: Prettier formatting passes — verified (run on this head).
  • Claim: whitespace is clean — verified (no trailing whitespace; the file ends with a newline).
  • Claim: rubric R1, R5, R6 and R7 find nothing left to fix — verified.
  • Claim: rubric R2 finds no survey, and R4 finds the rejected alternatives only inside DEC-1 and DEC-3 — false: "Why this exists" is an ecosystem survey that restates the worklet rejection.
  • Claim: public text carries no internal context — verified.
  • Claim: ownership collisions are resolved or called out — false for the touch shield.
  • File: docs/specs/AST-124-react-native-gestures-drag/spec.md — four blocking findings (stop identity, per-frame events, survey, impact section) and four smaller points.

Automated review (maintainer link)

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval waits on an engineering owner deciding the new requirements in draft spec:AST-124 (FR1–FR16 and DEC-1–DEC-5, including FR15's default linking in place of the opt-in controls capability of draft spec:AST-112), which no current record states. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as one.

These record defects need fixing whatever the decision:

  • FR5 identifies drag-and-snap stops by value and never by index, yet FR10's revision-1 table still lists restIndex and FR14 says FR3–FR10 describe revision 1 with no named features, so the record needs one stop contract and a stated route from the shipped index-based API.
  • FR1 says no view sends JavaScript an event per frame, but FR9's onDropZoneMove fires up to once a frame during a drag and FR7's onCameraChange has no interval floor, so FR1 needs those exceptions named or the two streams need a floor.
  • The "Why this exists" table is an ecosystem survey that architecture:knowledge-contracts INV10 keeps out of records, so move it to an artifact linked from the pull request, keep its conclusions inside DEC-3 to DEC-5, and correct the R2 and R4 rubric results.
  • Current-state impact says no other record changes, yet the record hands the touch shield to spec:AST-139, which is not on main and whose open draft does not name it while spec:AST-112 FR1 keeps it in the platform core, puts the pan-zoom view on ./controls where FR1 does not list it, and calls the drag-and-drop views part of the core, which FR1 never names (an earlier review missed this last point), so list each change there and give the touch shield one owner that states its contract.

The review also covers five smaller points: the wording for a command sent to an absent view against spec:AST-112/FR7, the undefined stop value and horizontal ordering in FR5, the non-goals' unnamed sibling records, the onEnd event name in the FR9 verification row, and OQ3 asking about pan-zoom linking that FR15 already decides.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: the record covers the eight native contracts, their wrappers and shared rules, and specifies native contracts only — verified (Requirements, Non-goals).
  • Claim: the touch shield is part of the Astryx app's Preview host under the Stage and app record — false: that record is not on main, and its open draft does not name the touch shield.
  • Claim: the record details the foundation record's core hosts and shared rules and changes only its FR1 and FR3 for default linking — partly false: it also moves the touch shield, adds the pan-zoom view to ./controls, and places the drag-and-drop views in the core.
  • Claim: the native-first-surfaces and native-component-guidelines records say nothing about gesture ownership, UI-thread motion or system drag and drop — verified.
  • Claim: the public gesture hooks record owns Core's web gestures, and the reorderable, List and Lightbox records own web behaviour only — verified.
  • Claim: no existing record owns these pieces, and no open spec pull request overlaps this group — partly false: no current record owns them, but the open foundation edit also makes the library's gesture views link by default and groups the touch shield under gestures and drag.
  • Claim: the rejected alternatives sit inside DEC-1, DEC-3, DEC-4 and DEC-5 — partly false: DEC-4 states no rejection, and the gesture-handler point lives only in "Why this exists".
  • Claim: the record was written against the platform layer's implementation — not checkable here: that package is not in this repository.
  • Claim: rubric R1, R3, R5 and R7 find nothing left to fix — verified.
  • Claim: rubric R2 finds no survey, and R4 finds rejected alternatives only inside decisions — false: "Why this exists" is an ecosystem survey that restates the worklet rejection.
  • Claim: rubric R6 finds no ruled question that still lists options — partly false: FR15 already links the pan-zoom view by default while OQ3 still asks whether it should.
  • Claim: public text carries no internal context — verified.
  • Claim: ownership collisions are resolved or called out — false for the touch shield.
  • Claim: the knowledge check passes — verified (run on this head).
  • Claim: Prettier formatting passes — verified (run on this head).
  • Claim: whitespace is clean — verified (no trailing whitespace; the file ends with a newline).
  • File: docs/specs/AST-124-react-native-gestures-drag/spec.md — four blocking findings and five smaller points.

Automated review (maintainer link)

…ops by value in the contract, bounded per-frame streams named, AST-112 reliance listed

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval waits on an engineering owner deciding the new requirements in draft spec:AST-124 (FR1–FR15 and DEC-1–DEC-5), which no current record states, including FR5's drag-and-snap stops identified by value as the revision-1 contract in place of the shipped index form. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as one.

This needs fixing whatever the decision:

  • The description's "Existing authority searched" still says the record changes spec:AST-112 FR1 and FR3 so the gesture views link by default, but at this head the record relies on the amended FR3 and changes FR1 (the touch shield) and FR5 (./controls) instead, so that bullet needs rewriting to match Current-state impact.

The earlier record defects are fixed at this head; six smaller points remain: Current-state impact restating the foundation amendment's own FR1 and FR5 edits, OQ3 against the amendment's linking table, the FR5–FR8 verification row and asked-for camera events, how onDragThreshold reports a dismiss, the touch shield's scrolling note against spec:AST-139, and the merge order leaving out the sibling records this one delegates to.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: the record depends on the foundation amendment for default linking, the revision-1 baseline with named features and the Stage version floor — verified (the amendment states all three).
  • Claim: the record cites the navigation hosts, menus and presentation, and Stage and app sibling records — verified (Non-goals and Current-state impact).
  • Claim: the merge order is the foundation promotion, then the amendment, then this record — stated; it leaves out the three sibling records the record delegates to.
  • Claim: the record covers eight native contracts, their wrappers and shared rules, with the touch shield outside it and kept to one "Who uses it" row — verified.
  • Claim: the record specifies native contracts only and only names the library components that use them — verified.
  • Claim: the record details the foundation record's core hosts, result vocabulary, capability shape, evolution rule and Stage contract, and changes its FR1 and FR3 for default linking — false: it relies on the amended FR3 and changes FR1 and FR5.
  • Claim: the native-first-surfaces and native-component-guidelines records say nothing about gesture ownership, UI-thread motion or system drag and drop — verified.
  • Claim: the public gesture hooks record owns Core's web gestures, and the reorderable, List and Lightbox records own web behaviour only — verified.
  • Claim: no current record owns these pieces, and no open spec pull request overlaps this group — verified: the other open React Native records are the dependencies and siblings the description names.
  • Claim: the Decision section's summary of FR1 to FR15 — verified.
  • Claim: default linking, named features and the Stage version floor are relied on from the amended foundation record — verified.
  • Claim: the worklet route is rejected in DEC-3 and DEC-4 — verified: DEC-3 rejects it, and DEC-4 holds the arbitration with platform gestures that the last reason rests on.
  • Claim: the JavaScript responder fallback and the in-app drag are rejected in DEC-1 and DEC-5 — verified.
  • Claim: OQ1 to OQ3 stay open with their options — verified within the record; the amendment's linking table already links the pan-zoom view.
  • Claim: the record was written against the platform layer's implementation — not checkable here: that package is not in this repository.
  • Claim: rubric R1 to R7 results — verified: no narration, the survey moved out, two one-line rejections, no pull request references, three gap lines.
  • Claim: the pull request holds specification records only and its public text has no internal context — verified.
  • Claim: ownership collisions are resolved or called out — verified for the touch shield, whose behaviour the Stage and app draft now states; its scrolling note disagrees with that draft.
  • Claim: the knowledge check, Prettier and the whitespace check pass — verified (run on this head).
  • File: docs/specs/AST-124-react-native-gestures-drag/spec.md — one blocking finding in the description, six smaller points.

Automated review (maintainer link)

… open question, a dismiss named in onDragThreshold, touch shield cell aligned

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval waits on an engineering owner deciding the new requirements in draft spec:AST-124 (FR1–FR15 and DEC-1–DEC-5), which no current record states, including value-identified drag-and-snap stops as the revision-1 contract and whether AstryxPanZoomView is public app API. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as one.

This needs fixing whatever the decision:

  • Current-state impact (spec.md:377-379) and the description's "Existing authority searched" say the amended spec:AST-112 FR5 puts the gesture views, the pan-zoom view included, on ./controls, but that FR5 now says the controls and views themselves stay internal, so either state the pan-zoom view as a change to FR5 for the owner to decide, or keep it internal and drop the app-API wording from the "Who uses it" row and OQ3.

The earlier points are fixed at this head. Three smaller ones remain against the drafts the record now cites: FR1's per-frame streams beside spec:AST-140/FR6, the self-check spec:AST-140/FR9 asks for beside FR15's private class-name read, and the per-recognizer handle in the amended spec:AST-112 FR18.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: the record merges after the foundation amendment and the platform code record — stated; those two records hold what it relies on.
  • Claim: the record cites the navigation hosts, menus and presentation, Astryx Stage, and Preview sibling records — verified (Non-goals).
  • Claim: the record covers eight native contracts, their wrappers and shared rules, with the touch shield outside it and kept to one "Who uses it" row — verified.
  • Claim: the record specifies native contracts only and only names the library components that use them — verified.
  • Claim: the record details the foundation record's core hosts and capability shape, and relies on the amended FR1 and FR3 — verified.
  • Claim: the record relies on the amended foundation FR5 for ./controls holding the gesture views — false: the amendment's FR5 puts only the library's components there and keeps the views internal.
  • Claim: the record cites the platform code record's missing-piece, result, revision-1, threading and coexistence rules — verified: each exists and says so.
  • Claim: the native-first-surfaces and native-component-guidelines records say nothing about gesture ownership, UI-thread motion or system drag and drop — verified.
  • Claim: the public gesture hooks record owns Core's web gestures, and the reorderable, List and Lightbox records own web behaviour only — verified.
  • Claim: no open spec pull request overlaps this group — verified: the other open React Native records are the dependencies and siblings named.
  • Claim: no existing record owns these pieces, and the Android back module belongs to the system modules record — verified: the open system modules draft owns the back module.
  • Claim: the Decision section's summary of FR1 to FR15 — verified.
  • Claim: default linking and named features are relied on from the amended foundation record — verified: its FR3 links the group, and its FR8 hands named features to the platform code record the record cites.
  • Claim: Astryx Stage and Preview are separate products that conform to these contracts — verified (Non-goals).
  • Claim: the worklet route, a JavaScript responder fallback and an in-app drag are rejected in DEC-1, DEC-3, DEC-4 and DEC-5 — verified.
  • Claim: OQ1 to OQ3 stay open with their options — verified.
  • Claim: the record was written against the platform layer's implementation — not checkable here: that package is not in this repository.
  • Claim: rubric R1 to R7 results — verified: no narration or pull request references, the survey sits in the description, two one-line rejections, three gap lines.
  • Claim: the pull request holds specification records only and its public text has no internal context — verified.
  • Claim: ownership collisions are resolved or called out — verified for the touch shield, whose inspector behaviour the Preview draft states; the pan-zoom view's ./controls status collides with the amendment and is not called out.
  • Claim: the knowledge check, Prettier and the whitespace check pass — verified (run on this head).
  • File: docs/specs/AST-124-react-native-gestures-drag/spec.md — one blocking finding (shared with the description), three smaller points.

Automated review (maintainer link)

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval waits on an engineering owner deciding the new requirements in draft spec:AST-124 (FR1–FR15 and DEC-1–DEC-5), which no current record states, including value-identified drag-and-snap stops as the revision-1 contract. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as one.

No blocking finding remains: the pan-zoom view now stays internal as the amended spec:AST-112 FR5 says, and the three earlier smaller points are fixed. Two smaller points are worth a look before the decision:

  • Miss: FR6 gives the swipe row's five states as numbers (snapTo(index), onSwipeSettle), while draft spec:AST-140/FR4 and spec:AST-112 FR7 carry closed sets as string unions; name the states, or say why the numbers stay.
  • Row 72 says the maps template uses AstryxPanZoomView, which the record now keeps internal, so OQ3's answer also decides how that template reaches it.
Claims and files checked

Review mode: full; reason: spec-record

  • Claim: the record merges after the foundation amendment and the platform code record — stated; both are open drafts that hold what it relies on.
  • Claim: the record cites the navigation hosts, menus and presentation, Astryx Stage, and Preview sibling records — verified (Non-goals, Current-state impact).
  • Claim: the record covers eight native contracts, their wrappers and shared rules, with the touch shield outside it and kept to one "Who uses it" row — verified.
  • Claim: the record specifies native contracts only and only names the library components that use them — verified.
  • Claim: the record details the foundation's core hosts and capability shape, and relies on the amended FR1 and FR5 (touch shield outside the core, gesture views internal behind the library's components) and FR3 (default linking) — verified against the amendment's current text.
  • Claim: the record cites the platform code record's missing-piece, result, revision-1, threading and coexistence rules — verified: each exists and says so.
  • Claim: the native-first-surfaces and native-component-guidelines records say nothing about gesture ownership, UI-thread motion or system drag and drop — verified.
  • Claim: the public gesture hooks record owns Core's web gestures, and the reorderable, List and Lightbox records own web behaviour only — verified.
  • Claim: no open spec pull request overlaps this group — verified: the other open React Native records are the named dependencies and siblings, and the NavigationStack platform record only relies on FR3 and FR13.
  • Claim: no existing record owns these pieces, and the Android back module belongs to the system modules record — verified: that open draft owns it.
  • Claim: the Decision section's summary of FR1 to FR15 — verified.
  • Claim: default linking and named features are relied on from the amended foundation record — verified: its FR3 links the library's native half and its FR7 table links this group in the core; its FR8 hands named features to the platform code record.
  • Claim: Astryx Stage and Preview are separate products that conform to these contracts — verified (Non-goals).
  • Claim: the worklet route, a JavaScript responder fallback and an in-app drag are rejected in DEC-1, DEC-3 and DEC-5 — verified.
  • Claim: OQ1 to OQ3 stay open with their options — verified.
  • Claim: the record was written against the platform layer's implementation — not checkable here: that package is not in this repository.
  • Claim: rubric R1 to R7 results — verified: no narration or pull request references, the survey sits in the description, two one-line rejections, three gap lines.
  • Claim: the pull request holds specification records only and its public text has no internal context — verified.
  • Claim: ownership collisions are resolved or called out — verified: the touch shield sits with the Preview record's inspector rule, and the pan-zoom view is internal as the amendment says, with its public face in OQ3.
  • Claim: the knowledge check, Prettier and the whitespace check pass — verified (run on this head).
  • Claim: the specs-for lookup was not run — stated.
  • File: docs/specs/AST-124-react-native-gestures-drag/spec.md — no blocking finding; two smaller points.

Automated review (maintainer link)

Comment on lines +215 to +218
- Command: `snapTo(index)` with 0 closed, 1 leading open, 2 trailing open, 3
out past the inline end, 4 out past the inline start. Events:
`onSwipeBegin` (side), `onSwipeThreshold` (`armed`), `onSwipeSettle`
(index), `onSwipeCommit` (side).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking (missed in earlier reviews): these five states are a closed set carried as numbers in snapTo(index) and onSwipeSettle, while draft spec:AST-140/FR4 and spec:AST-112 FR7 carry closed sets as string unions. Since FR14 already re-baselines the drag-and-snap stops, name the states (for example closed, leading, trailing, outEnd, outStart), or say why the swipe row keeps numbers.

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ready to approve: the new gesture and drag record waits on an engineering owner's decision, and four fixes are needed whatever that decision is.

  • FR16 makes Astryx's recognizer the waiter for a JavaScript requireToFail, but its Android rule has the outside recognizer wait for Astryx's (spec.md:371-374 against :381-383), so state Android's rule for both directions.
  • FR16 says every recognizer has a handle, but its names stop at pan and pinch and leave out the pan-zoom view's double-tap and two-finger-tap recognizers and the zoom pager's double tap (spec.md:349-350, :359-361), so name them or narrow the sentence.
  • FR14 puts FR10's AstryxPinchScaleView row in the baseline while FR17 makes the same pinch a named feature, and FR11 gives that view no availability probe (spec.md:337-338, :416-419, :300-303), so choose one model and say how JavaScript detects it.
  • The description says the record cites the AST-125 and AST-128 records and specifies native contracts only, but it cites neither and FR16 adds API on library component refs, so update those two lines.

Every requirement here (FR1–FR17, DEC-1–DEC-6) is new direction that no current record states, so approval waits on an engineering owner recording the decision by commenting /approve-spec <full head SHA> on this pull request; the author may do so as an engineering owner. Smaller points (the pinch view's public face names a ScrollView record that does not exist, relateGesture's view-tag target, and the swipe row's pointer rule) are in the inline comments.

Claims and files checked

Review mode: full; reason: spec-record

Claims:

  • The record merges after the AST-112 and AST-140 records: verified; it cites claims found only in those two open drafts.
  • The record cites the AST-125 and AST-128 sibling records: false; it cites neither.
  • The record specifies native contracts only: false; FR16 adds a handle method on library component refs and a JavaScript relate function.
  • The record details AST-112's core hosts and capability shape and relies on its amended linking, public-surface and handle clauses: verified against Current-state impact.
  • The record cites AST-140's missing-piece, result, named-feature, threading and coexistence rules: verified.
  • AST-082 and AST-093 state nothing about gesture ownership, UI-thread motion or system drag and drop: verified for their requirements.
  • The pinch and relationship vocabulary follows Core's web recognizers: verified against Core's pinch recognizer (scale, velocity in scale per second, focal point) and its requireToFail and recognizeSimultaneouslyWith.
  • No other open spec pull request covers this group: verified; the NavigationStack React Native record defers to FR3.
  • The decision summary of FR1–FR17: verified against the record.
  • Non-goals keep only the template's two standing bullets: verified against the system-spec template.
  • No rejected alternatives are recorded: verified.
  • Writing rubric R1–R7 results: verified; no narration, research, change references or project status, and three gap lines in the required form.
  • The knowledge check and Prettier pass: verified by running both on the head.
  • The record was written against the package's code: not checkable here; the package is not in this repository.

Files:

  • docs/specs/AST-124-react-native-gestures-drag/spec.md: the three record findings above (FR16 twice, FR14 with FR17), plus non-blocking notes on FR17's public face, relateGesture's target, FR6's pointer rule, FR6's numeric states and the maps template.

Automated review (maintainer link)

Comment on lines +388 to +389
large title keeps collapsing with it. It is an internal native piece; the
`List` and `ScrollView` component records decide its public face.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: no ScrollView component record exists on main (Core's scroller record is ScrollableArea), and the Who-uses-it row adds FlatList, which has none either. Name the records that decide the pinch view's public face.

Comment on lines +192 to +193
- **FR6 — Swipe row.** `AstryxSwipeRow` slides a row horizontally over the
panels behind it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: the Item rows this view serves must not open under a mouse drag (spec:AST-057 AR2, current), and spec:AST-082 FR3 keeps a prop behaving as core defines it for each input type. On iPad a mouse or trackpad click-drag reaches a UIKit pan; say the swipe row ignores it, or how Item keeps AR2.

…oth ways; pinch view read as a named feature

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ready to approve yet: the new gesture and drag record waits on an engineering owner's decision; this head fixes the four points raised last time, and nothing else blocks.

Every requirement here (FR1–FR17, DEC-1–DEC-6) is new direction that no current record states, so approval waits on an engineering owner commenting /approve-spec <full head SHA> on this pull request; the author may do so as an engineering owner. The decision covers in particular the gesture handle API on library component refs (including which entry exports relateGesture), the pinch view as the group's one named feature with no availability probe, and drag-and-snap stops identified by value. Smaller non-blocking points are in the inline comments: Current-state impact's spec:AST-112 FR1 line, a name for the one-finger tap recognizer, and the open notes on the pinch view's public face, the swipe row's pointer rule and numeric states, and the maps template.

Claims and files checked

Review mode: full; reason: spec-record

Claims:

  • The record is not stacked and merges after the AST-112 amendment and the AST-140 record: verified; it relies on clauses found only in those two open drafts.
  • The decision covers nine native components, the gesture handle module, their wrappers and the shared rules: verified against FR10's two tables.
  • The record specifies the native contracts, the handle API on component refs and relateGesture: verified against FR16.
  • The record details AST-112's core hosts and capability shape and relies on its amended public-surface, linking and handle clauses: verified; the core-host list exists only in the current AST-112 FR1 (non-blocking note).
  • The record cites AST-140's missing-piece, result, named-feature, threading and coexistence rules instead of restating them: verified.
  • AST-082 and AST-093 state nothing about gesture ownership, UI-thread motion or system drag and drop: verified for their requirements.
  • The pinch and relationship vocabulary follows Core's web recognizers: verified against Core's pinch recognizer (scale, velocity in scale per second, focal point) and its requireToFail and recognizeSimultaneouslyWith.
  • The reorderable, List and Lightbox records own web behaviour, not these views: verified; none mentions React Native.
  • No other open spec pull request covers this group: verified; the other React Native records cover other groups.
  • No existing record owns these pieces, and AST-112 names the gesture hosts only as core members: verified.
  • The Android back module belongs to the system-modules record, not this one: verified against that open draft.
  • The decision summary of FR1–FR17, including the handle names and the pinch view read as a named feature: verified; the one development warning goes to a caller that passed values or onPinchEnd.
  • Non-goals keep only the template's two standing bullets: verified against the system-spec template.
  • No rejected alternatives are recorded, and DEC-1 and DEC-3 carry their reasons: verified.
  • Open questions OQ1 to OQ3 stay open with their options: verified.
  • The record was written against the package's code: not checkable here; the package is not in this repository.
  • Writing rubric R1–R7 results: verified; no narration, research, change references or project status, and three gap lines in the required form.
  • The knowledge check, Prettier and whitespace checks pass: verified by running them on the head.

Files:

  • docs/specs/AST-124-react-native-gestures-drag/spec.md: no blocking finding; non-blocking notes on Current-state impact's FR1 line, the one-finger tap handle, the pinch model against the two drafts, the pinch view's public face, FR6's pointer rule and numeric states, and the maps template.

Automated review (maintainer link)

Comment on lines +458 to +459
- Details `spec:AST-112` FR1 (the gesture owner and gesture root in the
core) and FR7, and `spec:AST-140` FR2, FR3, FR5, and FR6, for this group.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking (missed in earlier reviews): spec:AST-112 FR1 on main names the gesture owner and gesture root in the core, but the amendment this record merges after rewrites FR1 and leaves each group's pieces to its record through FR7's table ("Gestures and drag | spec:AST-124 | core"). Once it lands, this line points at a list that no longer exists. State it like the lines below it, for example "Relies on spec:AST-112 FR1 and FR7 (amended): this group's pieces link in the core".

Comment on lines +354 to +357
- **FR16 — Gesture handles.** Each recognizer of a mounted Astryx gesture view
has a handle, so a recognizer from outside Astryx, such as a
react-native-gesture-handler gesture or a custom native recognizer, declares
its relationship to it (`spec:AST-112/FR18`). Astryx's own recognizers relate

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking (missed in earlier reviews): the pan-zoom surface's onTap and the zoom pager's onPagerTap fire for a one-finger tap once the double-tap window closes (lines 227-229 and 251), which Core's TapGestureRecognizer models as a recognizer of its own. If that tap is its own recognizer, give it a name below (for example tap); otherwise narrow this sentence to the names listed.

Comment on lines +340 to +345
- **FR14 — Contracts grow by named features.** The group's contracts grow by
named features (`spec:AST-140/FR5`). FR3 to FR10 and FR16 describe each
contract's baseline. The pinch view is the group's named feature,
`AstryxPinchScaleView.pinch` (FR17): JavaScript reads it through
`contractFeatures('AstryxPinchScaleView')` before it renders the view, and
checks every named feature before it uses it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: this puts the record on one model, but it departs from the two drafts it applies. The amended spec:AST-112 FR7 says "Every view has an is<View>Available() probe", and draft spec:AST-140/FR5 makes a named feature "a new optional method, a new optional prop, or a new value in a closed set" added after a contract's baseline. A whole view as a named feature is part of the owner's decision on this record; whichever record yields should say so.

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ready to approve yet: the gesture and drag record waits on an engineering owner's decision, and one description fix is needed.

Approval needs an engineering owner to approve the new requirements in draft spec:AST-124 (FR1–FR17, DEC-1–DEC-7) by commenting /approve-spec <full head SHA> on this pull request; the author may do so as an engineering owner. That decision includes which rule holds for Item where the native swipe row is absent: DEC-7's no drag, or the drawn swipe in the open Item React Native record.

Blocking:

  • The description says no open spec pull request overlaps this group, but the open Item React Native record (#12823) draws the swipe where the native row is absent, which DEC-7 now rules out; name it and the List React Native record (#12819) under "Existing authority searched" and call out the collision, or bring the two records into line.

Also worth a look: in a production binary without the views, DEC-7 leaves Item's swipe and the drag-and-drop components accepting props that do nothing, and FR11's promise that their accessibility actions "make every move the gesture makes" rests on actions no record defines for Draggable, ReorderableList and DropZone.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: the record specifies nine native components, a gesture handle module and their shared rules. Verified (the record's two contract tables).
  • Claim: it relies on the amended React Native foundation record for default linking, internal gesture views and the handle API. Verified against that draft as it now stands on main.
  • Claim: it cites the platform-code record for missing pieces, results, named features, threading and coexistence. Not checkable: that record is not on main.
  • Claim: the native-first and native-guidelines records say nothing about gesture ownership, UI-thread motion or system drag and drop. Verified.
  • Claim: the pinch and the handle relationships use the vocabulary of Core's web recognizers. Verified against Core's pinch recognizer and its simultaneous and require-to-fail relations.
  • Claim: no overlapping spec pull request exists for this group, and any ownership collision is called out. False: the open Item React Native record states the opposite absent-view rule (blocking finding above).
  • Claim: no rejected alternatives are recorded, and Non-goals keep only the template's two standing bullets. Verified.
  • Claim: the first open question is answered as a decision, and the other two keep their options. Verified.
  • Claim: rubric results (no narration words, no pull request or issue references, three gap lines in the required form). Verified.
  • Claim: the knowledge check, Prettier and the whitespace check pass. Verified on this head.
  • File: the gesture and drag spec record. One blocking finding (the description's overlap claim, against the new decision on absent views); non-blocking notes; owner decision pending.

Automated review (maintainer link)

Comment on lines +310 to +314
probe tells the caller. There, `Item` (its swipe actions) and the
drag-and-drop components (`Draggable`, `ReorderableList`, `DropZone`) take
no drag and draw no gesture of their own: they keep their accessibility
actions, which make every move the gesture makes, and each warns once in
development (DEC-7). The pinch view is detected through its named feature

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the owner deciding DEC-7: the open Item React Native record (#12823) says the opposite in its FR16 ("Where the native swipe row is absent (spec:AST-124 FR11), the row draws the swipe with the same rules"), and its description reads this FR11 as leaving that choice to the component, as it did before this head. In a production binary without the views these components also accept their props while the drag does nothing, since the warning is development-only; spec:AST-082 FR3 (current) says "A platform never offers a prop it does not fully honor". Whichever rule holds, one of the two records has to change, and the pull request description should name the collision.

Comment on lines +558 to +561
`Item` and the drag-and-drop components drag only through their native views,
so each platform has one drag path, the one this record specifies. Where the
view is absent they take no drag, keep their accessibility actions and warn in
development; the accessibility actions keep every move reachable.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: "the accessibility actions keep every move reachable" rests on actions no record defines for Draggable, ReorderableList and DropZone, and FR12 gives iOS drag and drop accessibility to the native views' own drag action and drop points (lines 327-329), which are gone in exactly this case. Name the records that must state those actions, or say in FR12 that these components carry a custom action for every move on iOS too.

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ready to approve yet: the gesture and drag record waits on an engineering owner's decision, and two fixes are needed whatever that decision is.

Approval needs an engineering owner to approve the new requirements in draft spec:AST-124 (FR1–FR17 and DEC-1–DEC-8), which no current record states, in particular DEC-8's lab route for pan and zoom, DEC-7's no-drag fallback against spec:AST-082 FR3, FR16's handle API with no named exporting entry, and the pinch view as a whole-view named feature with no probe. An engineering owner records that by commenting /approve-spec <full head SHA> on this pull request; the author may do so as an engineering owner.

Blocking:

  • DEC-8 (spec.md:564-573) answers draft spec:AST-112 OQ7 (where a React Native–only component with no Core counterpart starts) for the pan-zoom component, so add that to Current-state impact or defer DEC-8 to OQ7, and say in the Who-uses-it row that the maps template reaches the view through that component.
  • The description's "Existing authority searched" still calls #12823 a collision, but that record's FR16 and its "native swipe row absent" state now follow DEC-7, so update that bullet and drop the collision call-out.

Seven non-blocking notes still stand on the record: the one-finger tap handle, the pinch view's probe, the missing ScrollView record, mouse drags on Item rows, the swipe row's numeric states, Current-state impact's FR1 line, and DEC-7's accessibility actions.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: merges after the React Native foundation and platform-code records: verified, both merged.
  • Claim: nine native components and one gesture handle module: verified against the FR10 tables.
  • Claim: relies on the foundation record's amended FR3 and FR5 and gives the handle API its FR18 points to: verified against the current foundation draft.
  • Claim: cites the platform-code record's FR2, FR3, FR5, FR6 and FR9: verified.
  • Claim: the native-first and native-guideline records say nothing about gesture ownership, UI-thread motion or system drag and drop: verified.
  • Claim: the pinch and handle vocabulary follows Core's web recognizers: verified (PinchGestureRecognizer, requireToFail, recognizeSimultaneouslyWith).
  • Claim: the open Item record draws the swipe where the native row is absent, a collision: false, it now follows DEC-7.
  • Claim: the open List record relies on FR17 and DEC-6 and states no absent-view rule: verified.
  • Claim: the foundation record names the gesture hosts only as members of the core: imprecise, it places the group in the core through its FR7 table and names no host.
  • Claim: OQ1 and OQ3 are answered by DEC-7 and DEC-8, and OQ2 keeps its options, a lean and a settling test: verified.
  • Claim: rubric R1, R5 and R7 results (no narration words, no pull request or issue references, three gap lines): verified.
  • Claim: the knowledge check, Prettier and the whitespace check pass: verified.
  • File: docs/specs/AST-124-react-native-gestures-drag/spec.md: two blocking findings (DEC-8, and the description it ships with) and seven non-blocking notes.

Automated review (maintainer link)

Comment on lines +569 to +573
Free pan and zoom of large content reaches apps through a component with an
Astryx API, so `AstryxPanZoomView`'s public face is a designed Astryx component
that renders it, and the native view itself is not exported. That component
starts in the React Native lab (`./unstable/*`, `spec:AST-112/FR5`), and its own
component record brings its name and props.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This answers draft spec:AST-112 OQ7 for one component: Core and Lab have no pan-zoom component, and spec:AST-112 FR16 says "Where a React Native–only component with no Core counterpart starts is OQ7", whose first option is "in the React Native lab under ./unstable/*, graduating once it has a Core contract". Add it to Current-state impact (for example "Answers spec:AST-112 OQ7 for the pan-zoom component: it starts in the React Native lab under ./unstable/*"), or defer DEC-8 to OQ7's answer. The Who-uses-it row (line 79) should also say the maps template reaches the view through that component, since the view is not exported.

This branch was successfully deployed

1 active (outdated) deployment
Preview — ce1139ee Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant