Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
There was a problem hiding this comment.
This pull request is on hold for an owner decision: AlertDialog's touch motion rests only on draft spec:AST-094 (FR4, FR5, FR7, FR8 and DEC-1), and FR4 narrows the current architecture:theme-tokens INV3, so an engineering owner has to approve or amend those requirements. An engineering owner records the decision by commenting /approve-spec <full head SHA> on the pull request, and the author may do so if they are an engineering owner. Separately from that decision:
- Land the stacked pull requests first and rebase, so this diff is only the AlertDialog motion commit instead of 25,379 authored lines.
- While the alert fades out under touch, keyboard and assistive-technology activations still run
onAction, and Escape callsonOpenChange(false)again; make the leaving alert inert. - Under React StrictMode, an AlertDialog that mounts open never starts its presentation and stays invisible and modal; the status effect should own and clean up its animation frame.
- The
adaptivethreshold change contradictscomponent:SelectorDEC-1; split it out or keep the current query. - The
lintjob failed on this head with an ESLint out-of-memory error and needs a rerun.
[Automated review]
PR Analysis Report
Generated by PR Enrichment workflow | View current CI run |
f3b37d2 to
6e2412f
Compare
There was a problem hiding this comment.
This pull request is on hold for an owner decision: AlertDialog's touch motion rests only on draft spec:AST-094 (FR4, FR5, FR7, FR8 and DEC-1), and FR4 narrows the current architecture:theme-tokens INV3, so an engineering owner needs to approve or amend those requirements. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so if they are an engineering owner. Separately from that decision:
- Land the stacked pull requests first and rebase, so this diff is only the AlertDialog motion commit instead of 26,547 authored lines.
- While the alert fades out under touch, keyboard and assistive-technology activations still run
onActionand Escape callsonOpenChange(false)again; make the leaving alert inert. - Under React StrictMode, an AlertDialog that mounts open never starts its presentation and stays invisible and unresponsive to touch; let the status effect own and clean up its animation frame.
- The
adaptivethreshold change contradictscomponent:SelectorDEC-1; split it out or keep the current query. - The
lintjob runs out of memory on this head while the base passes.
[Automated review]
6e2412f to
b635c03
Compare
There was a problem hiding this comment.
This pull request is on hold for an owner decision: AlertDialog's touch motion rests only on draft spec:AST-094 (FR4, FR5, FR7, FR8 and DEC-1), and FR4 narrows the current architecture:theme-tokens INV3, so an engineering owner needs to approve or amend those requirements. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so if they are an engineering owner. Separately from that decision:
- Land the stacked pull requests first and rebase, so this diff is only the AlertDialog motion commit instead of 27,525 authored lines.
- While the alert fades out under touch, keyboard, click and assistive-technology activations still run
onAction, and Escape callsonOpenChange(false)again; make the leaving alert inert. - The
adaptivethreshold change contradictscomponent:SelectorDEC-1; split it out or keep the current query. - The
lintjob runs out of memory on this head whilemainpasses. - Add a StrictMode mount-open test for the new motion effect; the StrictMode presentation issue raised on the earlier head no longer applies.
[Automated review]
b635c03 to
1c55503
Compare
There was a problem hiding this comment.
This pull request is on hold for an owner decision: AlertDialog's iPhone and iPad motion rests only on draft spec:AST-094 (FR5, FR7, DEC-1), and that record's FR4 and DEC-1 forbid the theme-tunable touch motion this head adds through defineTheme({motion: {springs, durations, curves}}), so an engineering owner needs to settle which holds, and whether the two non-component experimental subpaths are an acceptable boundary under spec:AST-017 FR21. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request once the record says so, and the author may do so if they are an engineering owner. Separately from that decision:
- While the alert fades out on iOS, keyboard and assistive-technology activations still run
onActionand Escape callsonOpenChange(false)again; make the leaving alert inert. - Under Reduce Motion the iOS fades last 404 ms on a spring, but
design:reduced-motionDR2 allows an opacity-only change of 200 ms or less, and DR4 bars theme values that lengthen it. - The compact test's 744 px width contradicts
spec:AST-012FR9 (the theme'smdpoint or a height under 500), and theplatformadaptation condition extends the vocabulary FR2 closes. - Land the stacked pull requests first and rebase, so this diff is only the AlertDialog motion commit instead of 31,379 authored lines.
- Add a StrictMode mount-open test for the new motion effect.
[Automated review]
1c55503 to
6dca4bf
Compare
|
Addressed at 6dca4bf:
Waiting in the reviewers' queue: the spec decision (draft AST-094 FR4, FR5, FR7, FR8, DEC-1 and theme-tokens INV3; the alert's springs and durations are now theme motion roles) and the |
There was a problem hiding this comment.
This pull request is on hold for an owner decision: AlertDialog's iPhone and iPad motion rests only on draft spec:AST-094 (FR5, FR7, DEC-1), and that record's FR4 and DEC-1 forbid the theme-tunable touch motion this head adds through defineTheme({motion: {springs, durations, curves}}), so an engineering owner needs to settle which holds, and whether the two non-component experimental subpaths are an acceptable boundary under spec:AST-017 FR21. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request once the record says so, and the author may do so as an engineering owner. Separately from that decision:
- Under Reduce Motion the iOS fades last 404 ms on a spring, but
design:reduced-motionDR2 allows an opacity-only change of 200 ms or less, and DR4 bars theme values that lengthen it. - The changeset and docs say no click, key or assistive-technology activation reaches the alert during either transition, but during the entrance they still run
onActionandonOpenChange; gate them until the presentation completes or narrow the text. - The compact test's 744 px width contradicts
spec:AST-012FR9 and the compact definitionmainnow exports, and theplatformadaptation condition extends the vocabulary FR2 closes. - Land the stacked pull requests first and rebase, so this diff is only the AlertDialog motion commit instead of 31,567 authored lines.
[Automated review]
6dca4bf to
3b4bd41
Compare
|
/approve-spec bead618 |
There was a problem hiding this comment.
Requesting changes: one evidence gap remains. An engineering owner approved the spec content at this head, so the touch look, the exit fade over an inert page with live toasts, the phone width and the spec:AST-094 FR5 exit-copy rule are settled direction; the reduced-motion docs fix and the transientCopy.ts merge resolution look right.
Blocking:
- The new touch exit has no device evidence at this head:
spec:AST-094Platform support and DEC-27 ask for Android Chrome with Gboard in the emulator at the exact head (animations at normal scale and removed, plus a slow-device profile), and the approved FR6/PR2 row asks for the owner's iOS Safari pass at the exact head, but the description's runs are for the previous commit or older, and this head merges main, which now builds the exit copy's clone inmotion/inertClone.ts.
Posting those runs for the head intended to merge clears the request; so would the record owners amending DEC-27 and the FR6/PR2 row to accept evidence carried across a merge of main.
[Automated review]
|
/approve-spec 31e5375 |
|
The description now carries device evidence for the head to merge. Android exit timing, interleaved against main in one session on an emulator, passes on both cases: on storybook-delete the exit copy's first frame comes at a median 21 ms after the tap, with a median close gap of 74 ms against main's 60; on the alert over a toast, 52 ms, with a gap of 144 ms against main's 80. They were measured at bead618. This head, 31e5375, keeps bead618's own changes; its merge of main brings the sandbox page and changes outside the exit copy's path, so the runs carry (maintainers' ruling). The owner's iOS visual pass carries the same way. |
There was a problem hiding this comment.
Requesting changes: one evidence gap remains. An engineering owner approved the spec content at this head, so the touch entrance, the exit fade over an inert page with live toasts, the 320 px phone width and the spec:AST-094 FR5 exit-copy rule are settled direction, and the code has no blocking finding.
- Exact-head device evidence is missing:
spec:AST-094Platform support and DEC-27, and the approved FR6/PR2 row incomponent:AlertDialog, require the Android Chrome emulator runs with Gboard (animations at normal scale, removed, and a slow-device profile) and the owner's real-device iOS Safari pass at the exact head, but the runs in the description are for earlier commits; post them for the head you intend to merge, or have the record owners amend DEC-27 and the FR6/PR2 row to accept evidence carried across a merge of main.
Non-blocking: the comment at useAlertMotion.ts:42-46 reads more easily as two sentences, a rewording you have moved to #8095. The stack line does not hold yet, because #8095's head does not contain this head, so this review covers this pull request alone.
[Automated review]
An alert's touch exit holds the page, and the hold made every child of the body inert, the page's shared live regions too. A toast the alert's action raised was then written to an inert region, which assistive technology does not read. A live region with nothing focusable in it now stays live under a hold: it takes no input. One that holds something focusable stays inert.
|
/approve-spec 77caa21 |
There was a problem hiding this comment.
Requesting changes. An engineering owner approved the spec content at this head, so the touch entrance, the exit fade over an inert page with live toasts, the 320 px phone width, the spec:AST-094 FR5 exit-copy rule and the new live-region rule are settled direction; two items remain.
- Exact-head device evidence is missing:
spec:AST-094Platform support and DEC-27, and the approved FR6/PR2 row incomponent:AlertDialog, require the Android Chrome emulator runs with Gboard (animations at normal scale, removed, and a slow-device profile) and the owner's real-device iOS Safari pass at the exact head, and the description says the runs for this head are pending. - The changeset's new sentence (
.changeset/alertdialog-touch-motion.md:7) says the page's live regions stay live through the fade, but the hold keeps only top-level live regions with nothing focusable live, so a region inside the page, such as Button's loading region, still drops what is written to it; please narrow the sentence to the shared announcement channel and say that in-page regions stay inert until the fade ends.
Non-blocking: the comment at useAlertMotion.ts:42-46 still reads more easily as two sentences, a rewording you have moved to #8095. The stack line does not hold yet, because #8095's head does not contain this head, so this review covers this pull request alone.
[Automated review]
The hold keeps only the page's top-level live regions with nothing focusable live, so only the shared announcement channel is read during the fade. A live region inside the page's content stays inert until the fade ends, and the changeset now says so.
|
/approve-spec 5ee2465 |
There was a problem hiding this comment.
Requesting changes: one evidence gap remains. An engineering owner approved the spec content at this exact head, so the touch entrance, the exit fade over an inert page with live toasts and readable announcements, the 320 px phone width and the spec:AST-094 FR5 exit-copy rule are settled direction, and no code defect was found.
- Exact-head device evidence is missing:
spec:AST-094Platform support and DEC-27, and the approved FR6/PR2 row incomponent:AlertDialog, require the Android Chrome emulator runs with Gboard (animations at normal scale, removed, and a slow-device profile) and the owner's real-device iOS Safari pass at the exact head, and the description reports them only for earlier commits.
The stack line does not hold yet, because #8095's head does not contain this head, so this review covers this pull request alone.
[Automated review]
A toast the alert's action raises is written to the page's shared announcement region in the next frame, which on a slow device ends with the close's long frame. The changeset now says only that it is read.
|
/approve-spec 643313e |
There was a problem hiding this comment.
Requesting changes: two items remain. An engineering owner approved the spec content at this exact head, so the touch entrance, the inert fade-out with toasts kept live, the 320 px phone width and the spec:AST-094 FR5 exit-copy rule are settled direction.
- Newly live check:
packages/core/src/Layer/modalOutlet.ts:61keeps the new global-host set in module state while the input hold that reads it keeps its own store under a shared key, so a swizzled AlertDialog's touch close makes the package ToastViewport's host inert; register the set withrealmValue(sharedKey('layer/modal-outlet-hosts', 1), () => new Set<Element>()), asLayer/toastHost.tsxnow registers the toast viewport. - Exact-head device evidence is missing:
spec:AST-094Platform support and DEC-27, and the approved FR6/PR2 row incomponent:AlertDialog, require the Android Chrome emulator runs with Gboard (animations at normal scale, removed, and a slow-device profile) and the owner's real-device iOS Safari pass at the head that merges, and the description lists both as pending for this head.
The stack line does not hold yet, because #8095's head does not contain this head, so this review covers this pull request alone.
[Automated review]
The global hosts that move into the latest open modal lived in module state, while the input hold that reads them keeps its own state under a shared key. A swizzled copy's hold therefore saw no host and made the package's toast viewport inert during an alert's fade. The set is now registered under a shared key too.
There was a problem hiding this comment.
Requesting changes: one piece of device evidence remains. The spec content is owner-approved at this exact head, every code change matches it, and the Android emulator runs in the description now cover this head.
- The approved FR6/PR2 verification row in
component:AlertDialogasks for the record owner's real-device iOS Safari pass at this head, and the iPhone 14 run in the description does not say the record owner made or confirmed it.
Once the record owner confirms that run, or posts their own, for this head, nothing else blocks. Two non-blocking notes stay open on their lines, with follow-ups already agreed: a swizzled copy's input hold still announces its shield only to its own listeners (Layer/inputHold.ts:494), and the comment at useAlertMotion.ts:147 restates the ref's name.
[Automated review]
| const blurredRef = useRef<HTMLElement | null>(null); | ||
| // The exit copy, from the commit that closes the alert to its layout effect. | ||
| const exitCopyRef = useRef<TakenLayerExitCopy | null>(null); | ||
| // Whether a reopen cut the last fade short. |
There was a problem hiding this comment.
Non-blocking (INV29): this restates isCutShortRef. Drop it, or say why the ref exists: "Set by the exit's cleanup. A reopen reads it to open at rest."
There was a problem hiding this comment.
Agreed. The comment will say why the ref exists in the next change to this file.
|
/approve-spec e30bc88 |
The global hosts that move into the latest open modal were shared across copies of Core through a raw realm key. They now take their own page-wide slot, layer/modal-outlet/hosts, beside the outlet state that every copy shares. The outlet state keeps its shape and its version, so a copy built without the hosts still shares the outlets. A set per copy fails both two-copy tests in modalOutlet.shared.test.ts, and the shared slot passes them.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision on the spec content at this head. The record edits in component:AlertDialog, spec:AST-094 and architecture:layer-runtime are unchanged since the last approval, but that approval named the previous commit; an engineering owner (the author included) records the decision by commenting /approve-spec followed by the full head SHA. After that, one blocking item remains:
- The iOS Safari device pass and the Android Chrome emulator runs (normal motion, Remove animations and a slow profile) need to be taken again at this head, because it changes
Layer/modalOutlet.tsand mergesmainchanges intoLayer/layerExitCopy.ts, sospec:AST-094DEC-31 does not carry the earlier runs, and the description's evidence still names the previous revision.
The host set's move to its own shared slot settles the earlier note about a swizzled copy's shield; one non-blocking note stays open: the comment at useAlertMotion.ts:147 restates the ref's name.
[Automated review]
| | Contract | Verification | Representative states | Mutation or failure expectation | Audit section | | ||
| | ------------ | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | --------------------------------- | | ||
| | FR1–FR5 | `AlertDialog.test.tsx` ("calls onOpenChange(false) on Escape", "does not call onOpenChange when action is clicked", "does not call onAction on Escape", "does not disable the cancel button while the action is loading", "exposes a named group instead, with no aria-modal") and `useImperativeAlertDialog.test.tsx` ("opens on show()", "closes on hide()") | open, loading, inline, imperative | Escape not cancelling, the action closing by itself, or the inline path claiming the role fails. | `audit:AlertDialog/behavior` | | ||
| | FR6, PR2 | `useAlertMotion.test.tsx` (the touch look, the start scale, an exit that closes at once at 0 ms, the close with the exit copy's fade, the backstop, a reopen mid-exit, a server-rendered open that opens at rest); `AlertDialog.motion.interaction.browser.spec.ts` under a coarse pointer in Chromium and WebKit (the presentation on the theme's entrance tokens, a reopen that enters with its dimming again, the fade on the exit copy on the exit tokens with the dialog exit switch off and on, the viewport start, reduced motion with its 200 ms dimming and exit) and in Chromium frames through a 1 s main-thread block; the same 1 s block on the iOS simulator in Safari; the owner's real-device pass on iOS Safari at the exact head, and with it the Android Chrome emulator recording at the exact head (Chrome with Gboard; default, Remove animations and a slow profile; `spec:AST-094` DEC-27) | present, dismiss with the dialog exit switch off and on, reopen during dismiss, reopen after dismiss, an open in server markup, Reduce Motion, a fine pointer, a narrow viewport | a timing off the theme's tokens, a start outside the viewport, a dismissal without its fade, a scale or a dimming over 200 ms under Reduce Motion, an entrance replayed after hydration, a reopen without the dimming's entrance, changed motion under a fine pointer, or an element besides the exit copy fails. No test checks a turn-back on interruption, which does not ship. | `audit:AlertDialog/behavior` | |
There was a problem hiding this comment.
Blocking (evidence gap): this row, and current spec:AST-094 Platform support and DEC-27, want the iOS Safari device pass and the Android Chrome emulator runs at the exact head. DEC-31 does not carry the earlier runs here: this head changes Layer/modalOutlet.ts, and its merge of main changes Layer/layerExitCopy.ts. Take both again at this head, and update the description's head references.
|
/approve-spec ec87860 |
There was a problem hiding this comment.
Requesting changes: one evidence gap remains. The spec content in component:AlertDialog, spec:AST-094 and architecture:layer-runtime now has an engineering owner's approval at this head, so the touch entrance, the close with a fading copy over an inert page that keeps toasts live, and the 320 px phone width all have current authority.
- The iOS Safari real-device pass and the Android Chrome emulator runs (normal animations, Remove animations and a slow profile) still need to be taken at this head, as
spec:AST-094Platform support and DEC-27 and the approved FR6/PR2 verification row require; DEC-31 does not carry the earlier runs, because this head changesLayer/modalOutlet.tsand its merge ofmainchangesLayer/layerExitCopy.tsandLayer/modalOutlet.ts.
One non-blocking note stays open: the comment at useAlertMotion.ts:147 restates the ref's name.
[Automated review]
|
The real-iPhone pass is now taken at this head (ec87860): an iPhone 14 (iOS 26.2, Safari) beside 3ec5192, with real touches. The touch entrance, the close with its fading copy and live toasts, and Reduce Motion pass, and the close's timing matches main 841b486. The description's Testing section has the measurements, including the one difference in the dimming's first frame. The Android emulator runs at this head are next. |
Stack: #8084 → #8095
Behavior module: AlertDialog's touch motion (
useAlertMotion).User need
On a phone, AlertDialog plays its desktop entrance and closes at once. The iOS alert shrinks in from 1.2 as it and the dimming fade in, and fades out to close.
Problem and solution fit
Current specification
component:AlertDialogFR6, FR7 and FR9, with DEC-4 (spec:AST-094FR45), andspec:AST-094FR5 for the exit copy's start. The touch exit plays with the dialog exit switch off (spec:AST-090FR14). Toasts stay operable above the modal and under an input hold (spec:AST-003FR16, FR18).Public delta and caller burden
No API change; a mouse keeps today's motion, and a caller's
widthwins. Private changes:takeLayerExitCopy).Design and alternatives
The alert's keyframes run on the compositor, and the dimming inherits their timing. The copy is taken in the closing commit and placed after Dialog's close, so the page's styles cannot win over its fade. Its fade waits for a frame that shows it whole: WebKit can animate a new layer before its first paint. A fade on the live dialog would mount the top layer outside the layer runtime (
architecture:layer-runtimeINV14).Evidence
modalOutlet.shared.test.tsfail.Scope
Components: AlertDialog, Layer, Toast, motion
Testing
This head (ec87860) is e30bc88 with a merge of main 841b486 and the hosts' shared slot. At this head, with 1 worker:
pnpm build, the Storybook build, Prettier and ESLint on the changed files,check:knowledge,check:syncandcheck:changesetspass.On a real iPhone 14 (iOS 26.2, Safari) at this head, beside 3ec5192, with real touches on
/pages/alert-dialog-cases/:The merge guard runs the Android exit-timing check at this exact head before it merges.
The cost of the tap's task, at 7235482 (Chromium, minified Storybook, 16 closes per arm, medians). Main closes at once with no fade:
History
Checks on earlier heads; none of them carries to this head.
pnpm test:ui(23,426),pnpm test:node(17,781), and 191 Chromium and 168 WebKit browser cases.Writing rubric results
component:AlertDialog: PR2 says the entrance plays on the dialog surface and its::backdrop. The dismissal fades on the layer runtime's one exit copy (architecture:layer-runtimeINV13), and AlertDialog renders no other element under a touch presentation. The FR6/PR2 verification row names the copy, the reopen case and "an element besides the exit copy fails". FR6 plays the theme's tokens, with the exit fade on even while the dialog exit switch is off. Its turn-back clause carries an implementation gap, listed under Current-state impact. FR7 ships whole: its gap sentence and its Current-state entry are gone. Its verification row names the entrance and exit cases with all five cells. DEC-4, readiness,system_specs, Governing rules and the FR6/PR2 verification row match what ships. No motion role is added.spec:AST-094: FR5 gains the spec owners' sentence, verbatim:The verification table gains the row "FR5 exit copy". A block between the copy's first and second frame shows the copy fully visible, then one whole fade.
verified_bygains AlertDialog's motion spec, which holds that case.AlertDialog.motion.interaction.browser.spec.ts, listed inverified_by.architecture:layer-runtime: two present-tense changes. The modal-outlet paragraph says that an input hold can make a layer's content inert, or the page's. A host there stays live, as do the elements that hold it, and their other children go inert. It also says:The hold announces its shield's entry, so toasts stay operable above the shield too. INV13 names the copy that
takeLayerExitCopytakes and its owner places later.verified_bygainsLayer/inputHold.test.tsx, which holds the deeper-host case and the live-region cases.inputHold.test.tsx(the deeper host),ToastViewport.modalHost.test.tsx(the shield's entry) andlayerExitCopy.test.ts(take, then place), all in the record'sverified_by.